Conversation
|
I presume this is addressing Issue #24. I see how the metaverse URL is passed down from the login dialog and through all the layers (dialog => Account.login => buildURL) but it isn't integrated with the global settings. For instance, if the app was connected to metaverse X and then did a login for and account in metaverse Y, the global logged-in-account (Account.) variables will be set to this new account but the metaverse info would be lost (the Account. doesn't store the metaverseURL and MetaverseMgr.ActiveMetaverse will be pointing to a different metaverse. |
Misterblue
left a comment
There was a problem hiding this comment.
There are several calls to Utility.connectionSetup() which takes a domain URL. Since this code is setting a metaverse-server URL, these should be calls to Utility.metaverseConnectionSetup(). Also, the code explicitly sets the value of $Store.metaverse.server when there is a more general mutation of StoreActions.UPDATE_METAVERSE. It's bad practice to do direct store updating when a mutation or action should be defined so the next person knows what operations happen on $Store.
Misterblue
left a comment
There was a problem hiding this comment.
The addition of the optional metaverseURL to some functions is confusing/wrong.
Why remove the explicit use of the BABYLON prefix to functions and variables. Since some graphics names are reused, it is often nice to know one is using the BABYLON.Vector3 rather than another package's definition of a Vector3. Just a style question and not a functional question.
d0c6125 to
507ff53
Compare
c0e1bda to
b120d11
Compare
No description provided.