Add pure and access fragment functions for expressions#908
Open
jackstodart wants to merge 1 commit intoviperproject:masterfrom
Open
Add pure and access fragment functions for expressions#908jackstodart wants to merge 1 commit intoviperproject:masterfrom
jackstodart wants to merge 1 commit intoviperproject:masterfrom
Conversation
marcoeilers
reviewed
Mar 31, 2026
| (rec(left), rec(right)) match { | ||
| case (Some(left2), Some(right2)) => Some(And(left2, right2)(and.pos, and.info, and.errT)) | ||
| case (Some(left2), None) => Some(left2) | ||
| case (None, Some(right2)) => Some(right2) |
Contributor
There was a problem hiding this comment.
I think this case is tricky. What if I have i in bounds && acc(s[i].f), then I need to know the first part for the second part to be well-defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a function to split expressions into their pure/functional fragment and their access component. Includes convenience function to split predicate bodies in pure and access fragments.