Conversation
jcp19
commented
Aug 26, 2025
This was
linked to
issues
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
"hello"[1])swith the contents of a slice obtained with[]byte(s). This fixes issue Low sensitivity doesn't transfer when convertingstringto[]byte#831.swith the contents of the stringstring(s). This partially addresses issue Low sensitivity doesn't transfer when converting[]bytetostring#832 (see my comment there).At the moment, violating the precondition of an indexing operation (i.e., passing an invalid index to a string) leads to a bad error message, similar to
precondition of unknown may not hold. This is similar to other parts of our encoding, where we are not able to generate good error messages when the precondition of a function internal to our encoding may not hold. PR viperproject/silver#815 will hopefully allow us to fix that by attaching an error message to the precondition directly in the encoding.