fix: codex stop hook guidance output - #75
Open
obrunogonzaga wants to merge 1 commit into
Open
Conversation
obrunogonzaga
marked this pull request as ready for review
July 1, 2026 13:12
vinilana
reviewed
Jul 5, 2026
Comment on lines
+618
to
620
| continue: true, | ||
| systemMessage: expect.stringContaining('feature-x'), | ||
| }); |
Owner
There was a problem hiding this comment.
We should prevent this to happen to other harnesses as well, this is why it was a generic message, we should map to Codex output and so others instead of only covering it here for Codex, because we support other tools, @cursoragent can you help us here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stopworkflow guidance tosystemMessageinstead ofhookSpecificOutput.SessionStartguidance behavior unchanged.Root cause
Codex rejects active
Stophook stdout that only containshookSpecificOutput. With active PREVC guidance, dotcontext emitted that shape, so Codex reportedhook returned invalid stop hook JSON output.Validation
npx jest src/integrations/__tests__/hookRoundTrip.test.ts --runInBandnpx jest src/cli/services/__tests__/hookDispatchService.test.ts --runInBandnpm test -- --runInBandnpm run buildFixes #74