fix: support exactOptionalPropertyTypes (fix vikejs/vike#3251)#219
Merged
Conversation
brillout
changed the title
exactOptionalPropertyTypes (fix vikejs/vike#3251)exactOptionalPropertyTypes (fix vikejs/vike#3251)
3 tasks
suliemandev
added a commit
to rudderjs/rudder
that referenced
this pull request
May 15, 2026
vikejs/vike#3251 was closed 2026-05-15 — vike-react 0.6.23 ships the fix internally (vikejs/vike-react#219). Drop the `} as unknown as Config` workaround across all React-path +config.ts files: - playground/pages/+config.ts + _error/+config.ts - playground-web/pages/+config.ts + _error/+config.ts - create-rudder-app templates: pages/index.ts (react default + multi- framework root), pages/demo.ts, pages/error.ts, pages/ai-chat.ts — react `default:` branches only Vue/Solid scaffolder branches preserve the cast: vike-vue and vike-solid didn't ship an equivalent fix and weren't empirically tested without the cast. Pinned vike-react `^0.6.20` → `^0.6.23` in playground, playground-web, and the scaffolder's package-json template. Snapshot baseline in templates.snapshot.test.ts recaptured (65497 → 65481 bytes, new hash).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.