Governance expansion and risk remediation#42
Merged
Polichinel merged 12 commits intodevelopmentfrom Apr 7, 2026
Merged
Conversation
… risks
Expand governance framework and address 10 risk register items identified
during repo-assimilation, expert-code-review, and test-review audits.
Governance additions:
- ADR-004: activate evolution and stability rules (three-tier classification)
- ADR-010: technical risk register as governance artifact
- CICs: PackageScaffoldBuilder, IntegrationTestRunner
- Standard: physical architecture (heuristic, not strict)
- Risk register: 30 entries seeded from audits
Code changes:
- Remove warnings.filterwarnings("ignore") from all 74 main.py files (C-12)
- Migrate white_mustang to new CLI pattern, remove wandb.login() (C-25)
- Unify DARTS/HydraNet manager instantiation to single-variable pattern (C-24)
- Delete placeholder models thousand_miles and thrift_shop (C-09)
- Add ViewsMonth-to-date mapping comment in config_partitions.py (C-21)
Test additions:
- test_algorithm_coherence.py: validate algorithm-to-package mapping (C-04, C-08)
- Extend test_cli_pattern.py to cover ensembles + add warning suppression check
- Add 5 red-team tests to test_failure_modes.py (C-15, C-23)
Risk register status: Open 17 | Mitigated 4 | Resolved 3 | Accepted 3
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…workflow Remove unused imports/variables in tooling scripts, fix PEP 8 None comparisons, create missing rude_boy requirements.txt, normalize purple_alien version pinning, and add set -e to catalog CI step to catch silent failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Create meta/partitions.json as single source of truth for partition boundaries. Add scripts/update_partitions.py to rewrite all 73 config files from it. Extend test_config_partitions.py to cover extractors and postprocessors, read canonical values from source-of-truth, detect undeclared overrides, and check for data leakage. Fix ucdp_extractor's non-standard boundaries (copy-paste from stale rude_boy root file). Delete dead rude_boy root-level config_partitions.py. Add gitignore negation rules for requirements.txt and partitions.json. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add 16 tests pinning the behavior of pure functions in create_catalogs.py, update_readme.py, and generate_features_catalog.py. Covers table generation, section replacement, repo structure rendering, and queryset Column regex extraction. Scripts cannot be imported directly (views_pipeline_core dependency) so logic is duplicated as characterization tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace direct open(path, "w") with tempfile.NamedTemporaryFile + os.replace so a crash mid-write leaves only a temp file, not a corrupted README. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…del_scripts Add optional input_fn and get_version_fn keyword args to ModelScaffoldBuilder and pipeline_config to EnsembleScaffoldBuilder, enabling mocked testing without stdin or network. Fix == False to not in package validation. Add 9 tests (7 AST-based seam verification + 2 functional, skipped without views_pipeline_core). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Feature branches feature/reproducibilitygate pushed to views-stepshifter and views-baseline with story docs proposing ReproducibilityGate contracts. Patch approach (hardcoding keys in views-models) rejected as unsustainable. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…stream views-baseline now has a full ReproducibilityGate (ADR-014, CIC, 13 tests) on feature/reproducibilitygate. views-stepshifter still needs implementation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… upstream Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…al tests ModelScaffoldBuilder requires adjective_noun naming (validated by ModelPathManager). Tests used "test_scaffold_model" which fails in CI where views_pipeline_core is installed. Also adds error handling to update_partitions.py, trailing newline to .gitignore, and sync guidance to test_tooling_scripts.py docstring. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…in functional tests build_model_scripts() references self.requirements_path which is set by build_model_directory(). Functional tests skip directory creation, so the attribute must be set manually in test setup. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…oupling Add 6 tests for scripts/update_partitions.py covering: already_current, stale value update, dry-run, override skip, forecasting offset, and missing file error. Document private attribute access in scaffold builder functional tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
meta/partitions.json+ migration tool (scripts/update_partitions.py) + ADR-011. Override mechanism for declared deviations. Fixeducdp_extractorcopy-paste boundary error, deleted deadrude_boyroot config.create_catalogs.py, injection seams in scaffold builders (input_fn,get_version_fn,pipeline_config), CIset -efor catalog workflow.update_readme.py/generate_features_catalog.py, fixedrude_boymissingrequirements.txt, fixedpurple_alienpinned dependency.Risk register status
Test plan
pytest— 2649 passed, 35 skippedruff check— no new lint issues (pre-existing only in untouched files)scripts/update_partitions.py --dry-run— 73 files scanned, 0 updates neededmeta/partitions.jsonvalues match production boundariesNote on diff size
~80 of the 112 changed files are mechanical bulk changes to model
main.pyfiles (removingwarnings.filterwarnings("ignore")and unifying DARTS manager instantiation). The meaningful logic changes are in ~30 files.