Skip to content

feat(governance): add ADRs, CICs, risk register, and resolve easy-win risks#41

Closed
Polichinel wants to merge 1 commit intodevelopmentfrom
feature/governance-expansion-and-risk-remediation
Closed

feat(governance): add ADRs, CICs, risk register, and resolve easy-win risks#41
Polichinel wants to merge 1 commit intodevelopmentfrom
feature/governance-expansion-and-risk-remediation

Conversation

@Polichinel
Copy link
Copy Markdown
Collaborator

Summary

  • Expand governance framework: activate ADR-004 (evolution/stability), add ADR-010 (risk register), 2 new CICs, physical architecture standard
  • Seed technical risk register with 30 entries from repo-assimilation, expert-code-review, and test-review audits
  • Remove warnings.filterwarnings("ignore") from all 74 main.py files (ADR-008 compliance)
  • Migrate white_mustang ensemble to new CLI pattern, remove direct wandb.login()
  • Unify DARTS/HydraNet manager instantiation across 16 models
  • Delete placeholder models thousand_miles and thrift_shop
  • Add test_algorithm_coherence.py (198 tests), extend test_cli_pattern.py to ensembles, add 5 red-team failure mode tests

Test plan

  • pytest — 2460 passed, 33 skipped, 1.37s
  • ruff check tests/ — all checks passed
  • validate_docs.sh — passed, no issues
  • grep -r filterwarnings models/*/main.py ensembles/*/main.py — 0 matches
  • grep -r cli.utils ensembles/*/main.py — 0 matches
  • Verify models still train correctly via run_integration_tests.sh (manual)

🤖 Generated with Claude Code

… risks

Expand governance framework and address 10 risk register items identified
during repo-assimilation, expert-code-review, and test-review audits.

Governance additions:
- ADR-004: activate evolution and stability rules (three-tier classification)
- ADR-010: technical risk register as governance artifact
- CICs: PackageScaffoldBuilder, IntegrationTestRunner
- Standard: physical architecture (heuristic, not strict)
- Risk register: 30 entries seeded from audits

Code changes:
- Remove warnings.filterwarnings("ignore") from all 74 main.py files (C-12)
- Migrate white_mustang to new CLI pattern, remove wandb.login() (C-25)
- Unify DARTS/HydraNet manager instantiation to single-variable pattern (C-24)
- Delete placeholder models thousand_miles and thrift_shop (C-09)
- Add ViewsMonth-to-date mapping comment in config_partitions.py (C-21)

Test additions:
- test_algorithm_coherence.py: validate algorithm-to-package mapping (C-04, C-08)
- Extend test_cli_pattern.py to cover ensembles + add warning suppression check
- Add 5 red-team tests to test_failure_modes.py (C-15, C-23)

Risk register status: Open 17 | Mitigated 4 | Resolved 3 | Accepted 3

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Polichinel Polichinel closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant