Repository navigation
Campus Wi-Fi limits, README map, handover tests - #36
Merged
Merged
Conversation
…ested - Campus Wi-Fi puts a whole class behind one address, and the sixth sign-up in an hour was being refused. Sign-up now allows 30 an hour per address and sign-in 60 a minute, while guessing one account's password is still stopped after 10 tries a minute, counted per account. - tools/build_campus.py also draws docs/campus_map.svg from the same table as the app's map, and the README shows it. - The README describes the two-sided handover and the limits. - Mutation testing of the handover found five untested cases (receiving a non-found item, not-received without a hand-in, someone else answering, staff receiving their own report, returning to the page). Tests added; all 21 handover mutants are now caught.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/campus_map.svggenerated from the campus table; README shows it and documents the handover and limits.Tests: 124 passing.