Open
Conversation
thefiddler
force-pushed
the
feature/html-macro
branch
from
effe952 to
b11b336
Compare
Owner
|
thank you @thefiddler! i'm so sorry but i've just merged a big refactor i've had sitting on the backburner. it hopefully shouldn't change too much for this PR or your other. would you be okay with
|
Author
- rsx_file! / rsx_file_borrow!: load RSX from external files - html! / html_borrow! / html_file! / html_file_borrow!: rsx aliases that avoid Dioxus CLI name collision - File paths resolve relative to CARGO_MANIFEST_DIR - include_bytes! emitted for automatic recompilation on file changes - Rebased on upstream/main (includes vidhanio#183 builder refactor)
thefiddler
force-pushed
the
feature/html-macro
branch
from
b11b336 to
7633314
Compare
Author
|
@vidhanio done, I merged both PRs in one and rebased on master. Let me know if you'd like any changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #184 and adds
html!,html_borrow!,html_file!andhtml_file_borrow!aliases to the correspondingrsx!macros. Using thehtml!alias instead ofrsx!fixes subsecond hotpatching (re #123) - the underlying issue is that dioxus-cli searches forrsx!by name and special-cases them, which doesn't work in our case.I have also added a subsecond example that you can try out:
@vidhanio let me know if this workaround makes sense upstream or if you would prefer a feature flag for it. This is easy enough to handle downstream, but I suspect a good subsecond hotpatching experience would be appreciated by end users.
Closes #123 #148