fix: removes localName assignment.#40
Conversation
|
I have created this PR because I have a problem with subtitles when I import video.js as an ES module in the browser. I see a similar PR on the official repo (mozilla/vtt.js#371) but it is still not merged. I wonder if we could merge the PR inside video.js fork to fix a problem. @gkatsev, any thoughts? |
|
Thanks for pinging again, totally forgot about it. Unfortunately, mozilla/vtt.js is basically unmaintained right now |
|
Yes, I think the same, I have done some tests for this PR and I haven't found any problems... It would be great to see it merged. |
|
This may allow us to remove a change we did in Video.js to ask rollup not to add "use strict" to the top of modules. |
|
Yeah, This is a great idea. |
We had to turn off strict mode (#4551) in Video.js due to a change in vtt.js. That has now been fixed in videojs/vtt.js#40 and released as part of 0.15.2 which will be available via #6333. Fixes videojs/vtt.js#15
This PR is related to #15 and removes the localName (read-only) assignment.