Skip to content

Feature: SoundCloud Audio provider - #9524

Merged
javierarams merged 20 commits into
mainfrom
feat/soundcloud-audio
Oct 27, 2026
Merged

javierarams merged 20 commits into
mainfrom
feat/soundcloud-audio

Conversation

@javierarams

@javierarams javierarams commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #9310
Refs #9368

Summary

This adds a SoundCloud provider. You can now play SoundCloud tracks and sets with <soundcloud-audio> in HTML and SoundCloudAudio in React. The new @videojs/soundcloud-audio package drives the SoundCloud Widget. The Video.js audio skin controls it like a native <audio> element.

<audio-player>
  <audio-skin>
    <soundcloud-audio src="https://soundcloud.com/forss/flickermood"></soundcloud-audio>
  </audio-skin>
</audio-player>

What it supports

  • Track and set URLs on soundcloud.com and m.soundcloud.com.
  • Private tracks and sets with their secret token.
  • Short links on on.soundcloud.com. The widget refuses them, so the media resolves them first through the SoundCloud oEmbed endpoint.
  • api.soundcloud.com tracks and playlists. The id can be a number or a URN such as soundcloud:tracks:293.
  • Widget embed URLs (w.soundcloud.com/player/?url=...). Their widget parameters are kept.
  • A start time in the URL fragment, such as #t=90, #t=1:30 or #t=1m30s.

resolveAdapterType returns soundcloud for these URLs. It returns null for profiles and other pages that list sounds.

The media reports play, pause, seeking, volume, mute, duration, time, buffered ranges, ended and errors. A set plays as one source. When the widget moves to the next track, the duration changes and the time starts again from zero. ended fires only after the last track. Clicks inside the widget show in the skin too.

Widget parameters go under source.engine.soundcloud. They are typed and documented, and color is one of them. Unknown parameters still pass through.

The widget has no playback rate, picture in picture, fullscreen or text tracks. The media leaves those members out, so the skin hides those controls.

How it works

The adapter speaks the widget postMessage protocol directly, like playerjs-video does. It does not load api.js. In api.js, widget.load() turns every parameter except start_track into true or false. That breaks color. Also, the widget never becomes ready when api.js loads after the iframe.

Each widget document reports ready with an id that holds the time it started. The adapter only accepts a document that started after its last navigation. So a quick change of source never mixes two documents. When the iframe reloads by itself, for example after you move it in the page, the media starts over like a new load.

Other fixes in this PR

  • Core: media without a playback rate still showed the playback rate menu. The menu changed nothing. This also affected Spotify. The feature now offers no rates for such media, so the skin hides the menu.
  • Skins test: one test checked every Vite workflow variant under a single 30 second limit. It timed out when the full suite ran in parallel. Now each variant has its own test.

Found but not fixed here

  • In the default and neutral skins, the audio error dialog covers the whole player with a pill shape. With a tall visible media, such as SoundCloud or Spotify with controls, it becomes a very large pill over the widget. The compat and scaffold skins use a centered card and look fine. This needs a design decision.
  • YouTube, Vimeo, TikTok, Twitch, Cloudflare, player.js and Spotify never show buffered ranges in the skin. They return the shared EMPTY_TIME_RANGES before playback, and the buffer feature only listens when the media does not return it at attach. Wistia and SoundCloud return their own empty range instead. The same check also drives live detection, so this needs its own PR.

Testing

  • Unit tests for the URL parser, resolveAdapterType, the adapter with a fake widget, the HTML element, the React component and the playback rate feature.
  • SSR checks: the HTML define module imports in Node, and the React component renders on the server and hydrates without a reload of the widget.
  • pnpm test, pnpm lint, pnpm typecheck and pnpm -F site check:api-stability pass.
  • Manual checks in Chrome with the audio skin, in HTML, React and the CDN page. I tested a track and a set: play, pause, seek, volume, mute, end, replay, loop, the next track in a set, clicks inside the widget, start time, a short link, and errors for a missing track and a profile URL.

@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
videojs-sandbox Ready Ready Preview Oct 27, 2026 6:39pm UTC

Request Review

@netlify

netlify Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs-registry ready!

Name Link
🔨 Latest commit be3fa74
🔍 Latest deploy log https://app.netlify.com/projects/vjs-registry/deploys/6ae0ef3e1a8451ca9f40165c
😎 Deploy Preview https://deploy-preview-9524--vjs-registry.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit be3fa74
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/6ae0ef3e726bbef61d012e68
😎 Deploy Preview https://deploy-preview-9524--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

Copy link
Copy Markdown
Contributor

Claude review: no high-confidence bugs found.

@pkg-pr-new

pkg-pr-new Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
@videojs/cdn

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/cdn@9524

@videojs/cli

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/cli@9524

@videojs/core

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/core@9524

@videojs/element

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/element@9524

@videojs/html

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/html@9524

@videojs/media

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/media@9524

@videojs/react

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/react@9524

@videojs/spf

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/spf@9524

@videojs/store

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/store@9524

@videojs/utils

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/utils@9524

video.js

pnpm add https://pkg.pr.new/videojs/video.js@9524

@videojs/cloudflare-video

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/cloudflare-video@9524

@videojs/dash-video

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/dash-video@9524

@videojs/hlsjs-video

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/hlsjs-video@9524

@videojs/mux-audio

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/mux-audio@9524

@videojs/mux-video

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/mux-video@9524

@videojs/native-hls-video

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/native-hls-video@9524

@videojs/playerjs-video

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/playerjs-video@9524

@videojs/shaka-video

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/shaka-video@9524

@videojs/soundcloud-audio

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/soundcloud-audio@9524

@videojs/spotify-audio

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/spotify-audio@9524

@videojs/tiktok-video

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/tiktok-video@9524

@videojs/twitch-video

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/twitch-video@9524

@videojs/vimeo-video

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/vimeo-video@9524

@videojs/wistia-video

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/wistia-video@9524

@videojs/youtube-video

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/youtube-video@9524

@videojs/google-cast

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/google-cast@9524

@videojs/mux-data

pnpm add https://pkg.pr.new/videojs/video.js/@videojs/mux-data@9524

commit: be3fa74

@javierarams javierarams changed the title feat(soundcloud-audio): add SoundCloud audio media feat(soundcloud-audio): add SoundCloud audio provider Oct 16, 2026
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

🎨 @videojs/html

Path Base initial PR initial Initial diff Lazy diff
/media/soundcloud-audio — 2.94 kB new —
Small changes (12, ≤ 300 B)
Path Base initial PR initial Initial diff Lazy diff
/background/player 5.34 kB 5.34 kB +1 B (+0.0%) 0 B
/live-video/neutral-skin 51.65 kB 51.66 kB +9 B (+0.0%) 0 B
/ui/captions-radio-group 12.16 kB 12.16 kB -2 B (-0.0%) 0 B
/ui/controls 9.51 kB 9.51 kB -2 B (-0.0%) 0 B
/ui/menu 19.71 kB 19.69 kB -11 B (-0.1%) 0 B
/ui/poster 9.63 kB 9.64 kB +9 B (+0.1%) 0 B
/ui/quality-radio-group 12.63 kB 12.63 kB -3 B (-0.0%) 0 B
/ui/time-slider-chapters 10.38 kB 10.40 kB +16 B (+0.2%) 0 B
/ui/title 8.93 kB 8.92 kB -8 B (-0.1%) 0 B
/ui/volume-slider 13.06 kB 13.07 kB +11 B (+0.1%) 0 B
/media/hls-audio 24.28 kB 24.30 kB +20 B (+0.1%) —
/media/hls-video 34.98 kB 34.91 kB -69 B (-0.2%) —
Presets (7)
Entry Initial Lazy
/video (default) 66.39 kB 56.07 kB
/video (default + hls) 68.20 kB 56.07 kB
/video (neutral) 66.75 kB 56.07 kB
/video (neutral + hls) 68.55 kB 56.07 kB
/audio (default) 50.02 kB 56.07 kB
/audio (neutral) 50.32 kB 56.07 kB
/background 13.13 kB 56.07 kB
Media (20)
Entry Initial
/media/mux-video 3.03 kB
/media/mux-audio 2.71 kB
/media/background-video 1.17 kB
/media/cloudflare-video 2.91 kB
/media/dash-video 2.63 kB
/media/hls-audio 24.30 kB
/media/hls-background-video 18.06 kB
/media/hls-video 34.91 kB
/media/hlsjs-video 2.64 kB
/media/mux-background-video 18.03 kB
/media/native-hls-video 8.93 kB
/media/playerjs-video 2.99 kB
/media/shaka-video 2.64 kB
/media/soundcloud-audio 2.94 kB
/media/spotify-audio 3.03 kB
/media/tiktok-video 3.14 kB
/media/twitch-video 2.94 kB
/media/vimeo-video 2.92 kB
/media/wistia-video 615 B
/media/youtube-video 2.91 kB
Players (5)
Entry Initial Lazy
/video/player 11.30 kB 56.07 kB
/audio/player 7.43 kB 56.07 kB
/background/player 5.34 kB 56.07 kB
/live-video/player 10.63 kB 56.07 kB
/live-audio/player 7.42 kB 56.07 kB
Skins (53)
Entry Type Initial Lazy
/video/compat-skin.css css 7.66 kB —
/video/neutral-skin.css css 8.56 kB —
/video/scaffold-skin.css css 6.71 kB —
/video/skin.css css 8.27 kB —
/video/compat-skin js 63.45 kB 56.07 kB
/video/compat-skin2 js 7.64 kB —
/video/neutral-skin js 64.45 kB 56.07 kB
/video/neutral-skin2 js 8.54 kB —
/video/scaffold-skin js 61.40 kB 56.07 kB
/video/scaffold-skin2 js 6.71 kB —
/video/skin js 64.07 kB 56.07 kB
/video/skin2 js 8.24 kB —
/audio/compat-skin.css css 6.17 kB —
/audio/neutral-skin.css css 6.09 kB —
/audio/scaffold-skin.css css 5.59 kB —
/audio/skin.css css 5.80 kB —
/audio/compat-skin js 53.67 kB 56.07 kB
/audio/compat-skin2 js 6.16 kB —
/audio/neutral-skin js 47.95 kB 56.07 kB
/audio/neutral-skin2 js 6.07 kB —
/audio/scaffold-skin js 53.06 kB 56.07 kB
/audio/scaffold-skin2 js 5.61 kB —
/audio/skin js 47.65 kB 56.07 kB
/audio/skin2 js 5.79 kB —
/background/skin.css css 141 B —
/background/skin js 10.53 kB 56.07 kB
/background/skin2 js 159 B —
/live-video/compat-skin.css css 7.11 kB —
/live-video/neutral-skin.css css 7.04 kB —
/live-video/scaffold-skin.css css 6.29 kB —
/live-video/skin.css css 6.94 kB —
/live-video/compat-skin js 54.36 kB 56.07 kB
/live-video/compat-skin2 js 7.09 kB —
/live-video/neutral-skin js 51.66 kB 56.07 kB
/live-video/neutral-skin2 js 7.03 kB —
/live-video/scaffold-skin js 52.63 kB 56.07 kB
/live-video/scaffold-skin2 js 6.29 kB —
/live-video/skin js 51.58 kB 56.07 kB
/live-video/skin2 js 6.92 kB —
/live-audio/compat-skin.css css 5.68 kB —
/live-audio/neutral-skin.css css 4.81 kB —
/live-audio/scaffold-skin.css css 5.18 kB —
/live-audio/skin.css css 4.68 kB —
/live-audio/compat-skin js 39.95 kB 56.07 kB
/live-audio/compat-skin2 js 5.66 kB —
/live-audio/neutral-skin js 36.80 kB 56.07 kB
/live-audio/neutral-skin2 js 4.81 kB —
/live-audio/scaffold-skin js 39.48 kB 56.07 kB
/live-audio/scaffold-skin2 js 5.18 kB —
/live-audio/skin js 36.59 kB 56.07 kB
/live-audio/skin2 js 4.66 kB —
/global.css css 239 B —
/shadow.css css 78 B —
UI Components (62)
Entry Initial Lazy
/ui/airplay-button 12.01 kB 56.07 kB
/ui/alert-dialog 8.99 kB 56.07 kB
/ui/audio-track-radio-group 12.10 kB 56.07 kB
/ui/buffering-indicator 9.35 kB 56.07 kB
/ui/captions-button 12.25 kB 56.07 kB
/ui/captions-radio-group 12.16 kB 56.07 kB
/ui/cast-button 11.97 kB 56.07 kB
/ui/container 10.21 kB 56.07 kB
/ui/controls 9.51 kB 56.07 kB
/ui/controls-backdrop 1.69 kB 56.07 kB
/ui/controls-content 1.67 kB 56.07 kB
/ui/dialog 8.92 kB 56.07 kB
/ui/dialog-backdrop 1.70 kB 56.07 kB
/ui/dialog-close 2.06 kB 56.07 kB
/ui/dialog-description 1.69 kB 56.07 kB
/ui/dialog-popup 1.90 kB 56.07 kB
/ui/dialog-title 1.69 kB 56.07 kB
/ui/error-dialog 13.11 kB 56.07 kB
/ui/fullscreen-button 12.00 kB 56.07 kB
/ui/gesture 10.48 kB 56.07 kB
/ui/hotkey 10.86 kB 56.07 kB
/ui/live-button 10.53 kB 56.07 kB
/ui/menu 19.69 kB 56.07 kB
/ui/menu-checkbox-item 1.97 kB 56.07 kB
/ui/menu-content 7.70 kB 56.07 kB
/ui/menu-group 2.09 kB 56.07 kB
/ui/menu-group-label 1.64 kB —
/ui/menu-item 2.29 kB 56.07 kB
/ui/menu-item-indicator 1.38 kB 56.07 kB
/ui/menu-radio-group 3.03 kB 56.07 kB
/ui/menu-radio-item 2.14 kB 56.07 kB
/ui/menu-separator 1.30 kB 56.07 kB
/ui/mute-button 12.00 kB 56.07 kB
/ui/pip-button 11.97 kB 56.07 kB
/ui/play-button 11.96 kB 56.07 kB
/ui/playback-rate-button 12.26 kB 56.07 kB
/ui/playback-rate-radio-group 12.12 kB 56.07 kB
/ui/popover 8.83 kB 56.07 kB
/ui/poster 9.64 kB 56.07 kB
/ui/quality-radio-group 12.63 kB 56.07 kB
/ui/seek-button 11.98 kB 56.07 kB
/ui/seek-indicator 13.85 kB 56.07 kB
/ui/seek-indicator-value 1.10 kB —
/ui/slider 12.37 kB 56.07 kB
/ui/slider-preview 2.01 kB 56.07 kB
/ui/status-announcer 11.39 kB 56.07 kB
/ui/status-indicator 13.78 kB 56.07 kB
/ui/status-indicator-value 1.10 kB —
/ui/thumbnail 11.08 kB 56.07 kB
/ui/time 11.78 kB 56.07 kB
/ui/time-slider 14.28 kB 56.07 kB
/ui/time-slider-chapter-title 9.53 kB 56.07 kB
/ui/time-slider-chapters 10.40 kB 56.07 kB
/ui/title 8.92 kB 56.07 kB
/ui/tooltip 10.20 kB 56.07 kB
/ui/tooltip-label 1.21 kB —
/ui/tooltip-shortcut 1.18 kB —
/ui/volume-indicator 13.74 kB 56.07 kB
/ui/volume-indicator-fill 1.11 kB —
/ui/volume-indicator-value 1.10 kB —
/ui/volume-popover 15.66 kB 56.07 kB
/ui/volume-slider 13.07 kB 56.07 kB

⚛️ @videojs/react

Path Base initial PR initial Initial diff Lazy diff
/media/soundcloud-audio — 1.96 kB new —
Small changes (21, ≤ 300 B)
Path Base initial PR initial Initial diff Lazy diff
/media/mux-video 1.59 kB 1.59 kB +1 B (+0.1%) —
/video/compat-skin 60.45 kB 60.57 kB +123 B (+0.2%) 0 B
/video/neutral-skin 59.67 kB 59.72 kB +47 B (+0.1%) 0 B
/video/scaffold-skin 59.36 kB 59.38 kB +22 B (+0.0%) 0 B
/video/skin 59.57 kB 59.62 kB +46 B (+0.1%) 0 B
/background/player 3.16 kB 3.16 kB -1 B (-0.0%) 0 B
/live-video/compat-skin 56.67 kB 56.59 kB -83 B (-0.1%) 0 B
/live-video/neutral-skin 48.98 kB 48.97 kB -8 B (-0.0%) 0 B
/live-video/scaffold-skin 55.58 kB 55.54 kB -47 B (-0.1%) 0 B
/live-video/skin 49.02 kB 49.01 kB -14 B (-0.0%) 0 B
/ui/audio-track 8.85 kB 8.85 kB -2 B (-0.0%) 0 B
/ui/captions-radio-group 11.24 kB 11.26 kB +14 B (+0.1%) 0 B
/ui/mute-button 11.73 kB 11.72 kB -10 B (-0.1%) 0 B
/ui/play-button 11.68 kB 11.68 kB -2 B (-0.0%) 0 B
/ui/poster 9.10 kB 9.10 kB +1 B (+0.0%) 0 B
/ui/quality 9.26 kB 9.27 kB +6 B (+0.1%) 0 B
/ui/seek-button 11.69 kB 11.69 kB -1 B (-0.0%) 0 B
/video (default) 59.73 kB 59.87 kB +145 B (+0.2%) 0 B
/video (default + hls) 60.31 kB 60.39 kB +83 B (+0.1%) 0 B
/video (neutral) 59.89 kB 59.84 kB -49 B (-0.1%) 0 B
/video (neutral + hls) 60.40 kB 60.44 kB +40 B (+0.1%) 0 B
Presets (7)
Entry Initial Lazy
/video (default) 59.87 kB 56.07 kB
/video (default + hls) 60.39 kB 56.07 kB
/video (neutral) 59.84 kB 56.07 kB
/video (neutral + hls) 60.44 kB 56.07 kB
/audio (default) 46.75 kB 56.07 kB
/audio (neutral) 46.67 kB 56.07 kB
/background 894 B 56.07 kB
Media (24)
Entry Initial
/media/mux-video/hls-js 1.60 kB
/media/mux-video/spf 1.63 kB
/media/mux-audio/hls-js 1.27 kB
/media/mux-audio/spf 1.29 kB
/media/background-video 624 B
/media/cloudflare-video 1.97 kB
/media/dash-video 1.25 kB
/media/hls-audio 23.17 kB
/media/hls-background-video 18.25 kB
/media/hls-video 33.85 kB
/media/hlsjs-video 1.25 kB
/media/mux-audio 1.26 kB
/media/mux-background-video 18.25 kB
/media/mux-video 1.59 kB
/media/native-hls-video 7.73 kB
/media/playerjs-video 1.91 kB
/media/shaka-video 1.26 kB
/media/soundcloud-audio 1.96 kB
/media/spotify-audio 1.99 kB
/media/tiktok-video 1.98 kB
/media/twitch-video 2.01 kB
/media/vimeo-video 1.97 kB
/media/wistia-video 1.44 kB
/media/youtube-video 1.97 kB
Extensions (2)
Entry Initial
/extensions/google-cast 613 B
/extensions/mux-data 675 B
Players (5)
Entry Initial Lazy
/video/player 9.13 kB 56.07 kB
/audio/player 5.28 kB 56.07 kB
/background/player 3.16 kB 56.07 kB
/live-video/player 8.47 kB 56.07 kB
/live-audio/player 5.26 kB 56.07 kB
Skins (34)
Entry Type Initial Lazy
/video/compat-skin.css css 7.55 kB —
/video/neutral-skin.css css 8.38 kB —
/video/scaffold-skin.css css 6.58 kB —
/video/skin.css css 8.09 kB —
/video/compat-skin js 60.57 kB 56.07 kB
/video/neutral-skin js 59.72 kB 56.07 kB
/video/scaffold-skin js 59.38 kB 56.07 kB
/video/skin js 59.62 kB 56.07 kB
/audio/compat-skin.css css 6.01 kB —
/audio/neutral-skin.css css 5.90 kB —
/audio/scaffold-skin.css css 5.44 kB —
/audio/skin.css css 5.60 kB —
/audio/compat-skin js 50.24 kB 56.07 kB
/audio/neutral-skin js 46.47 kB 56.07 kB
/audio/scaffold-skin js 50.31 kB 56.07 kB
/audio/skin js 46.51 kB 56.07 kB
/background/skin.css css 97 B —
/background/skin js 392 B —
/live-video/compat-skin.css css 7.00 kB —
/live-video/neutral-skin.css css 6.87 kB —
/live-video/scaffold-skin.css css 6.18 kB —
/live-video/skin.css css 6.76 kB —
/live-video/compat-skin js 56.59 kB 56.07 kB
/live-video/neutral-skin js 48.97 kB 56.07 kB
/live-video/scaffold-skin js 55.54 kB 56.07 kB
/live-video/skin js 49.01 kB 56.07 kB
/live-audio/compat-skin.css css 5.51 kB —
/live-audio/neutral-skin.css css 4.62 kB —
/live-audio/scaffold-skin.css css 5.00 kB —
/live-audio/skin.css css 4.48 kB —
/live-audio/compat-skin js 41.44 kB 56.07 kB
/live-audio/neutral-skin js 34.27 kB 56.07 kB
/live-audio/scaffold-skin js 41.48 kB 56.07 kB
/live-audio/skin js 34.29 kB 56.07 kB
UI Components (39)
Entry Initial Lazy
/ui/airplay-button 11.74 kB 56.07 kB
/ui/alert-dialog 5.21 kB 56.07 kB
/ui/audio-track 8.85 kB 56.07 kB
/ui/audio-track-radio-group 11.19 kB 56.07 kB
/ui/buffering-indicator 8.90 kB 56.07 kB
/ui/captions-button 11.71 kB 56.07 kB
/ui/captions-radio-group 11.26 kB 56.07 kB
/ui/cast-button 11.72 kB 56.07 kB
/ui/controls 8.78 kB 56.07 kB
/ui/dialog 5.19 kB 56.07 kB
/ui/error-dialog 13.11 kB 56.07 kB
/ui/fullscreen-button 11.69 kB 56.07 kB
/ui/gesture 9.09 kB 56.07 kB
/ui/hotkey 9.49 kB 56.07 kB
/ui/live-button 10.02 kB 56.07 kB
/ui/menu 22.51 kB 56.07 kB
/ui/mute-button 11.72 kB 56.07 kB
/ui/pip-button 11.70 kB 56.07 kB
/ui/play-button 11.68 kB 56.07 kB
/ui/playback-rate 8.91 kB 56.07 kB
/ui/playback-rate-button 11.85 kB 56.07 kB
/ui/playback-rate-radio-group 11.26 kB 56.07 kB
/ui/popover 9.17 kB 56.07 kB
/ui/poster 9.10 kB 56.07 kB
/ui/quality 9.27 kB 56.07 kB
/ui/quality-radio-group 11.60 kB 56.07 kB
/ui/seek-button 11.69 kB 56.07 kB
/ui/seek-indicator 13.57 kB 56.07 kB
/ui/slider 14.86 kB 56.07 kB
/ui/status-announcer 11.32 kB 56.07 kB
/ui/status-indicator 13.87 kB 56.07 kB
/ui/thumbnail 10.27 kB 56.07 kB
/ui/time 11.11 kB 56.07 kB
/ui/time-slider 17.16 kB 56.07 kB
/ui/title 8.36 kB 56.07 kB
/ui/tooltip 10.04 kB 56.07 kB
/ui/volume-indicator 13.88 kB 56.07 kB
/ui/volume-popover 16.04 kB 56.07 kB
/ui/volume-slider 13.49 kB 56.07 kB
🧩 @videojs/core — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
/dom 24.46 kB 24.51 kB +53 B (+0.2%) 0 B
Entries (76)
Entry Initial Lazy
. 13.52 kB —
/dom 24.51 kB 56.07 kB
/vjsc 1.90 kB —
/i18n 3.22 kB 56.07 kB
/i18n/locales/all 33.99 kB —
/i18n/locales/ar 1.16 kB —
/i18n/locales/az 1.08 kB —
/i18n/locales/bg 1.30 kB —
/i18n/locales/bn 1.25 kB —
/i18n/locales/bs 1.02 kB —
/i18n/locales/ca 1.05 kB —
/i18n/locales/cs 1.10 kB —
/i18n/locales/cy 1.02 kB —
/i18n/locales/da 984 B —
/i18n/locales/de 1.07 kB —
/i18n/locales/el 1.42 kB —
/i18n/locales/en 800 B —
/i18n/locales/es 996 B —
/i18n/locales/et 1.02 kB —
/i18n/locales/eu 1.04 kB —
/i18n/locales/fa 1.21 kB —
/i18n/locales/fi 1.05 kB —
/i18n/locales/fr 1.01 kB —
/i18n/locales/gd 1.09 kB —
/i18n/locales/gl 1017 B —
/i18n/locales/he 1.10 kB —
/i18n/locales/hi 1.25 kB —
/i18n/locales/hr 1.05 kB —
/i18n/locales/hu 1.10 kB —
/i18n/locales/id 955 B —
/i18n/locales/it 1.01 kB —
/i18n/locales/ja 1.16 kB —
/i18n/locales/ko 1.08 kB —
/i18n/locales/lt 1.04 kB —
/i18n/locales/lv 1.09 kB —
/i18n/locales/mr 1.24 kB —
/i18n/locales/nb 991 B —
/i18n/locales/ne 1.23 kB —
/i18n/locales/nl 1.00 kB —
/i18n/locales/nn 986 B —
/i18n/locales/oc 1.06 kB —
/i18n/locales/pl 1.11 kB —
/i18n/locales/pt 1.02 kB —
/i18n/locales/pt-BR 1.02 kB —
/i18n/locales/pt-PT 1.01 kB —
/i18n/locales/ro 1.04 kB —
/i18n/locales/ru 1.36 kB —
/i18n/locales/sk 1.10 kB —
/i18n/locales/sl 1.04 kB —
/i18n/locales/sr 1.05 kB —
/i18n/locales/sv 1.01 kB —
/i18n/locales/te 1.29 kB —
/i18n/locales/th 1.20 kB —
/i18n/locales/tr 1.00 kB —
/i18n/locales/uk 1.36 kB —
/i18n/locales/vi 1.10 kB —
/i18n/locales/zh 1.02 kB —
/i18n/locales/zh-CN 1.02 kB —
/i18n/locales/zh-TW 1.03 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 322 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 1.05 kB
/context 1.15 kB
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.85 kB
/html 703 B
/react 511 B
🔧 @videojs/utils — no changes
Entries (13)
Entry Initial
/array 271 B
/dom 5.32 kB
/events 320 B
/function 414 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 1018 B
/number 199 B
📦 @videojs/cdn — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
/package.json 851 B 865 B +14 B (+1.6%) —
📦 @videojs/cloudflare-video — no changes
📦 @videojs/dash-video — no changes
📦 @videojs/google-cast — no changes
📦 @videojs/hlsjs-video — no changes

📦 @videojs/media

Path Base initial PR initial Initial diff Lazy diff
. 3.32 kB 4.14 kB +837 B (+24.6%) —
Entries (3)
Entry Initial
. 4.14 kB
/dom 4.07 kB
/media-tracks 2.05 kB
📦 @videojs/mux — no changes
📦 @videojs/mux-audio — no changes
Entries (2)
Entry Initial
. 142.17 kB
/spf 23.51 kB
📦 @videojs/mux-data — no changes
📦 @videojs/mux-video — no changes
Entries (2)
Entry Initial
. 142.19 kB
/spf 34.03 kB
📦 @videojs/native-hls-video — no changes
📦 @videojs/playerjs-video — no changes
📦 @videojs/shaka-video — no changes

📦 @videojs/soundcloud-audio

Path Base initial PR initial Initial diff Lazy diff
. — 5.51 kB new —
📦 @videojs/spf — no changes
Entries (62)
Entry Initial
. 4.73 kB
/dom 7.89 kB
/hls 29.12 kB
/engines/hls-video 27.88 kB
/engines/hls-audio 20.33 kB
/engines/hls-background-video 16.17 kB
/features/airplay 4.36 kB
/features/airplay-fairplay 6.94 kB
/features/audio 13.17 kB
/features/background-video 12.88 kB
/features/calculate-duration 3.29 kB
/features/chapters 4.56 kB
/features/current-time 3.10 kB
/features/drm 9.71 kB
/features/end-stall-recovery 3.31 kB
/features/error 3.47 kB
/features/hls-loading 5.72 kB
/features/initial-load 3.80 kB
/features/live 4.96 kB
/features/media-source 4.98 kB
/features/monitor-player-size 3.58 kB
/features/multi-cdn 3.88 kB
/features/shift-text-timestamps 3.65 kB
/features/shift-timestamps 5.40 kB
/features/start-position 3.63 kB
/features/text-tracks 11.60 kB
/features/video 13.20 kB
/behaviors/calculate-presentation-duration 3.08 kB
/behaviors/collect-errors 3.55 kB
/behaviors/derive-cdn-priority 3.68 kB
/behaviors/dom/airplay 4.07 kB
/behaviors/dom/apply-start-position 3.58 kB
/behaviors/dom/end-of-stream 4.13 kB
/behaviors/dom/exchange-licenses 5.16 kB
/behaviors/dom/load-chapters 4.51 kB
/behaviors/dom/load-segments 4.13 kB
/behaviors/dom/recover-end-stall 3.29 kB
/behaviors/dom/seek-to-live-edge 3.95 kB
/behaviors/dom/setup-airplay-fairplay 6.88 kB
/behaviors/dom/setup-buffer-actors 8.09 kB
/behaviors/dom/setup-media-keys 5.94 kB
/behaviors/dom/setup-mediasource 4.02 kB
/behaviors/dom/setup-text-track-actors 5.10 kB
/behaviors/dom/sync-live-seekable-range 3.33 kB
/behaviors/dom/sync-text-tracks 3.85 kB
/behaviors/dom/track-current-time 3.06 kB
/behaviors/dom/track-load-triggers 3.55 kB
/behaviors/dom/track-playback-rate 3.02 kB
/behaviors/dom/track-player-resolution 3.51 kB
/behaviors/dom/track-screen-resolution 657 B
/behaviors/dom/update-mediasource-duration 3.90 kB
/behaviors/establish-start-media-time 4.10 kB
/behaviors/resolve-presentation 3.95 kB
/behaviors/resolve-track 7.39 kB
/behaviors/select-tracks 4.17 kB
/behaviors/setup-failover-monitor 3.56 kB
/behaviors/sync-preload 3.17 kB
/behaviors/track-switching 5.34 kB
/media-tracks 507 B
/adapters/hls-background-video 17.07 kB
/adapters/hls-audio 22.08 kB
/adapters/hls-video 32.85 kB
📦 @videojs/spotify-audio — no changes
📦 @videojs/tiktok-video — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
. 3.57 kB 3.57 kB -6 B (-0.2%) —
📦 @videojs/twitch-video — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
. 3.65 kB 3.65 kB +1 B (+0.0%) —
📦 @videojs/other — no changes
Entries (3)
Entry Initial
video.js 390 B
video.js/package.json 582 B
video.js/errors 1.04 kB
📦 @videojs/vimeo-video — no changes
📦 @videojs/wistia-video — no changes
Entries (2)
Entry Initial
. 1.91 kB
/helpers 1.76 kB
📦 @videojs/youtube-video — no changes

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

@luwes luwes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mentioned internally, a missing controls attribute on the media tag should hide the native controls in this case the Soundcloud controls.

@github-actions

Copy link
Copy Markdown
Contributor

Claude review: no high-confidence bugs found.

@javierarams javierarams changed the title feat: SoundCloud Audio provider Feature: SoundCloud Audio provider Oct 22, 2026

@luwes luwes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it's thorough and well tested. I compared the package against the other embed adapters (spotify-audio, playerjs-video, tiktok-video), and there are a few structure and scope things to sort out before merge.

Drop short-link support for now. on.soundcloud.com links are the only reason the adapter makes a network call. The redirect behind a short link has no CORS headers, so the page can't read where it points, and the PR resolves it through SoundCloud's oEmbed endpoint instead. That one optional URL format brings a lot with it:

  • an async step before the widget loads, with its own attach/load guards (adapter.ts 446-478)
  • a fetch and a module-level cache inside source.ts, which has no I/O or state in any other embed adapter
  • a new MEDIA_ERR_NETWORK error path
  • a connect-src requirement in the CSP guide

Users can paste the full soundcloud.com/... URL instead, which the widget plays directly. Let's leave short links out of this PR and add them in a follow-up if people ask for them. The inline comments list the places to change.

Rebase onto the 10.2.0 release. main has released 10.2.0 (#9489) since this branch was cut. The new package and its manifest entry are still 10.1.0, but every package is in one linked-versions release-please group.

Remove the unused src/globals.d.ts.

Otherwise the layout lines up well with the other adapters: the parser in packages/media, the HTML and React wrappers, the site demos, the sandbox templates, and the workspace wiring.

Comment thread apps/sandbox/app/shared/sources.ts Resolved
One test transformed every framework, skin, and style variant under a single
30 second limit, and timed out when the full suite ran in parallel.
Track, set, private, short link, API, and widget embed URLs resolve to the
soundcloud type. Profiles and other pages that list sounds resolve to null.
Speaks the widget postMessage protocol directly. The official api.js client
rewrites every parameter but start_track to true or false on load, so it
cannot carry color. A set plays as one source and ends after its last track.
Add <soundcloud-audio> and SoundCloudAudio, plus the CDN entry. The widget
stays visible and takes clicks with or without controls, because it carries
the uploader and SoundCloud attribution that SoundCloud's terms require.
The source picker covers the URL shapes the adapter reads differently, plus a
missing track and a profile URL that fail on purpose.
The API terms ask for credit and links back from apps that use the API. They
do not cover the widget. The widget stays visible because it is the part of
the page that credits the uploader and SoundCloud. The docs now list the
widget rules from the SoundCloud Terms of Use.
A start time such as #t=1%3A30 was ignored, because the URL hash keeps the
colon encoded. The value is now decoded before it is read, as Media
Fragments URIs ask.
With no source, or a source that failed to load, setting currentTime fired
seeking and left seeking true, because no widget ever reported the seek.
The time is now only stored, as on an audio element with no source.
When the wait for the duration ran out, the media reported the sound as
private, removed, or blocked. A sound the widget cannot play already sends
its own error, so a wait that runs out is a slow load. It now ends with
MEDIA_ERR_NETWORK.
source.engine.soundcloud.referrerPolicy reached the iframe only as a prop
of the React component. The HTML element never applied it. The media now
sets it on the iframe before each widget load, and reloads a widget
rendered without it.
A widget error after the sound loaded was kept as a fatal error. play() then
did nothing until the source changed, while the skin still showed the
widget playing the next track of a set. The error is now announced as
non-fatal and not kept, and the media asks the widget if it paused.
…Data

The player reads title and poster from contentData, but the media reported
none. The media now reports the title and a 500px artwork of the track the
widget plays. The data changes with each track of a set and clears across
a source change.
The page said the large artwork layout needs 300 pixels but did not show how
to set it. It now gives a height example for each framework.
The old privacy text said that the widget sets cookies when it loads.
A clean browser shows no cookies, but the widget writes localStorage.
The SoundCloud Privacy Policy is now the source for that text.
A media element without `controls` shows no native controls, so the
SoundCloud widget is now hidden in that case and the skin drives
playback, as with Spotify. A hidden widget still loads and plays. With
`controls`, the widget shows as before. The docs tell a page that hides
the widget to give the credit to the uploader and SoundCloud itself.
Short links were the only reason for a network call in the package. The
redirect behind a short link has no CORS headers, so the adapter used
SoundCloud's oEmbed endpoint, with a fetch, a module cache, an async
load step, a network error path, and a connect-src note in the CSP
guide. A full soundcloud.com URL plays directly, so short links now
resolve to no adapter and report an unrecognized source.
Nothing in the package reads __DEV__, as in spotify-audio, which has no such file.

@luwes luwes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@javierarams
javierarams merged commit fdeaafa into main Oct 27, 2026
51 of 52 checks passed
@javierarams
javierarams deleted the feat/soundcloud-audio branch October 27, 2026 22:43
This was referenced Oct 27, 2026
@videojs-release videojs-release Bot mentioned this pull request Oct 27, 2026

This branch was successfully deployed

1 active deployment
Preview — be3fa74f Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: <soundcloud-audio>

2 participants