Repository navigation
feat(video.js): route installs to the framework packages - #9258
Merged
Merged
Conversation
The `video.js` package no longer ships a player. It drops the `@videojs/html` dependency, the element registration, and the re-export, so the root carries only the Video.js 8 stubs, the `video.js/errors` registry, and the empty v8 stylesheet. The README routes readers to `@videojs/html`, `@videojs/react`, or `@videojs/cdn`, adds an AI quickstart through `@videojs/cli agents`, and says Video.js 8 stays maintained by Brightcove. A published AGENTS.md gives coding agents the same routing.
Every `@videojs/html` and `@videojs/react` install now carries `video.js@10`, so its routing README, published AGENTS.md, and coded v8 errors sit in the project's dependencies. Nothing imports it, so bundles are unchanged. The README and AGENTS.md explain why `video.js` appears in a v10 install, and the maintainer rules forbid importing it from `@videojs/*` or giving it dependencies of its own.
The registry suite only packed `@videojs/*` workspace packages, so the consumer apps resolved `@videojs/core`'s new `video.js` dependency from npm, which has no 10.x release. Pack every named workspace package instead.
The published guide now addresses only agents working in a project that installed video.js.
Link the canonical /docs/guides/installation/<route> pages, which includes the CDN guide that 404ed, add the Vue and Svelte guides, and show the jsDelivr script plus player markup for script-tag installs.
Video.js 10 does export createPlayer factories, so the init summary now names what was removed: setting up a player from an element or id. Importing the stubs does not throw; calling them does.
…uter-readme # Conflicts: # packages/video.js/README.md
`videojs/video.js` now hosts Video.js 10, and Video.js 8 lives in `videojs/videojs-v8`. The README and AGENTS.md sent v8 users to `videojs/video.js` and the README linked discussions in `videojs/v10`. They also promised v8 bug fixes, but SECURITY.md limits v8 to security fixes until October 1, 2028, so they say that now. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 7, 2026
✅ Deploy Preview for vjs-registry ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@videojs/cdn
@videojs/cli
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
@videojs/cloudflare-video
@videojs/dash-video
@videojs/hlsjs-video
@videojs/mux-audio
@videojs/mux-video
@videojs/native-hls-video
@videojs/shaka-video
@videojs/spotify-audio
@videojs/tiktok-video
@videojs/twitch-video
@videojs/vimeo-video
@videojs/wistia-video
@videojs/youtube-video
@videojs/google-cast
@videojs/mux-data
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Players (5)
Skins (41)
UI Components (62)
⚛️ @videojs/react — no changesPresets (7)
Media (22)
Extensions (2)
Players (5)
Skins (26)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/other
Small changes (2, ≤ 300 B)
Entries (3)
📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
luwes
approved these changes
Oct 7, 2026
Merged
This was referenced Oct 12, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved from videojs/v10#3132, where decepulis and luwes approved it.
Refs videojs/v10#3128
Warning
Merge together with #9259, before the next release.
@videojs/corenow depends onvideo.js, and the packed@videojs/corepins the exact linkedvideo.jsversion, which isn't on npm yet. #9259 makesvideo.jspublic, so the release job publishes it before@videojs/core, underlatest. Merging this PR alone would break every@videojs/htmland@videojs/reactinstall at the next release.Summary
video.jsbecomes a package that points people to the right install instead of shipping a player.@videojs/coredepends on it, so every Video.js 10 install carries its routing README, its publishedAGENTS.md, and the coded v8 errors. Video.js 8 code still fails with searchableVJS8_LEGACY_*codes.Changes
@videojs/htmldependency, the<video-player>,<video-skin>, and i18n registration, and the@videojs/htmlre-export. It now has no dependencies andsideEffects: false.@videojs/coredepends onvideo.js. Nothing imports it, so bundles don't change. It only installs. Becausevideo.jshas no dependencies, there's no cycle.videojs(),registerPlugin,getPlayer,options, …), plusvideo.js/errorsand the emptyvideo.js/dist/video-js.css. Production builds still never load the registry text.VJS8_LEGACY_INITHTML fix used to say "keepimport 'video.js'". It now says to install@videojs/htmland import its player and skin. A new registry test keeps every fix from pointing back tovideo.js.@videojs/html(with the Vue and Svelte guides),@videojs/react, or@videojs/cdn, linking the canonical/docs/guides/installation/<route>pages.@videojs/cdn@<version>/video.jsscript and the player markup.npx @videojs/cli agents skillsandagents init.npm install video.js@8, and links to the v8 repo, the v8 docs, and the migration guides.video.jsshows up in a v10 install.@videojs/*workspace packages, so its consumer apps tried to fetchvideo.jsfrom npm. It now packs every workspace package.AGENTS.md, published in the tarball. An agent that findsnode_modules/video.jsgets the same routing, the CLI commands, and how to fix aVJS8_LEGACY_*error.Decisions and follow-ups
@videojs/cli.video.jsgets nobin. In a project withvideo.js@8installed,npx video.jswould run the local v8 copy and fail. One command name across the READMEs, the generated plans, and the llms output is also simpler for agents.video.jspublic, published alongside the@videojs/*packages, and added to the pkg-pr-new preview list. The packed@videojs/corepins the exact linked version, sovideo.jsmust publish in the same release. Removingprivateis enough for CD: itspnpm -r publish --filter "./packages/**"skips private packages today, and it would then publishvideo.jswith the same dist-tag as the rest.video.js@8keeps it at the top level, and the package manager nestsvideo.js@10under@videojs/core. The two don't collide.import 'video.js'usage docs, which this PR supersedes. Its html tag-typing test checks throughvideo.js, so it needs to move into@videojs/html.next-8and is promoted tolatest-8(ci: run v8 workflows only for the 8.x branch #9244), solateststays on Video.js 10 once it publishes.Moving to videojs/video.js
main: 10.0.1 and chore(root): point repository links at videojs/video.js #9253's repository links. It merged cleanly.AGENTS.mdlink Video.js 8 atvideojs/videojs-v8instead ofvideojs/video.js, and the README's discussions link atvideojs/video.js.SECURITY.mddoes, instead of security and bug fixes.Testing
After the move:
pnpm install --frozen-lockfilepnpm -F video.js test(30 passing)pnpm -F @videojs/installation test src/tests/workspace-contract.test.ts(4 passing)pnpm typecheck,pnpm lint,pnpm check:workspace, andpnpm -F site astro check, run on the top of the stack, which includes this branchBefore the move:
pnpm -F video.js test(30 passing)pnpm -F site test legacy-errorpnpm typecheckpnpm check:workspacepnpm install --frozen-lockfilevp run --no-cache @videojs/e2e#test:registry(18 passing; installs only succeed with the localvideo.jstarball)vp run --no-cache video.js#buildand@videojs/core#build:video.jsdist imports nothing from@videojs/*.errors/registry.npm pack --dry-runincludesAGENTS.md.@videojs/coredist never importsvideo.js.🤖 Generated with Claude Code