This repository was archived by the owner on Oct 21, 2026. It is now read-only.
Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vjs-registry canceled.
|
@videojs/cdn
@videojs/cli
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
@videojs/cloudflare-video
@videojs/dash-video
@videojs/hlsjs-video
@videojs/mux-audio
@videojs/mux-video
@videojs/native-hls-video
@videojs/shaka-video
@videojs/spotify-audio
@videojs/tiktok-video
@videojs/twitch-video
@videojs/vimeo-video
@videojs/wistia-video
@videojs/youtube-video
@videojs/google-cast
@videojs/mux-data
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Players (5)
Skins (41)
UI Components (62)
⚛️ @videojs/react — no changesPresets (7)
Media (22)
Extensions (2)
Players (5)
Skins (26)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/other — no changesEntries (3)
📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
Compat sets its own colors with plain values, so it doesn't need the oklch() and color-mix() support that sets Chrome 111 and Firefox 121 for the other skins. Add a root compatBrowserslist with Chrome and Edge 99 and Firefox 103, generate Compat pages, and run them on BrowserStack at those versions. Chrome 99 is the first with @layer. Firefox 103 is the oldest build BrowserStack can drive with the current Playwright client. Safari and iOS keep one shared minimum, and the config fails if the two queries split there. Compat hides its center play button without container queries, so the checks click whichever play button is visible. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mihar-22
force-pushed
the
test/compat-browser-floor
branch
from
October 6, 2026 04:14
a367c72 to
5046b0c
Compare
Real-device iOS throws for a missing attribute where other engines return null, and Firefox's pinned server lacks the attribute matcher. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Compat skin works in older browsers than Default and Neutral: Chrome and Edge 99 instead of 111, and Firefox 103 instead of 121. Safari and iOS stay at 16.4. This adds a root
compatBrowserslistwith those minimums and runs the Compat pages on BrowserStack at them.Coverage goes from 91.5% of global usage to 93.2% (caniuse via browserslist).
Why Compat goes further back
The built CSS is the same for every skin: one Lightning CSS pass against the root
browserslist, which leavesoklch()andcolor-mix()in place. Compat's preset layer replaces every theme color the skin reads with plainblack,white,rgb(), or hex values, including--media-primary. So the newer color functions never reach a rendered Compat color. Default and Neutral depend on them, which is what sets Chrome 111.What does limit Compat:
@layer: without it the skin is unstyled@videojs/htmlCompat renders correctly in Firefox 97 in Playwright's Docker engines. The Firefox minimum is 103 because that's the oldest version we can test in CI. BrowserStack's Playwright 1.20.2 and 1.22.2 Firefox builds fail to create a context with the current client; 1.25.2 (Firefox 103) works.
:has(), which sets Firefox 121 for the other skins, only adds the keyboard-focus thumbnail preview in Compat.Between the Compat minimums and the main ones, Compat loses only small things:
@container(Chrome before 106, Firefox before 110): the narrowest layout always applies. There are no center play and seek buttons, and the time shows as a current/remaining toggle.Changes
compatBrowserslistin the rootpackage.json, next tobrowserslist. The site helpers already take a query, so the browser support page can read it in docs(site): restructure the browser support guide #3160.compat-chrome-99,compat-edge-99, andcompat-firefox-103run the Compat pages only. The existing Chrome, Edge, and Firefox projects run Default and Neutral. WebKit 16.4 and iOS run all of them, and the config throws if the two queries ever split on Safari or iOS.data-controls-visible, and the buffer probe also finds Compat's.media-time-slider-buffer.null, so the poll treats that error as no attribute.Visual Evidence
I ran the e2e pages locally in Playwright's old Linux engines (Docker). Compat rendered with its colors, controls, and menus in Chromium 99, 100, 101, 105, 111, and 115, Firefox 97, 103, 109, 113, and 121, and WebKit 16.4. Default lost its control bar surface, scrim, and icon colors in Chromium 101 and Firefox 109. Below the minimums, every skin is unstyled in Firefox 94–96, and Chromium 98 crashed on load in every skin (that build may not run on arm64).
The BrowserStack run on this PR is the check on real browsers. Its menu screenshots are in the
browserstack-resultsartifact.Testing
BROWSERSTACK_LOCAL_TEST=1 pnpm -F @videojs/e2e test:browserstack: 10 passed.tsgo --project apps/e2e/tsconfig.json --noEmitpasses.Follow-up
The docs aren't changed here. #3160, stacked on this PR, shows the Compat minimums at the top of the browser support page.
🤖 Generated with Claude Code