This repository was archived by the owner on Oct 21, 2026. It is now read-only.
Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vjs-registry ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@videojs/cdn
@videojs/cli
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
@videojs/cloudflare-video
@videojs/dash-video
@videojs/hlsjs-video
@videojs/mux-audio
@videojs/mux-video
@videojs/native-hls-video
@videojs/shaka-video
@videojs/spotify-audio
@videojs/tiktok-video
@videojs/twitch-video
@videojs/vimeo-video
@videojs/wistia-video
@videojs/youtube-video
@videojs/google-cast
@videojs/mux-data
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Players (5)
Skins (41)
UI Components (62)
⚛️ @videojs/react — 62 small size changes
Presets (7)
Media (22)
Extensions (2)
Players (5)
Skins (26)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — 1 small size change
Entries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/other — no changesEntries (3)
📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
The bundled declarations for the player and skin define entries were
`export {}`, so `import '@videojs/html/video/player'` (and
`import 'video.js'`) left `querySelector('video-player')` typed as
`Element`. Move each `HTMLElementTagNameMap` augmentation beside its
`safeDefine`, as define/ui and define/media already do.
`react-compiler-runtime` requires `react` as a peer, so npm installed React into every `@videojs/html` app through `@videojs/store`. Drop the compiler from store's three hooks and memoize them by hand. `useStore` now keys its callbacks on whether a selector exists, so an inline selector no longer resubscribes every render.
mihar-22
force-pushed
the
t3code/verify-videojs-vite-setup
branch
from
October 1, 2026 21:12
a24530f to
0da80c4
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I tested the
video.jspackage the way a user would: a stockcreate-vitevanilla-ts app installing packed tarballs ofvideo.jsand its@videojs/*dependencies. The player renders and plays, the player API works, and every Video.js 8 entry point throws its coded error in both dev and prod builds.Two packaging bugs showed up, and both reach
@videojs/htmlusers too. This PR fixes them. Thevideo.jsdocs and the type test that guards the first fix are stacked on top in #3128.Changes
import '@videojs/html/video/player', any other player or skin define entry, andimport 'video.js'now typedocument.querySelector('video-player')asVideoPlayerElement. Before this, the bundled declarations for those entries wereexport {}, so TypeScript users gotElementand.storewas a type error. TheHTMLElementTagNameMapaugmentations for the 18 player and skin elements (including the new Compat skins) move frompresets/to thedefine/files that register them. That matchesdefine/uianddefine/media, where the augmentation already sits besidesafeDefine.@videojs/storedepended onreact-compiler-runtime, which requiresreactas a peer, so npm installed React into every HTML project. Store's three React hooks are now memoized by hand and the dependency is gone.@videojs/reactstill uses the compiler. As a side effect,useStore(store, inlineSelector)no longer resubscribes on every render.Not changed
@videojs/html/video) and registers the elements itself no longer gets the tag map, because the presets don't register anything. Nothing in the repo does this.useSnapshotstill resubscribes on every render. Memoizing it the same way breaks dialog and menu transition tests in@videojs/react(5 tests). Those flows depend on the snapshot re-check that resubscribing triggers, which points to aStatechange that never notifies subscribers. That's a follow-up; the hook now says why it stays unmemoized.@videojs/html's root declarations still exportindex_d_exports, a namespace the declaration bundler creates for types reached throughexport * from '@videojs/core/dom'. 20 emitted files reference it, so removing it means annotating inferred types across those elements. It's cosmetic (it shows in autocomplete), so I left it for a follow-up.define/*/ui.tsandneutral-ui.ts(the ejected layouts) still emitexport {}, so their UI tags aren't typed through those entries. The individualdefine/ui/*entries are typed.pnpm packin@videojs/htmlneeds a site build for its bundled docs; the test project used--ignore-scripts.Testing
pnpm -F @videojs/store test(106): a new regression test fails on the old hook with 3 subscriptions and passes with 1.pnpm build:packages, everydist/dev/define/*/{player,skin,neutral-skin,compat-skin}.d.tscarries its augmentation. The type test in docs(video.js): add usage, an ai quickstart, and an agent guide #3128 checks this through the built declarations.html(449),react(570),skins(82),cdn(16), pluspnpm typecheck,pnpm check:workspace, and lint.tscpasses with no casts, noreactinnode_modules, and the player plays and responds to play, seek, mute, rate, and pause.🤖 Generated with Claude Code