Skip to content
This repository was archived by the owner on Oct 21, 2026. It is now read-only.

ci(spf): enforce coverage thresholds - #2830

Closed
mihar-22 wants to merge 4 commits into
ci/test-ownership-stackfrom
ci/spf-coverage-gate
Closed

mihar-22 wants to merge 4 commits into
ci/test-ownership-stackfrom
ci/spf-coverage-gate

Conversation

@mihar-22

@mihar-22 mihar-22 commented Sep 15, 2026 •

Copy link
Copy Markdown
Member

Depends on #2822 (and #2817 transitively).

Summary

Make SPF’s existing 80% coverage policy enforceable in CI without adding coverage overhead to the fast local test path.

Changes

  • Add an explicit Vite+ coverage task that retains the complete runtime, browser, and type-test project set
  • Run that task in the dedicated SPF CI job, replacing the non-coverage invocation so the suite is not duplicated
  • Exclude type-test fixtures and support modules under src/**/tests/** from production coverage accounting
Scope note

Site coverage remains out of this layer. Its current include boundary mixes unit-testable logic with largely unexecuted Astro and UI files; that boundary and a meaningful threshold need a separate deliberate change rather than an arbitrary low baseline.

Testing

  • pnpm exec vp run @videojs/spf#test:coverage
    • 97 test files passed, 1 skipped
    • 1,594 tests passed, 11 skipped
    • 0 type errors
    • 94.11% statements, 88.16% branches, 95.79% functions, 96.39% lines
    • LCOV contains no src/**/tests/** support paths
  • pnpm test:size (16 tests)
  • pnpm check:workspace

@vercel

vercel Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v10-sandbox Ready Ready Preview Sep 16, 2026 4:17am UTC

Request Review

@pkg-pr-new

pkg-pr-new Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
@videojs/cdn

pnpm add https://pkg.pr.new/@videojs/cdn@2830

@videojs/core

pnpm add https://pkg.pr.new/@videojs/core@2830

@videojs/element

pnpm add https://pkg.pr.new/@videojs/element@2830

@videojs/html

pnpm add https://pkg.pr.new/@videojs/html@2830

@videojs/media

pnpm add https://pkg.pr.new/@videojs/media@2830

@videojs/react

pnpm add https://pkg.pr.new/@videojs/react@2830

@videojs/spf

pnpm add https://pkg.pr.new/@videojs/spf@2830

@videojs/store

pnpm add https://pkg.pr.new/@videojs/store@2830

@videojs/utils

pnpm add https://pkg.pr.new/@videojs/utils@2830

@videojs/cloudflare-video

pnpm add https://pkg.pr.new/@videojs/cloudflare-video@2830

@videojs/dash-video

pnpm add https://pkg.pr.new/@videojs/dash-video@2830

@videojs/hlsjs-video

pnpm add https://pkg.pr.new/@videojs/hlsjs-video@2830

@videojs/mux-audio

pnpm add https://pkg.pr.new/@videojs/mux-audio@2830

@videojs/mux-video

pnpm add https://pkg.pr.new/@videojs/mux-video@2830

@videojs/native-hls-video

pnpm add https://pkg.pr.new/@videojs/native-hls-video@2830

@videojs/shaka-video

pnpm add https://pkg.pr.new/@videojs/shaka-video@2830

@videojs/spotify-audio

pnpm add https://pkg.pr.new/@videojs/spotify-audio@2830

@videojs/tiktok-video

pnpm add https://pkg.pr.new/@videojs/tiktok-video@2830

@videojs/twitch-video

pnpm add https://pkg.pr.new/@videojs/twitch-video@2830

@videojs/vimeo-video

pnpm add https://pkg.pr.new/@videojs/vimeo-video@2830

@videojs/wistia-video

pnpm add https://pkg.pr.new/@videojs/wistia-video@2830

@videojs/youtube-video

pnpm add https://pkg.pr.new/@videojs/youtube-video@2830

@videojs/google-cast

pnpm add https://pkg.pr.new/@videojs/google-cast@2830

@videojs/mux-data

pnpm add https://pkg.pr.new/@videojs/mux-data@2830

commit: dc42f15

@mihar-22
mihar-22 changed the base branch from fix/spf-test-gate to ci/test-ownership-stack September 16, 2026 00:05
@github-actions

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

🎨 @videojs/html — no changes
Presets (7)
Entry Initial Lazy
/video (default) 64.05 kB 58.19 kB
/video (default + hls) 65.81 kB 58.19 kB
/video (minimal) 64.57 kB 58.19 kB
/video (minimal + hls) 66.25 kB 58.19 kB
/audio (default) 47.74 kB 58.19 kB
/audio (minimal) 48.00 kB 58.19 kB
/background 11.79 kB 58.19 kB
Media (18)
Entry Initial
/media/mux-video 3.01 kB
/media/mux-audio 2.69 kB
/media/background-video 1.16 kB
/media/cloudflare-video 2.90 kB
/media/dash-video 2.63 kB
/media/hls-audio 22.88 kB
/media/hls-background-video 17.04 kB
/media/hls-video 28.80 kB
/media/hlsjs-video 2.63 kB
/media/mux-background-video 17.00 kB
/media/native-hls-video 7.59 kB
/media/shaka-video 2.63 kB
/media/spotify-audio 3.02 kB
/media/tiktok-video 3.13 kB
/media/twitch-video 2.93 kB
/media/vimeo-video 2.90 kB
/media/wistia-video 607 B
/media/youtube-video 2.90 kB
Players (5)
Entry Initial Lazy
/video/player 9.86 kB 58.19 kB
/audio/player 6.21 kB 58.19 kB
/background/player 4.46 kB 58.19 kB
/live-video/player 9.24 kB 58.19 kB
/live-audio/player 6.22 kB 58.19 kB
Skins (29)
Entry Type Initial Lazy
/video/minimal-skin.css css 8.04 kB —
/video/skin.css css 7.71 kB —
/video/minimal-skin js 63.02 kB 58.19 kB
/video/minimal-skin2 js 8.64 kB —
/video/skin js 62.61 kB 58.19 kB
/video/skin2 js 8.38 kB —
/audio/minimal-skin.css css 5.82 kB —
/audio/skin.css css 5.53 kB —
/audio/minimal-skin js 46.58 kB 58.19 kB
/audio/minimal-skin2 js 6.20 kB —
/audio/skin js 46.28 kB 58.19 kB
/audio/skin2 js 5.93 kB —
/background/skin.css css 139 B —
/background/skin js 10.05 kB 58.19 kB
/background/skin2 js 187 B —
/live-video/minimal-skin.css css 6.45 kB —
/live-video/skin.css css 6.29 kB —
/live-video/minimal-skin js 50.24 kB 58.19 kB
/live-video/minimal-skin2 js 6.88 kB —
/live-video/skin js 50.13 kB 58.19 kB
/live-video/skin2 js 6.78 kB —
/live-audio/minimal-skin.css css 4.59 kB —
/live-audio/skin.css css 4.48 kB —
/live-audio/minimal-skin js 35.98 kB 58.19 kB
/live-audio/minimal-skin2 js 4.89 kB —
/live-audio/skin js 35.92 kB 58.19 kB
/live-audio/skin2 js 4.78 kB —
/global.css css 190 B —
/shared.css css 134 B —
UI Components (62)
Entry Initial Lazy
/ui/airplay-button 11.42 kB 58.19 kB
/ui/alert-dialog 8.79 kB 58.19 kB
/ui/audio-track-radio-group 11.52 kB 58.19 kB
/ui/buffering-indicator 8.75 kB 58.19 kB
/ui/captions-button 11.67 kB 58.19 kB
/ui/captions-radio-group 11.60 kB 58.19 kB
/ui/cast-button 11.39 kB 58.19 kB
/ui/container 9.62 kB 58.19 kB
/ui/controls 8.93 kB 58.19 kB
/ui/controls-backdrop 1.69 kB 58.19 kB
/ui/controls-content 1.67 kB 58.19 kB
/ui/dialog 8.73 kB 58.19 kB
/ui/dialog-backdrop 1.70 kB 58.19 kB
/ui/dialog-close 2.06 kB 58.19 kB
/ui/dialog-description 1.69 kB 58.19 kB
/ui/dialog-popup 1.90 kB 58.19 kB
/ui/dialog-title 1.70 kB 58.19 kB
/ui/error-dialog 12.54 kB 58.19 kB
/ui/fullscreen-button 11.40 kB 58.19 kB
/ui/gesture 9.72 kB 58.19 kB
/ui/hotkey 10.19 kB 58.19 kB
/ui/live-button 9.95 kB 58.19 kB
/ui/menu 18.60 kB 58.19 kB
/ui/menu-checkbox-item 1.97 kB 58.19 kB
/ui/menu-content 7.53 kB 58.19 kB
/ui/menu-group 2.09 kB 58.19 kB
/ui/menu-group-label 1.64 kB —
/ui/menu-item 2.30 kB 58.19 kB
/ui/menu-item-indicator 1.38 kB 58.19 kB
/ui/menu-radio-group 3.01 kB 58.19 kB
/ui/menu-radio-item 2.13 kB 58.19 kB
/ui/menu-separator 1.30 kB 58.19 kB
/ui/mute-button 11.42 kB 58.19 kB
/ui/pip-button 11.37 kB 58.19 kB
/ui/play-button 11.38 kB 58.19 kB
/ui/playback-rate-button 11.47 kB 58.19 kB
/ui/playback-rate-radio-group 11.53 kB 58.19 kB
/ui/popover 8.58 kB 58.19 kB
/ui/poster 9.05 kB 58.19 kB
/ui/quality-radio-group 12.12 kB 58.19 kB
/ui/seek-button 11.41 kB 58.19 kB
/ui/seek-indicator 12.83 kB 58.19 kB
/ui/seek-indicator-value 1.10 kB —
/ui/slider 11.81 kB 58.19 kB
/ui/slider-preview 2.01 kB 58.19 kB
/ui/status-announcer 10.75 kB 58.19 kB
/ui/status-indicator 13.16 kB 58.19 kB
/ui/status-indicator-value 1.10 kB —
/ui/thumbnail 10.48 kB 58.19 kB
/ui/time 11.18 kB 58.19 kB
/ui/time-slider 13.28 kB 58.19 kB
/ui/time-slider-chapter-title 8.94 kB 58.19 kB
/ui/time-slider-chapters 9.79 kB 58.19 kB
/ui/title 8.33 kB 58.19 kB
/ui/tooltip 9.97 kB 58.19 kB
/ui/tooltip-label 1.21 kB —
/ui/tooltip-shortcut 1.18 kB —
/ui/volume-indicator 13.16 kB 58.19 kB
/ui/volume-indicator-fill 1.11 kB —
/ui/volume-indicator-value 1.10 kB —
/ui/volume-popover 14.89 kB 58.19 kB
/ui/volume-slider 12.52 kB 58.19 kB
⚛️ @videojs/react — no changes
Presets (7)
Entry Initial Lazy
/video (default) 57.98 kB 58.19 kB
/video (default + hls) 58.39 kB 58.19 kB
/video (minimal) 58.04 kB 58.19 kB
/video (minimal + hls) 58.55 kB 58.19 kB
/audio (default) 44.79 kB 58.19 kB
/audio (minimal) 44.85 kB 58.19 kB
/background 908 B 58.19 kB
Media (22)
Entry Initial
/media/mux-video/hls-js 1.45 kB
/media/mux-video/spf 1.46 kB
/media/mux-audio/hls-js 1.12 kB
/media/mux-audio/spf 1.13 kB
/media/background-video 513 B
/media/cloudflare-video 1.81 kB
/media/dash-video 1.11 kB
/media/hls-audio 21.59 kB
/media/hls-background-video 17.09 kB
/media/hls-video 27.54 kB
/media/hlsjs-video 1.12 kB
/media/mux-audio 1.12 kB
/media/mux-background-video 17.04 kB
/media/mux-video 1.44 kB
/media/native-hls-video 6.21 kB
/media/shaka-video 1.11 kB
/media/spotify-audio 1.89 kB
/media/tiktok-video 1.81 kB
/media/twitch-video 1.84 kB
/media/vimeo-video 1.79 kB
/media/wistia-video 1.41 kB
/media/youtube-video 1.79 kB
Extensions (2)
Entry Initial
/extensions/google-cast 1.77 kB
/extensions/mux-data 1.80 kB
Players (5)
Entry Initial Lazy
/video/player 8.13 kB 58.19 kB
/audio/player 4.43 kB 58.19 kB
/background/player 2.64 kB 58.19 kB
/live-video/player 7.51 kB 58.19 kB
/live-audio/player 4.45 kB 58.19 kB
Skins (18)
Entry Type Initial Lazy
/video/minimal-skin.css css 7.86 kB —
/video/skin.css css 7.56 kB —
/video/minimal-skin js 57.89 kB 58.19 kB
/video/skin js 57.95 kB 58.19 kB
/audio/minimal-skin.css css 5.62 kB —
/audio/skin.css css 5.34 kB —
/audio/minimal-skin js 44.72 kB 58.19 kB
/audio/skin js 44.70 kB 58.19 kB
/background/skin.css css 90 B —
/background/skin js 518 B —
/live-video/minimal-skin.css css 6.28 kB —
/live-video/skin.css css 6.13 kB —
/live-video/minimal-skin js 47.58 kB 58.19 kB
/live-video/skin js 47.72 kB 58.19 kB
/live-audio/minimal-skin.css css 4.40 kB —
/live-audio/skin.css css 4.28 kB —
/live-audio/minimal-skin js 33.23 kB 58.19 kB
/live-audio/skin js 33.29 kB 58.19 kB
UI Components (39)
Entry Initial Lazy
/ui/airplay-button 10.94 kB 58.19 kB
/ui/alert-dialog 4.97 kB 58.19 kB
/ui/audio-track 8.28 kB 58.19 kB
/ui/audio-track-radio-group 10.49 kB 58.19 kB
/ui/buffering-indicator 8.10 kB 58.19 kB
/ui/captions-button 10.90 kB 58.19 kB
/ui/captions-radio-group 10.59 kB 58.19 kB
/ui/cast-button 10.92 kB 58.19 kB
/ui/controls 7.98 kB 58.19 kB
/ui/dialog 4.96 kB 58.19 kB
/ui/error-dialog 12.33 kB 58.19 kB
/ui/fullscreen-button 10.87 kB 58.19 kB
/ui/gesture 8.35 kB 58.19 kB
/ui/hotkey 8.83 kB 58.19 kB
/ui/live-button 9.24 kB 58.19 kB
/ui/menu 21.22 kB 58.19 kB
/ui/mute-button 10.91 kB 58.19 kB
/ui/pip-button 10.88 kB 58.19 kB
/ui/play-button 10.85 kB 58.19 kB
/ui/playback-rate 8.31 kB 58.19 kB
/ui/playback-rate-button 10.86 kB 58.19 kB
/ui/playback-rate-radio-group 10.52 kB 58.19 kB
/ui/popover 8.71 kB 58.19 kB
/ui/poster 8.30 kB 58.19 kB
/ui/quality 8.76 kB 58.19 kB
/ui/quality-radio-group 10.97 kB 58.19 kB
/ui/seek-button 10.89 kB 58.19 kB
/ui/seek-indicator 12.62 kB 58.19 kB
/ui/slider 14.12 kB 58.19 kB
/ui/status-announcer 10.48 kB 58.19 kB
/ui/status-indicator 13.05 kB 58.19 kB
/ui/thumbnail 9.46 kB 58.19 kB
/ui/time 10.28 kB 58.19 kB
/ui/time-slider 15.84 kB 58.19 kB
/ui/title 7.55 kB 58.19 kB
/ui/tooltip 9.56 kB 58.19 kB
/ui/volume-indicator 13.10 kB 58.19 kB
/ui/volume-popover 15.08 kB 58.19 kB
/ui/volume-slider 12.70 kB 58.19 kB
🧩 @videojs/core — no changes
Entries (76)
Entry Initial Lazy
. 13.43 kB —
/dom 22.89 kB 58.19 kB
/vjsc 1.87 kB —
/i18n 3.23 kB 58.19 kB
/i18n/locales/all 35.98 kB —
/i18n/locales/ar 1.24 kB —
/i18n/locales/az 1.12 kB —
/i18n/locales/bg 1.32 kB —
/i18n/locales/bn 1.25 kB —
/i18n/locales/bs 1.03 kB —
/i18n/locales/ca 1.10 kB —
/i18n/locales/cs 1.11 kB —
/i18n/locales/cy 1.05 kB —
/i18n/locales/da 1.01 kB —
/i18n/locales/de 1.11 kB —
/i18n/locales/el 1.53 kB —
/i18n/locales/en 801 B —
/i18n/locales/es 1.02 kB —
/i18n/locales/et 1.07 kB —
/i18n/locales/eu 1.04 kB —
/i18n/locales/fa 1.25 kB —
/i18n/locales/fi 1.07 kB —
/i18n/locales/fr 1.09 kB —
/i18n/locales/gd 1.13 kB —
/i18n/locales/gl 1.02 kB —
/i18n/locales/he 1.16 kB —
/i18n/locales/hi 1.33 kB —
/i18n/locales/hr 1.05 kB —
/i18n/locales/hu 1.11 kB —
/i18n/locales/id 941 B —
/i18n/locales/it 1.04 kB —
/i18n/locales/ja 1.22 kB —
/i18n/locales/ko 1.18 kB —
/i18n/locales/lt 1.04 kB —
/i18n/locales/lv 1.11 kB —
/i18n/locales/mr 1.32 kB —
/i18n/locales/nb 1015 B —
/i18n/locales/ne 1.32 kB —
/i18n/locales/nl 1.02 kB —
/i18n/locales/nn 1015 B —
/i18n/locales/oc 1.10 kB —
/i18n/locales/pl 1.17 kB —
/i18n/locales/pt 1.05 kB —
/i18n/locales/pt-BR 1.05 kB —
/i18n/locales/pt-PT 1.04 kB —
/i18n/locales/ro 1.10 kB —
/i18n/locales/ru 1.42 kB —
/i18n/locales/sk 1.13 kB —
/i18n/locales/sl 1.07 kB —
/i18n/locales/sr 1.13 kB —
/i18n/locales/sv 1.03 kB —
/i18n/locales/te 1.34 kB —
/i18n/locales/th 1.31 kB —
/i18n/locales/tr 1.09 kB —
/i18n/locales/uk 1.44 kB —
/i18n/locales/vi 1.13 kB —
/i18n/locales/zh 1.04 kB —
/i18n/locales/zh-CN 1.04 kB —
/i18n/locales/zh-TW 1.04 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 322 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 1.05 kB
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.72 kB
/html 703 B
/react 512 B
🔧 @videojs/utils — no changes
Entries (13)
Entry Initial
/array 271 B
/dom 5.11 kB
/events 320 B
/function 386 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 976 B
/number 199 B
📦 @videojs/cdn — no changes
📦 @videojs/cloudflare-video — no changes
📦 @videojs/dash-video — no changes
📦 @videojs/google-cast — no changes
📦 @videojs/hlsjs-video — no changes
📦 @videojs/media — no changes
Entries (3)
Entry Initial
. 1.29 kB
/dom 4.12 kB
/media-tracks 2.05 kB
📦 @videojs/mux — no changes
📦 @videojs/mux-audio — no changes
Entries (2)
Entry Initial
. 135.97 kB
/spf 22.00 kB
📦 @videojs/mux-data — no changes
📦 @videojs/mux-video — no changes
Entries (2)
Entry Initial
. 135.94 kB
/spf 27.85 kB
📦 @videojs/native-hls-video — no changes
📦 @videojs/shaka-video — no changes
📦 @videojs/spf — no changes
Entries (7)
Entry Initial
. 4.55 kB
/dom 7.55 kB
/hls 22.97 kB
/media-tracks 504 B
/hls-background-video 16.02 kB
/hls-audio 20.71 kB
/hls-video 26.64 kB
📦 @videojs/spotify-audio — no changes
📦 @videojs/tiktok-video — no changes
📦 @videojs/twitch-video — no changes
📦 @videojs/vimeo-video — no changes
📦 @videojs/wistia-video — no changes
Entries (2)
Entry Initial
. 1.91 kB
/helpers 1.77 kB
📦 @videojs/youtube-video — no changes

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

This branch was successfully deployed

1 active deployment
Preview — dc42f155 Deployed Sep 16, 2026 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants