Skip to content
This repository was archived by the owner on Oct 21, 2026. It is now read-only.

feat(sandbox): port the player.style instaplay theme to v10 elements - #2714

Closed
cjpillsbury wants to merge 23 commits into
mainfrom
feat/sandbox-player-style-instaplay
Closed

cjpillsbury wants to merge 23 commits into
mainfrom
feat/sandbox-player-style-instaplay

Conversation

@cjpillsbury

@cjpillsbury cjpillsbury commented Sep 10, 2026 •

Copy link
Copy Markdown
Collaborator

Draft — exploratory, not proposing a merge yet. Opened so the diff is easy to audit.

What this is

A sandbox page at /player-style-instaplay/ that renders player.style's instaplay theme rebuilt on Video.js 10 elements, side by side with the published media-chrome original. It's the first probe in an audit of what porting the whole player.style catalogue (14 themes) would cost.

The page

Three modes on one route:

URL What it renders
/player-style-instaplay/ the comparison: both panels, layout toggle, mirror checkbox
?panel=videojs the port alone — what the left frame loads
?panel=media-chrome the original alone — what the right frame loads

The comparison follows the shell's Compare: one axis differs, everything else is shared, each panel is its own frame, and Mirror playback carries play/pause, seeks, volume, mute and caption selection between them. Layout and mirror travel in the URL, so a link reproduces the view.

The axis here — the port itself — can't live in the shell's Compare, whose axes all differ on a shell-owned selection (styling, skins, skin, platform).

Two frames is a requirement, not a preference: media-chrome and @videojs/html register eleven of the same custom element names (media-play-button, media-mute-button, media-container, media-fullscreen-button, media-pip-button, media-airplay-button, media-cast-button, media-captions-button, media-live-button, media-playback-rate-button, media-tooltip). Both sides guard registration and silently no-op, so whichever loads first wins and the other's controls render as inert boxes. Each stack therefore gets its own module and its own document.

installSandboxMirror needed no changes — it moves state through the media element, so it mirrors across two different player stacks as-is.

How the port is built

theme.html + theme.css, stamped into an element by the sandbox's existing defineTemplateSkin — the same path an ejected registry skin takes, on the public ContainerElement. No packaged-skin API is involved, so nothing here depends on how third-party skins eventually get distributed. That question is open and this PR deliberately avoids it.

The reference panel loads @player.style/instaplay@0.1.2 from a pinned jsDelivr +esm bundle rather than a dependency, so the StackBlitz upload doesn't have to resolve it. The bundle carries its own pinned media-chrome and never reaches the workspace copy.

Translation notes

media-chrome Video.js 10
named icon slots (slot="play", slot="off", …) children toggled by CSS on state data attributes
media-time-range media-time-slider + explicit track / buffer / fill
media-preview-time-display media-slider-value type="pointer" in media-slider-preview
media-preview-thumbnail media-slider-thumbnail
media-controller video-player + media-container

Four things worth a look, because they'll repeat across every other theme:

  1. No media-controls. instaplay marks its bar and range noautohide, so they sit in a plain always-visible wrapper. ControlsElement only consumes playerContext, so nothing breaks — but ported themes opt out of autohide entirely rather than configuring it.
  2. The skin brings its own box (width: 100%; aspect-ratio: 16/9). The packaged container's w-full h-full lives in a stylesheet this page doesn't load; without it the player is 0×0. The reference panel needs w-full for the same reason — aspect-video and max-w-* never set a width, and a theme whose media hasn't loaded has nothing to size itself from.
  3. Three glyphs for four states. data-volume-level reports off|low|medium|high; the icon set ships off/low/high, so medium borrows the high glyph.
  4. The mute icon visibly differs. instaplay supplies no custom mute icons, so the original inherits media-chrome's default glyph and the port inherits v10's. Side by side, one is a speaker with an ×, the other a speaker with a slash. Faithful ports of themes that lean on media-chrome's built-in icons will need those icons supplied explicitly.

Also included

declare module '*.html?raw' in the sandbox ambient types. There wasn't one, so the existing registry-skin ?raw imports were untyped too.

Verified

Both panels render side by side and read as equivalent. Port renders at 896×504 inside <video-player>; poster, centred play button and mute control correct; data-paused shows/hides the play button; the poster hides on play; data-volume-level swaps the mute glyph; the time slider sits flush at the bottom edge with v10 writing --media-slider-fill and --media-slider-buffer. Mirror confirmed end to end — muting and setting volume in the port propagated to the original through the relay. Clean console in all three modes. Typecheck adds no errors.

Not verified: playback. Media doesn't load in my browser — readyState: 0, duration: NaN, no video request while poster and storyboard fetch fine. The stock html-video template shows the identical state with the same source, so it's environmental rather than something this branch introduced. That leaves the fill bar advancing with time, and time-based mirroring, unconfirmed.

Not in scope

Distribution model, the React output, the other 13 themes, and any change to the shell's skin picker (extending SKINS in app/constants.ts ripples into the satisfies Record<\${SkinPreset}/${Skin}`, …>` maps and won't compile without package and registry entries).

🤖 Generated with Claude Code

Adds a sandbox page that renders player.style's instaplay theme on Video.js 10
elements, as a first probe of what porting the player.style catalogue costs.

The theme ships as markup plus a stylesheet and is stamped into an element by
the sandbox's existing `defineTemplateSkin`, the same path an ejected registry
skin takes. No packaged-skin API is involved, so nothing here depends on how
third-party skins eventually get distributed.

Translation notes:

- Named icon slots become children toggled by CSS on the state data attributes.
  `data-volume-level` reports off/low/medium/high and the icon set ships three
  glyphs, so medium borrows the high one.
- `media-time-range` becomes `media-time-slider` with explicit track, buffer and
  fill children, driven by `--media-slider-fill` and `--media-slider-buffer`.
- The theme marks its bar and range `noautohide`, so they sit outside
  `media-controls` rather than configuring autohide.
- The skin brings its own box, since the packaged container's sizing lives in a
  stylesheet this page does not load.

Also declares `*.html?raw` in the sandbox ambient types, which the existing
registry-skin imports were already relying on without one.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v10-sandbox Ready Ready Preview Sep 11, 2026 11:18pm UTC

Request Review

@netlify

netlify Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit debbdc2
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/6aa48bf8c973a900087fbbd1
😎 Deploy Preview https://deploy-preview-2714--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs-registry canceled.

Name Link
🔨 Latest commit debbdc2
🔍 Latest deploy log https://app.netlify.com/projects/vjs-registry/deploys/6aa48bf8631d2b00087dbde4

@pkg-pr-new

pkg-pr-new Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
@videojs/cdn

pnpm add https://pkg.pr.new/@videojs/cdn@2714

@videojs/core

pnpm add https://pkg.pr.new/@videojs/core@2714

@videojs/element

pnpm add https://pkg.pr.new/@videojs/element@2714

@videojs/html

pnpm add https://pkg.pr.new/@videojs/html@2714

@videojs/media

pnpm add https://pkg.pr.new/@videojs/media@2714

@videojs/react

pnpm add https://pkg.pr.new/@videojs/react@2714

@videojs/spf

pnpm add https://pkg.pr.new/@videojs/spf@2714

@videojs/store

pnpm add https://pkg.pr.new/@videojs/store@2714

@videojs/utils

pnpm add https://pkg.pr.new/@videojs/utils@2714

@videojs/cloudflare-video

pnpm add https://pkg.pr.new/@videojs/cloudflare-video@2714

@videojs/dash-video

pnpm add https://pkg.pr.new/@videojs/dash-video@2714

@videojs/hlsjs-video

pnpm add https://pkg.pr.new/@videojs/hlsjs-video@2714

@videojs/mux-audio

pnpm add https://pkg.pr.new/@videojs/mux-audio@2714

@videojs/mux-video

pnpm add https://pkg.pr.new/@videojs/mux-video@2714

@videojs/native-hls-video

pnpm add https://pkg.pr.new/@videojs/native-hls-video@2714

@videojs/shaka-video

pnpm add https://pkg.pr.new/@videojs/shaka-video@2714

@videojs/spotify-audio

pnpm add https://pkg.pr.new/@videojs/spotify-audio@2714

@videojs/tiktok-video

pnpm add https://pkg.pr.new/@videojs/tiktok-video@2714

@videojs/twitch-video

pnpm add https://pkg.pr.new/@videojs/twitch-video@2714

@videojs/vimeo-video

pnpm add https://pkg.pr.new/@videojs/vimeo-video@2714

@videojs/wistia-video

pnpm add https://pkg.pr.new/@videojs/wistia-video@2714

@videojs/youtube-video

pnpm add https://pkg.pr.new/@videojs/youtube-video@2714

@videojs/google-cast

pnpm add https://pkg.pr.new/@videojs/google-cast@2714

@videojs/mux-data

pnpm add https://pkg.pr.new/@videojs/mux-data@2714

commit: debbdc2

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

🎨 @videojs/html — 34 small size changes
Path Base initial PR initial Initial diff Lazy diff
/video/minimal-skin.css 8.03 kB 8.07 kB +39 B (+0.5%) —
/video/skin.css 7.85 kB 7.87 kB +25 B (+0.3%) —
/video/minimal-skin 62.76 kB 62.95 kB +194 B (+0.3%) 0 B
/video/minimal-skin2 8.59 kB 8.63 kB +48 B (+0.5%) —
/video/skin 62.56 kB 62.71 kB +152 B (+0.2%) 0 B
/video/skin2 8.46 kB 8.52 kB +61 B (+0.7%) —
/audio/minimal-skin.css 5.78 kB 5.78 kB -5 B (-0.1%) —
/audio/skin.css 5.64 kB 5.62 kB -20 B (-0.3%) —
/audio/minimal-skin 46.39 kB 46.41 kB +18 B (+0.0%) 0 B
/audio/minimal-skin2 6.17 kB 6.16 kB -6 B (-0.1%) —
/audio/skin 46.23 kB 46.26 kB +27 B (+0.1%) 0 B
/audio/skin2 6.01 kB 6.01 kB -3 B (-0.0%) —
/live-video/minimal-skin.css 6.47 kB 6.46 kB -18 B (-0.3%) —
/live-video/skin.css 6.46 kB 6.43 kB -23 B (-0.3%) —
/live-video/minimal-skin 50.10 kB 50.09 kB -10 B (-0.0%) 0 B
/live-video/minimal-skin2 6.88 kB 6.87 kB -4 B (-0.1%) —
/live-video/skin 50.13 kB 50.11 kB -22 B (-0.0%) 0 B
/live-video/skin2 6.92 kB 6.91 kB -14 B (-0.2%) —
/live-audio/minimal-skin.css 4.63 kB 4.60 kB -29 B (-0.6%) —
/live-audio/skin.css 4.62 kB 4.61 kB -7 B (-0.1%) —
/live-audio/minimal-skin 35.90 kB 35.89 kB -8 B (-0.0%) 0 B
/live-audio/minimal-skin2 4.92 kB 4.91 kB -3 B (-0.1%) —
/live-audio/skin 35.89 kB 35.92 kB +30 B (+0.1%) 0 B
/ui/menu 18.54 kB 18.54 kB +3 B (+0.0%) 0 B
/ui/menu-content 7.52 kB 7.53 kB +11 B (+0.1%) 0 B
/ui/popover 8.57 kB 8.58 kB +6 B (+0.1%) 0 B
/ui/tooltip 9.95 kB 9.96 kB +15 B (+0.1%) 0 B
/ui/volume-popover 14.82 kB 14.84 kB +20 B (+0.1%) 0 B
/video (default) 64.09 kB 64.07 kB -16 B (-0.0%) 0 B
/video (default + hls) 65.86 kB 65.85 kB -14 B (-0.0%) 0 B
/video (minimal) 64.35 kB 64.41 kB +69 B (+0.1%) 0 B
/video (minimal + hls) 66.11 kB 66.25 kB +143 B (+0.2%) 0 B
/audio (default) 47.69 kB 47.74 kB +52 B (+0.1%) 0 B
/audio (minimal) 47.89 kB 47.93 kB +42 B (+0.1%) 0 B
Presets (7)
Entry Initial Lazy
/video (default) 64.07 kB 58.19 kB
/video (default + hls) 65.85 kB 58.19 kB
/video (minimal) 64.41 kB 58.19 kB
/video (minimal + hls) 66.25 kB 58.19 kB
/audio (default) 47.74 kB 58.19 kB
/audio (minimal) 47.93 kB 58.19 kB
/background 11.65 kB 58.19 kB
Media (18)
Entry Initial
/media/mux-video 3.01 kB
/media/mux-audio 2.69 kB
/media/background-video 1.16 kB
/media/cloudflare-video 2.90 kB
/media/dash-video 2.63 kB
/media/hls-audio 22.05 kB
/media/hls-background-video 16.85 kB
/media/hls-video 28.01 kB
/media/hlsjs-video 2.63 kB
/media/mux-background-video 16.86 kB
/media/native-hls-video 7.59 kB
/media/shaka-video 2.63 kB
/media/spotify-audio 3.02 kB
/media/tiktok-video 3.13 kB
/media/twitch-video 2.93 kB
/media/vimeo-video 2.90 kB
/media/wistia-video 607 B
/media/youtube-video 2.90 kB
Players (5)
Entry Initial Lazy
/video/player 9.79 kB 58.19 kB
/audio/player 6.21 kB 58.19 kB
/background/player 4.46 kB 58.19 kB
/live-video/player 9.18 kB 58.19 kB
/live-audio/player 6.22 kB 58.19 kB
Skins (29)
Entry Type Initial Lazy
/video/minimal-skin.css css 8.07 kB —
/video/skin.css css 7.87 kB —
/video/minimal-skin js 62.95 kB 58.19 kB
/video/minimal-skin2 js 8.63 kB —
/video/skin js 62.71 kB 58.19 kB
/video/skin2 js 8.52 kB —
/audio/minimal-skin.css css 5.78 kB —
/audio/skin.css css 5.62 kB —
/audio/minimal-skin js 46.41 kB 58.19 kB
/audio/minimal-skin2 js 6.16 kB —
/audio/skin js 46.26 kB 58.19 kB
/audio/skin2 js 6.01 kB —
/background/skin.css css 139 B —
/background/skin js 9.91 kB 58.19 kB
/background/skin2 js 187 B —
/live-video/minimal-skin.css css 6.46 kB —
/live-video/skin.css css 6.43 kB —
/live-video/minimal-skin js 50.09 kB 58.19 kB
/live-video/minimal-skin2 js 6.87 kB —
/live-video/skin js 50.11 kB 58.19 kB
/live-video/skin2 js 6.91 kB —
/live-audio/minimal-skin.css css 4.60 kB —
/live-audio/skin.css css 4.61 kB —
/live-audio/minimal-skin js 35.89 kB 58.19 kB
/live-audio/minimal-skin2 js 4.91 kB —
/live-audio/skin js 35.92 kB 58.19 kB
/live-audio/skin2 js 4.92 kB —
/global.css css 190 B —
/shared.css css 134 B —
UI Components (62)
Entry Initial Lazy
/ui/airplay-button 11.36 kB 58.19 kB
/ui/alert-dialog 8.79 kB 58.19 kB
/ui/audio-track-radio-group 11.46 kB 58.19 kB
/ui/buffering-indicator 8.68 kB 58.19 kB
/ui/captions-button 11.59 kB 58.19 kB
/ui/captions-radio-group 11.54 kB 58.19 kB
/ui/cast-button 11.34 kB 58.19 kB
/ui/container 9.58 kB 58.19 kB
/ui/controls 8.86 kB 58.19 kB
/ui/controls-backdrop 1.69 kB 58.19 kB
/ui/controls-content 1.67 kB 58.19 kB
/ui/dialog 8.73 kB 58.19 kB
/ui/dialog-backdrop 1.70 kB 58.19 kB
/ui/dialog-close 2.06 kB 58.19 kB
/ui/dialog-description 1.69 kB 58.19 kB
/ui/dialog-popup 1.90 kB 58.19 kB
/ui/dialog-title 1.70 kB 58.19 kB
/ui/error-dialog 12.47 kB 58.19 kB
/ui/fullscreen-button 11.33 kB 58.19 kB
/ui/gesture 9.66 kB 58.19 kB
/ui/hotkey 10.13 kB 58.19 kB
/ui/live-button 9.89 kB 58.19 kB
/ui/menu 18.54 kB 58.19 kB
/ui/menu-checkbox-item 1.97 kB 58.19 kB
/ui/menu-content 7.53 kB 58.19 kB
/ui/menu-group 2.09 kB 58.19 kB
/ui/menu-group-label 1.64 kB —
/ui/menu-item 2.30 kB 58.19 kB
/ui/menu-item-indicator 1.38 kB 58.19 kB
/ui/menu-radio-group 3.01 kB 58.19 kB
/ui/menu-radio-item 2.13 kB 58.19 kB
/ui/menu-separator 1.30 kB 58.19 kB
/ui/mute-button 11.36 kB 58.19 kB
/ui/pip-button 11.31 kB 58.19 kB
/ui/play-button 11.31 kB 58.19 kB
/ui/playback-rate-button 11.41 kB 58.19 kB
/ui/playback-rate-radio-group 11.46 kB 58.19 kB
/ui/popover 8.58 kB 58.19 kB
/ui/poster 8.97 kB 58.19 kB
/ui/quality-radio-group 12.05 kB 58.19 kB
/ui/seek-button 11.34 kB 58.19 kB
/ui/seek-indicator 12.77 kB 58.19 kB
/ui/seek-indicator-value 1.10 kB —
/ui/slider 11.75 kB 58.19 kB
/ui/slider-preview 2.01 kB 58.19 kB
/ui/status-announcer 10.68 kB 58.19 kB
/ui/status-indicator 13.10 kB 58.19 kB
/ui/status-indicator-value 1.10 kB —
/ui/thumbnail 10.41 kB 58.19 kB
/ui/time 11.11 kB 58.19 kB
/ui/time-slider 13.22 kB 58.19 kB
/ui/time-slider-chapter-title 8.87 kB 58.19 kB
/ui/time-slider-chapters 9.71 kB 58.19 kB
/ui/title 8.25 kB 58.19 kB
/ui/tooltip 9.96 kB 58.19 kB
/ui/tooltip-label 1.21 kB —
/ui/tooltip-shortcut 1.18 kB —
/ui/volume-indicator 13.11 kB 58.19 kB
/ui/volume-indicator-fill 1.11 kB —
/ui/volume-indicator-value 1.10 kB —
/ui/volume-popover 14.84 kB 58.19 kB
/ui/volume-slider 12.43 kB 58.19 kB

⚛️ @videojs/react

Path Base initial PR initial Initial diff Lazy diff
/media/cloudflare-video 911 B 1.37 kB +493 B (+54.1%) —
/media/spotify-audio 901 B 1.36 kB +496 B (+55.0%) —
/media/tiktok-video 906 B 1.36 kB +490 B (+54.1%) —
/media/twitch-video 929 B 1.39 kB +496 B (+53.4%) —
/media/vimeo-video 888 B 1.34 kB +489 B (+55.1%) —
/media/wistia-video 619 B 1.03 kB +438 B (+70.8%) —
/media/youtube-video 897 B 1.35 kB +483 B (+53.8%) —
Small changes (40, ≤ 300 B)
Path Base initial PR initial Initial diff Lazy diff
/media/mux-video/hls-js 958 B 1.04 kB +104 B (+10.9%) —
/media/mux-video/spf 962 B 1.05 kB +111 B (+11.5%) —
/media/mux-audio/hls-js 699 B 812 B +113 B (+16.2%) —
/media/mux-audio/spf 703 B 818 B +115 B (+16.4%) —
/media/dash-video 693 B 808 B +115 B (+16.6%) —
/media/hls-audio 20.32 kB 20.45 kB +132 B (+0.6%) —
/media/hls-background-video 16.47 kB 16.51 kB +46 B (+0.3%) —
/media/hls-video 26.32 kB 26.38 kB +65 B (+0.2%) —
/media/hlsjs-video 695 B 809 B +114 B (+16.4%) —
/media/mux-audio 693 B 807 B +114 B (+16.5%) —
/media/mux-background-video 16.41 kB 16.52 kB +111 B (+0.7%) —
/media/mux-video 948 B 1.03 kB +110 B (+11.6%) —
/media/native-hls-video 5.78 kB 5.88 kB +107 B (+1.8%) —
/media/shaka-video 704 B 805 B +101 B (+14.3%) —
/video/minimal-skin.css 7.85 kB 7.90 kB +50 B (+0.6%) —
/video/skin.css 7.67 kB 7.69 kB +18 B (+0.2%) —
/video/minimal-skin 51.47 kB 51.49 kB +23 B (+0.0%) 0 B
/video/skin 51.28 kB 51.32 kB +49 B (+0.1%) 0 B
/audio/minimal-skin.css 5.60 kB 5.58 kB -19 B (-0.3%) —
/audio/skin.css 5.44 kB 5.43 kB -8 B (-0.1%) —
/audio/minimal-skin 39.78 kB 39.83 kB +51 B (+0.1%) 0 B
/audio/skin 39.74 kB 39.74 kB -6 B (-0.0%) 0 B
/live-video/minimal-skin.css 6.30 kB 6.29 kB -20 B (-0.3%) —
/live-video/skin.css 6.30 kB 6.27 kB -29 B (-0.4%) —
/live-video/minimal-skin 42.90 kB 42.94 kB +42 B (+0.1%) 0 B
/live-video/skin 42.92 kB 42.92 kB +10 B (+0.0%) 0 B
/live-audio/minimal-skin.css 4.43 kB 4.40 kB -31 B (-0.7%) —
/live-audio/skin.css 4.43 kB 4.42 kB -14 B (-0.3%) —
/live-audio/minimal-skin 30.55 kB 30.62 kB +66 B (+0.2%) 0 B
/live-audio/skin 30.58 kB 30.60 kB +18 B (+0.1%) 0 B
/ui/menu 19.54 kB 19.53 kB -14 B (-0.1%) 0 B
/ui/popover 8.16 kB 8.16 kB +2 B (+0.0%) 0 B
/ui/tooltip 8.93 kB 8.94 kB +11 B (+0.1%) 0 B
/ui/volume-popover 14.29 kB 14.30 kB +9 B (+0.1%) 0 B
/video (default) 51.41 kB 51.39 kB -18 B (-0.0%) 0 B
/video (default + hls) 51.67 kB 51.75 kB +86 B (+0.2%) 0 B
/video (minimal) 51.52 kB 51.52 kB +6 B (+0.0%) 0 B
/video (minimal + hls) 51.79 kB 51.85 kB +61 B (+0.1%) 0 B
/audio (default) 39.82 kB 39.84 kB +18 B (+0.0%) 0 B
/audio (minimal) 39.89 kB 39.86 kB -28 B (-0.1%) 0 B
Presets (7)
Entry Initial Lazy
/video (default) 51.39 kB 58.19 kB
/video (default + hls) 51.75 kB 58.19 kB
/video (minimal) 51.52 kB 58.19 kB
/video (minimal + hls) 51.85 kB 58.19 kB
/audio (default) 39.84 kB 58.19 kB
/audio (minimal) 39.86 kB 58.19 kB
/background 581 B 58.19 kB
Media (22)
Entry Initial
/media/mux-video/hls-js 1.04 kB
/media/mux-video/spf 1.05 kB
/media/mux-audio/hls-js 812 B
/media/mux-audio/spf 818 B
/media/background-video 402 B
/media/cloudflare-video 1.37 kB
/media/dash-video 808 B
/media/hls-audio 20.45 kB
/media/hls-background-video 16.51 kB
/media/hls-video 26.38 kB
/media/hlsjs-video 809 B
/media/mux-audio 807 B
/media/mux-background-video 16.52 kB
/media/mux-video 1.03 kB
/media/native-hls-video 5.88 kB
/media/shaka-video 805 B
/media/spotify-audio 1.36 kB
/media/tiktok-video 1.36 kB
/media/twitch-video 1.39 kB
/media/vimeo-video 1.34 kB
/media/wistia-video 1.03 kB
/media/youtube-video 1.35 kB
Extensions (2)
Entry Initial
/extensions/google-cast 1.59 kB
/extensions/mux-data 1.64 kB
Players (5)
Entry Initial Lazy
/video/player 7.67 kB 58.19 kB
/audio/player 4.06 kB 58.19 kB
/background/player 2.27 kB 58.19 kB
/live-video/player 7.06 kB 58.19 kB
/live-audio/player 4.05 kB 58.19 kB
Skins (18)
Entry Type Initial Lazy
/video/minimal-skin.css css 7.90 kB —
/video/skin.css css 7.69 kB —
/video/minimal-skin js 51.49 kB 58.19 kB
/video/skin js 51.32 kB 58.19 kB
/audio/minimal-skin.css css 5.58 kB —
/audio/skin.css css 5.43 kB —
/audio/minimal-skin js 39.83 kB 58.19 kB
/audio/skin js 39.74 kB 58.19 kB
/background/skin.css css 90 B —
/background/skin js 277 B —
/live-video/minimal-skin.css css 6.29 kB —
/live-video/skin.css css 6.27 kB —
/live-video/minimal-skin js 42.94 kB 58.19 kB
/live-video/skin js 42.92 kB 58.19 kB
/live-audio/minimal-skin.css css 4.40 kB —
/live-audio/skin.css css 4.42 kB —
/live-audio/minimal-skin js 30.62 kB 58.19 kB
/live-audio/skin js 30.60 kB 58.19 kB
UI Components (39)
Entry Initial Lazy
/ui/airplay-button 10.53 kB 58.19 kB
/ui/alert-dialog 4.73 kB 58.19 kB
/ui/audio-track 8.04 kB 58.19 kB
/ui/audio-track-radio-group 9.57 kB 58.19 kB
/ui/buffering-indicator 7.88 kB 58.19 kB
/ui/captions-button 10.51 kB 58.19 kB
/ui/captions-radio-group 9.67 kB 58.19 kB
/ui/cast-button 10.51 kB 58.19 kB
/ui/controls 7.80 kB 58.19 kB
/ui/dialog 4.75 kB 58.19 kB
/ui/error-dialog 11.88 kB 58.19 kB
/ui/fullscreen-button 10.49 kB 58.19 kB
/ui/gesture 8.07 kB 58.19 kB
/ui/hotkey 8.56 kB 58.19 kB
/ui/live-button 8.91 kB 58.19 kB
/ui/menu 19.53 kB 58.19 kB
/ui/mute-button 10.53 kB 58.19 kB
/ui/pip-button 10.48 kB 58.19 kB
/ui/play-button 10.45 kB 58.19 kB
/ui/playback-rate 8.07 kB 58.19 kB
/ui/playback-rate-button 10.45 kB 58.19 kB
/ui/playback-rate-radio-group 9.60 kB 58.19 kB
/ui/popover 8.16 kB 58.19 kB
/ui/poster 7.95 kB 58.19 kB
/ui/quality 8.50 kB 58.19 kB
/ui/quality-radio-group 10.04 kB 58.19 kB
/ui/seek-button 10.52 kB 58.19 kB
/ui/seek-indicator 12.06 kB 58.19 kB
/ui/slider 13.12 kB 58.19 kB
/ui/status-announcer 10.18 kB 58.19 kB
/ui/status-indicator 12.37 kB 58.19 kB
/ui/thumbnail 9.18 kB 58.19 kB
/ui/time 10.03 kB 58.19 kB
/ui/time-slider 14.40 kB 58.19 kB
/ui/title 7.35 kB 58.19 kB
/ui/tooltip 8.94 kB 58.19 kB
/ui/volume-indicator 12.42 kB 58.19 kB
/ui/volume-popover 14.30 kB 58.19 kB
/ui/volume-slider 12.25 kB 58.19 kB
🧩 @videojs/core — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
/dom 22.82 kB 22.82 kB +5 B (+0.0%) 0 B
Entries (76)
Entry Initial Lazy
. 13.35 kB —
/dom 22.82 kB 58.19 kB
/vjsc 1.87 kB —
/i18n 3.23 kB 58.19 kB
/i18n/locales/all 35.98 kB —
/i18n/locales/ar 1.24 kB —
/i18n/locales/az 1.12 kB —
/i18n/locales/bg 1.32 kB —
/i18n/locales/bn 1.25 kB —
/i18n/locales/bs 1.03 kB —
/i18n/locales/ca 1.10 kB —
/i18n/locales/cs 1.11 kB —
/i18n/locales/cy 1.05 kB —
/i18n/locales/da 1.01 kB —
/i18n/locales/de 1.11 kB —
/i18n/locales/el 1.53 kB —
/i18n/locales/en 801 B —
/i18n/locales/es 1.02 kB —
/i18n/locales/et 1.07 kB —
/i18n/locales/eu 1.04 kB —
/i18n/locales/fa 1.25 kB —
/i18n/locales/fi 1.07 kB —
/i18n/locales/fr 1.09 kB —
/i18n/locales/gd 1.13 kB —
/i18n/locales/gl 1.02 kB —
/i18n/locales/he 1.16 kB —
/i18n/locales/hi 1.33 kB —
/i18n/locales/hr 1.05 kB —
/i18n/locales/hu 1.11 kB —
/i18n/locales/id 941 B —
/i18n/locales/it 1.04 kB —
/i18n/locales/ja 1.22 kB —
/i18n/locales/ko 1.18 kB —
/i18n/locales/lt 1.04 kB —
/i18n/locales/lv 1.11 kB —
/i18n/locales/mr 1.32 kB —
/i18n/locales/nb 1015 B —
/i18n/locales/ne 1.32 kB —
/i18n/locales/nl 1.02 kB —
/i18n/locales/nn 1015 B —
/i18n/locales/oc 1.10 kB —
/i18n/locales/pl 1.17 kB —
/i18n/locales/pt 1.05 kB —
/i18n/locales/pt-BR 1.05 kB —
/i18n/locales/pt-PT 1.04 kB —
/i18n/locales/ro 1.10 kB —
/i18n/locales/ru 1.42 kB —
/i18n/locales/sk 1.13 kB —
/i18n/locales/sl 1.07 kB —
/i18n/locales/sr 1.13 kB —
/i18n/locales/sv 1.03 kB —
/i18n/locales/te 1.34 kB —
/i18n/locales/th 1.31 kB —
/i18n/locales/tr 1.09 kB —
/i18n/locales/uk 1.44 kB —
/i18n/locales/vi 1.13 kB —
/i18n/locales/zh 1.04 kB —
/i18n/locales/zh-CN 1.04 kB —
/i18n/locales/zh-TW 1.04 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 322 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 1.05 kB
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.72 kB
/html 703 B
/react 365 B
🔧 @videojs/utils — no changes
Entries (13)
Entry Initial
/array 271 B
/dom 5.11 kB
/events 320 B
/function 386 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 976 B
/number 199 B
📦 @videojs/cdn — no changes
📦 @videojs/cloudflare-video — no changes
📦 @videojs/dash-video — no changes
📦 @videojs/google-cast — no changes
📦 @videojs/hlsjs-video — no changes
📦 @videojs/media — no changes
Entries (3)
Entry Initial
. 1.29 kB
/dom 4.12 kB
/media-tracks 2.05 kB

📦 @videojs/mux

Path Base initial PR initial Initial diff Lazy diff
. 804 B 1.24 kB +467 B (+58.1%) —

📦 @videojs/mux-audio

Path Base initial PR initial Initial diff Lazy diff
. 135.53 kB 135.89 kB +365 B (+0.3%) —
/spf 20.81 kB 21.19 kB +396 B (+1.9%) —
Entries (2)
Entry Initial
. 135.89 kB
/spf 21.19 kB
📦 @videojs/mux-data — no changes

📦 @videojs/mux-video

Path Base initial PR initial Initial diff Lazy diff
/spf 26.72 kB 27.08 kB +368 B (+1.3%) —
Small changes (1, ≤ 300 B)
Path Base initial PR initial Initial diff Lazy diff
. 135.67 kB 135.95 kB +282 B (+0.2%) —
Entries (2)
Entry Initial
. 135.95 kB
/spf 27.08 kB
📦 @videojs/native-hls-video — no changes
📦 @videojs/shaka-video — no changes
📦 @videojs/spf — no changes
Entries (7)
Entry Initial
. 4.55 kB
/dom 6.60 kB
/hls 22.15 kB
/media-tracks 504 B
/hls-background-video 15.84 kB
/hls-audio 19.84 kB
/hls-video 25.89 kB
📦 @videojs/spotify-audio — no changes
📦 @videojs/tiktok-video — no changes
📦 @videojs/twitch-video — no changes
📦 @videojs/vimeo-video — no changes
📦 @videojs/wistia-video — no changes
Entries (2)
Entry Initial
. 1.91 kB
/helpers 1.77 kB
📦 @videojs/youtube-video — no changes

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

…iginal

Splits the page into three modes on one route. Without `panel` it is a
two-frame comparison; with it the page is a single player, which is what each
frame loads.

The comparison follows the shell's Compare: one axis differs, everything else
is shared, each panel is its own frame, and a checkbox mirrors playback between
them. The axis here is the port itself, which cannot live in the shell's
Compare because every axis there differs on a shell-owned selection.

Two frames is a requirement, not a preference. media-chrome and `@videojs/html`
register eleven of the same custom element names and whichever loads first
silently wins, so each stack gets its own module and its own document.

The reference panel loads the published theme from a pinned CDN bundle rather
than a dependency, so the StackBlitz upload does not have to resolve it. The
bundle carries its own pinned media-chrome and never reaches the workspace copy.

`installSandboxMirror` needed no changes: it moves state through the media
element, so it mirrors across two different player stacks as-is.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
cjpillsbury and others added 2 commits September 10, 2026 14:27
… page

The comparison shell, both panels and the router were written inside the
instaplay template. Thirteen more themes are coming, so they move to
`app/shared/player-style/` and a theme becomes markup, a stylesheet and two
small entries.

`themes.ts` is the registry: every theme's preset and the published version its
reference frame pins. Pinned rather than a range, since bumping one changes
what the comparison compares against.

Each panel entry now imports `@app/styles.css` itself instead of relying on a
caller, and `elements.ts` registers the presets alongside the UI elements. Both
were latent in the single-page version, where one entry happened to import
everything.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Second theme on the shared harness, with its comparison frame beside it. Icons
are the original's own SVGs rather than v10's set, since the theme ships them
and they carry its look.

Two things the side-by-side surfaced, both of which will repeat:

- v10 splits what media-chrome collapses. A control whose feature the platform
  lacks entirely reports `data-hidden`; one whose API exists but has nothing to
  offer — Chrome with no Cast device — reports
  `data-availability="unavailable"` and stays interactive-looking. media-chrome
  drops the control in both cases, so a faithful port hides both.
- The `sm:600` breakpoint becomes a container query on the skin root, which is
  how the packaged v10 skins handle the same thing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
cjpillsbury and others added 3 commits September 11, 2026 07:05
Halloween is the interesting one. The original reaches into media-chrome's
shadow DOM with `::part(track)` and `::part(thumb)`, and stacks a second range
element because a shadow part cannot carry an animation from the theme. v10
builds its slider from real children, so the parts become ordinary selectors
and the duplicate element disappears — the port is smaller than the original.

Two more differences that will repeat:

- media-chrome paints button icons from `--media-icon-color`, which overrides
  the artwork's own `fill`. v10 leaves icon paint to the skin, so artwork that
  ships `fill="none"` and expects the player to colour it renders blank. The
  halloween pumpkin lost its carved face to this.
- v10 reports volume level on `media-mute-button` only. Halloween styles its
  candle by level but has no mute button, so the port carries a hidden one as a
  state carrier.

Notflix steps `--media-font-size` at four breakpoints; those become container
queries at the same stops.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
First theme with binary assets. The original loads its pixel art through
player.style's build step, which inlines each PNG with an ejs `base64()` call;
a v10 skin is static markup with no such step, so the fourteen PNGs are inlined
at author time instead. Any real port needs an equivalent build step.

One detail does not carry over. The original nudges its slider thumbs a pixel
or two with selectors like `media-time-range[mediacurrenttime^="0"]`, reading
media-chrome's reflected state attributes. v10 exposes position as CSS
variables and reflects no numeric state, so those sub-pixel corrections are
dropped.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
First audio-preset port, and the one that exercised the icon pipeline hardest.

The original is written in Tailwind utilities and compiles its own stylesheet.
The sandbox already scans `templates/`, so the port keeps the utilities inline
and needs almost no authored CSS.

Three things this theme surfaced, all of which apply beyond it:

- Its icons are `<use href="#id">` against a sprite defined at the top of the
  template, outside the controller. The sprite has to come across with the
  markup or every control renders an empty box of the right size.
- media-chrome sizes button icons for you through
  `--media-button-icon-height`. v10 leaves sizing to the skin, so icons need
  explicit dimensions or they collapse.
- v10's playback-rate button carries no text of its own; it reports `data-rate`
  and the skin draws the label.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Adds a theme picker to the comparison header so themes can be swapped without
navigating, keeping every other selection in the query string — the way the
shell's own pickers work.

Also writes down what had been living in my head: which themes are ported, what
is still off in each, and — importantly — that "checked" so far means one width,
one source, paused, no captions, no menu open. A blank deltas cell means not
looked at, not matches.

Corrects two things earlier commit messages overstated:

- Icon colour is not missing from v10. Its icons ship `fill="currentColor"` and
  follow CSS `color`. What differs is that media-chrome forces `fill` onto
  slotted artwork and v10 never touches skin-authored SVG.
- Icon sizing is not absent either. `--media-icon-size` exists and the packaged
  skins size through it; it is marked internal, so a skin outside the package
  supplies its own.

Records one real upstream bug: the five availability-gated buttons compute
`hidden` four different ways, and cast is the outlier that leaves a dead control
visible in the packaged skin.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Artwork is referenced from player.style over a pinned CDN rather than copied
in. That theme is where these assets live, and the media-chrome repo already
does the same thing — a one-kilobyte example that consumes the published theme
rather than carrying the bitmaps.

This is the theme whose transport sits entirely outside `media-controller`,
bound with `mediacontroller="controller"`. v10 resolves state through DOM
ancestry with no id binding, so the controls are simply descendants of the
player and `media-container` wraps only the video region. The structure ports
unchanged.

Also fixes the theme picker, which showed the wrong label: `selected` set on a
detached option does not survive being appended, so the value is assigned after
insertion. And repairs `PORTED_THEMES`, which had silently lost two entries —
the formatter reflowed the array across lines and later single-line edits
no-opped against it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
cjpillsbury and others added 2 commits September 11, 2026 07:44
Structurally the same shape as demuxed-2022 — bottom scrim, decorated top
chrome, centred play, a control bar with the slider taking the remaining width.
The artwork is inline SVG in the original template rather than separate asset
files, so it stays inline here; that is most of the theme's size.

Its `sm:600` breakpoint, which only shrinks the slider thumb, becomes a
container query at the same stop.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The clearest case of a theme that delegates rather than styles. Sutro's own
stylesheet is 66 lines: it sets a `--base` scale and a handful of `--media-*`
variables and lets media-chrome's built-in control styling do the rest. v10 has
no equivalents for most of those, so the port authors what the original got for
free — control sizing, the menu surface, every slider part.

Its `--base` steps 18 → 20 → 24px across a width breakpoint and fullscreen,
which is what `--media-scale-unit` does for the packaged v10 skins. That
variable is internal, so the scale stays local to the theme.

Also the first port with a nested settings menu: media-chrome's single element
with `slot="submenu"` children becomes `media-menu` plus sibling
`media-menu-content` panels addressed by `commandfor`, each list supplied by a
radio group rendering its `<template>` per option.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Summary

inconclusive — the Registry consumers job aborted during global setup while building the generated next-react-tailwind consumer. No Playwright test assertion ran.

Failed run

Run 34612404353 · head SHA 8ea426ef3e6dbd573c911ebdf8068a1352c2146c · affected: the registry suite's next-react-tailwind consumer build (the consumer tests did not start).

Evidence

  • The failing command was pnpm --ignore-workspace run build; its only reported error was thread '<unknown>' ... has overflowed its stack followed by fatal runtime error: stack overflow, aborting.
  • Setup installed all five consumers and verified the other four; next-react-tailwind was installed but has no Verified line. The Playwright report has no test result/trace, and the run says apps/e2e/test-results/registry/ was absent.
  • The PR diff changes 54 files, all under apps/sandbox/; it does not change the registry E2E suite, workflow, manifests, or lockfile. The remaining browser E2E, sandbox, and skin-parity jobs passed.

Likely cause

Verified: the failure happened inside the generated Next/Tailwind consumer's build before browser coverage began. Inference: this looks like a toolchain/runtime failure in that build path, not evidence of a product regression from this sandbox-only diff; the available output does not identify the crashing binary or a reproducible source-level cause.

Recommended actions

  1. Re-run or reproduce only @videojs/e2e#test:registry; retain the generated next-react-tailwind directory and its full build output.
  2. From that directory, run pnpm --ignore-workspace run build directly with Next/Rust diagnostic output enabled to identify the crashing tool; compare the same generated fixture on main.
  3. If it reproduces only with this SHA, bisect the generated registry inputs despite the diff scope; otherwise treat this run as infrastructure/toolchain flakiness.

Second audio preset, and the same delegate-heavy shape as sutro: 71 lines of
its own CSS, everything else inherited from media-chrome's control styling, so
the port authors the sizing and slider parts off the `--base` scale itself.

Its `mediatitle` and `mediabyline` template expressions become slots the page
fills, which is the shape the packaged skins already use for a replaceable
poster.

Also widens the harness poster resolver. It only looked for `media-poster img`,
which video themes use; audio themes place the artwork themselves behind a
named slot, so theirs was being dropped and the cover never appeared.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
cjpillsbury and others added 4 commits September 11, 2026 08:04
Three separate menus rather than one settings menu, so each gets its own
`media-menu` and trigger. The original's `bounds="vimeonova-bounds"` —
media-chrome's way of constraining the preview box to an element — becomes the
slider preview's own `overflow="clamp"`.

Records a harness limitation the theme exposed: skins are stamped into light
DOM, where `<slot>` is inert. Themes that expose a title or byline through a
named slot render nothing, and an empty chip where the markup wraps it. Only a
shadow-DOM skin — v10's own `SkinElement` — can honour named slots, which is a
point in favour of that being the eventual distribution shape. Hidden for now
in vimeonova and sutro-audio, which both have one.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Same settings-menu shape as sutro, plus a set of centred controls for narrow
widths. Another delegate-heavy theme — 57 lines of its own CSS — so the port
authors the control sizing and slider parts itself.

Its largest size is tied to fullscreen rather than a width, which ports
directly as `:fullscreen` on the skin root.

Two deltas recorded rather than chased, per the first-pass standard: the bar's
play glyph renders as a skip icon, and the centred seek controls appear at the
wrong breakpoint.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The theme the audit called hardest, and the reason is composition rather than
size. media-chrome let it render a different *set* of controls per breakpoint
through `<template if="breakpointsm">`. v10 skins are static, so every control
is always in the tree and container queries decide what shows. Hidden controls
use `display: none` so they leave the tab order and the accessibility tree
rather than just the picture.

Only the on-demand half. The original also branches on `streamtype == 'live'`,
which in v10 is a separate preset and therefore a second skin the harness does
not yet mount.

Known delta: at a given width the port shows more controls than the original,
so the thresholds still need reconciling against media-chrome's breakpoints.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Last of the fourteen. Its controls are a centred cluster rather than a bottom
bar, with the scrubber directly underneath.

On-demand only. The original branches on `streamtype == 'live'` and again on
whether there is a target live window, which in v10 means the `live-video`
preset and a second skin.

Known deltas: the cluster sits centre-vertically where the original sits it
near the bottom, and more controls show at a given width than the original's
breakpoints allow.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Summary

Classification: inconclusive. The registry-consumer suite failed during global setup; no Playwright test began.

Failed run

Evidence

  • The failed job timed out after 120 seconds waiting for http://127.0.0.1:5310 in apps/e2e/suites/registry/setup/global.ts; the other four generated consumers installed and verified.
  • The spawned server uses ignored stdio, so the log has no Next startup error. Global setup failed before tests, and the trace upload reported no files. The Playwright report is present but contains no executed test result.
  • The PR diff changes sandbox player-style templates/shared code and ambient ?raw typing; it does not modify registry-consumer setup, its projects, or package/registry sources.

Likely cause

Verified: the next-react-tailwind server never returned a successful response on port 5310 in this run.
Inference: this looks like an isolated consumer-startup or CI-environment failure, not evidence that the sandbox-only change regressed product behavior.

Recommended actions

  • Reproduce pnpm exec vp run '@videojs/e2e#test:registry' and capture the generated next-react-tailwind server output.
  • If it recurs, make startup diagnostics available (rather than ignored stdio) and inspect the generated consumer's pnpm start failure.

…nd yt

All three were recorded as breakpoint-threshold mismatches. That diagnosis was
wrong; none of them was a threshold problem.

- `minimal` and `microvideo` default their seek and picture-in-picture buttons
  off behind a custom property, so an integrator opts in. Three rules near the
  end of each stylesheet, which I missed by reading only the first sixty lines.
- `yt`'s play artwork ships both states as sub-groups of one SVG with no rules
  of its own; media-chrome toggled them from the player's stylesheet, so both
  painted at once and overlapped into an unreadable glyph.
- `yt`'s centred seek controls are not width-gated in the original — that gate
  was mine — and they render empty because media-chrome supplied default icons
  for an empty button where v10 supplies none.

Also drops the duration from `minimal`'s readout, which shows elapsed time
only, and bottom-aligns `microvideo`'s cluster with the scrubber pinned to the
edge, matching where media-chrome's centred-chrome grid puts them.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Completes the catalogue at sixteen skins from fourteen themes. media-chrome
selected the live branch with `streamtype == 'live'`; v10 puts live on its own
preset, so each is a second skin compared against the same published package.

The harness gains live support: `mountPortedPanel` now takes the player tag
from the sandbox context rather than hardcoding it, so the live preset is
picked up, and a live port mounts `hls-video` — a plain `<video>` cannot play
the live source in Chrome, and without playback the stream type never resolves
and the live controls stay inert. The comparison lands live themes on a live
source when the URL names none, since comparing a live skin against an
on-demand source shows neither side's live branch.

Each live skin imports its on-demand sibling's stylesheet and adds only what
the live branch needs, so the two stay in step.

Known simplification: the originals branch again on whether there is a target
live window, showing a scrubber and seek controls only with DVR. v10 exposes no
equivalent to select on, so these render the DVR shape and the no-DVR variant
is unported.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The live ports mounted `<live-video-player>`, but `elements.ts` registered only
the video and audio presets — so it was an unknown element with no store, and
no state reached any control. The media played, because `hls-video` plays
independently of the player, and the skin rendered, so it looked correct while
the live button, scrubber and everything else were inert. Verified: the live
button now reports `data-live` and the slider receives a fill value.

Also corrects the note on DVR. v10 does model it — `targetLiveWindow` is in
store state and the live button already reads it. What is missing is a data
attribute reflecting it, which is what a static skin needs to select on. v10's
own live skins avoid the question by carrying no scrubber at all.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
cjpillsbury and others added 2 commits September 11, 2026 15:47
Adds a React implementation of the instaplay port beside the hand-written
HTML one, reached with `?impl=react` and toggled by a checkbox in the
comparison header. The reference frame is untouched either way, so both
implementations are compared against the same published original.

The skin sizes its controls in `em` and steps each one to 17px once the
container reaches 384px, which is how the original scales. The step sits on
the controls rather than the container: a container query matches ancestors
only, so the element declaring the container cannot answer its own query —
the original bumps `[role='button']` for the same reason.

Two things the React target leaves to the skin that media-chrome does for
you: a `<video>` the page authored needs sizing, or it lays out at its
intrinsic dimensions inside the skin's box, and `Poster.Root` reports
visibility through `data-visible` without acting on it.

Also moves the theme's source default into `applyThemeDefaults`, shared by
the comparison shell and the panel route. It used to live in the shell
alone, so a live theme's panel URL opened on its own fell back to the
sandbox's on-demand default and reported the source as unplayable.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Every port, plus the React implementation, loaded and checked for the
things only the rendered page can answer: the media fills the skin's box, a
play control exists and survives Playwright's actionability check, clicking
it reaches playback and the clock moves, and no image is left painting over
the video once it plays.

Each check is pinned to a defect this suite was written against. Player
state alone reported all of them as working: a video left unsized plays
perfectly while laying out at its intrinsic size, a poster that never
hides covers a video that is playing behind it, and a control under an
overlay reports the right state while swallowing the click.

The pages load with `preload: none` deliberately. Loaded media hides the
sizing defect rather than exposing it — a frame wider than the skin is
capped by the page's `max-width` reset and lands on the right size for the
wrong reason, while a narrower one stays small. With nothing loaded there
is no intrinsic size, so the box is the skin's CSS and nothing else.

The published live themes carry no play button, so their ports have none
either; those reach playback through the media element instead.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
cjpillsbury and others added 2 commits September 11, 2026 16:16
Interactive Playwright runs against the published original, state by state,
turned up four things the fixed-state checks never saw.

The progress bar never rendered. `Slider.Fill` and `Slider.Buffer` render a
bare element and report progress only through `--media-slider-fill` and
`--media-slider-buffer`; a layer that reads neither has no extent, so both
sat at zero width through every state while the variables read correctly.
They now clip to their variable, which is what the packaged skins' own
`clip-media-x-*` utility does, and the fill swaps to `--media-slider-pointer`
while dragging so it follows the pointer rather than the committed time.

The preview had no thumbnail. The panel never passed the storyboard track
the hand-written port gets from the same helpers, and the thumbnail carried
no size cap — `Thumbnail.Root` scales a tile to whatever its computed style
allows, so an uncapped one rendered half again as wide as the original's.
The cap is declared on the preview and read by the thumbnail, as the
packaged skins do, at the 180px the original uses.

`Controls.Content` covered the whole surface, so it sat above the centred
play button and the gesture layer and had to be excused with
`pointer-events`. The packaged skins position their control groups instead;
anchored to the bottom edge and only as tall as its two rows, nothing needs
excusing.

The container now carries `isolate` and names itself `media-root` after the
packaged container, and the media and poster take that container's rule for
slotted media, down to reading the public `--media-object-fit`.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The fill sat at zero width in the React port through every state the suite
already checked, because nothing in it looked at the progress bar. This
compares the fill's rendered extent against the share of the track
`--media-slider-fill` claims.

The extent is read back rather than the declaration: a skin reads the
variable as a width or as a clip on a full-size layer, and either way a
layer that reads nothing renders at zero however plausible its markup
looks. Both forms name the variable in the declaration that uses it, so one
selector finds either. Where a theme has a volume slider too, the fills are
indistinguishable by markup and the widest track wins.

Polled rather than read once, since several of these skins transition the
fill. Winamp opts out: it shows position with a thumb on a bare track and
has no fill layer, as the original does.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Summary

Classification: inconclusive. The Registry consumers job failed before any Playwright browser test ran: TypeScript aborted with a native stack overflow.

Failed run

Run 34657478266 · head debbdc2e46dfd1428c91061cdf14177d4f7fa22c

Affected tests: none executed; failure occurred in Registry consumers global setup while verifying generated React consumers.

Evidence

  • The failed step was Validate registry consumers; all other E2E jobs succeeded.
  • The log records successful install/build verification for Vite, Rspack, and both Next consumers, then pnpm --ignore-workspace exec tsc --noEmit terminated with thread ... has overflowed its stack / fatal runtime error: stack overflow, aborting.
  • The playwright-report-registry artifact contains no test result, screenshot, or trace, consistent with a global-setup failure.
  • This PR adds sandbox player.style routes/templates and sandbox E2E coverage; it does not modify the registry-consumer suite, overlays, or skin registry packages.

Likely cause

Verified: the failing process is the TypeScript compiler invoked by apps/e2e/suites/registry/setup/global.ts during React-consumer verification, not product playback or a Playwright assertion.

Inference: this is a TypeScript/toolchain stack-overflow failure or an interaction in the generated consumer environment, rather than evidence of a regression introduced by the sandbox-only diff.

Recommended actions

  1. Re-run the registry-consumer job to determine reproducibility.
  2. If it repeats, retain the generated consumer directory and run pnpm --ignore-workspace exec tsc --noEmit separately in the last verified React project (the log leaves webpack-react-css unverified).
  3. Capture the TypeScript version and a compiler stack trace/minimal generated project before attributing the failure to this PR.

@cjpillsbury

Copy link
Copy Markdown
Collaborator Author

used as starting point / superceded by efforts from @decepulis

@cjpillsbury cjpillsbury closed this Oct 9, 2026

This branch was successfully deployed

1 active deployment
Preview — debbdc2e Deployed Sep 11, 2026 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant