Skip to content
This repository was archived by the owner on Oct 21, 2026. It is now read-only.

fix(core): resolve slider defaults from the subclass - #2597

Closed
mihar-22 wants to merge 1 commit into
mainfrom
fix/core-slider-subclass-defaults
Closed

mihar-22 wants to merge 1 commit into
mainfrom
fix/core-slider-subclass-defaults

Conversation

@mihar-22

@mihar-22 mihar-22 commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary

Scrolling the mouse wheel over the volume slider called setVolume(NaN) in both the HTML and React players.

SliderCore.setProps resolved defaults against the static base-class SliderCore.defaultProps, and defaults() (@videojs/utils/object) only copies keys owned by its defaults argument. VolumeSliderCore declares static override defaultProps with an extra wheelStep, and its own setProps override did pre-fill it, but handing the result to super.setProps re-ran defaults() against the base defaults and stripped wheelStep from #props. getWheelStepPercent() then computed undefined / range * 100 = NaN, which createWheelStep fed straight into setVolume.

The same static lookup in the #props field initializer also meant a no-arg new VolumeSliderCore() kept the base step: 1 instead of the volume default 5.

TimeSliderCore is not affected: it shadows #props with its own copy and reads pauseOnDrag / changeThrottle from there.

Surfaced while writing the tests for #2595.

Changes

  • packages/core/src/core/ui/slider/core.ts: resolve defaultProps through the instantiated class (this.constructor) via a private #defaultProps getter, used by both the #props initializer and setProps. No public API shape changes; the props getter type is unchanged.
  • packages/core/src/core/ui/volume-slider/core.ts: drop the now-redundant re-defaulting in setProps; the override remains only to widen the accepted props type.
  • packages/core/src/core/ui/volume-slider/tests/core.test.ts: add getWheelStepPercent tests for the default step, an explicit wheelStep, and no-arg construction. All three fail on main.
  • packages/react/src/ui/volume-slider/tests/volume-slider.test.tsx: the existing wheel tests only asserted setVolume was called; add one that asserts the value (0.8 volume + default 5% step = 0.85). Verified it fails with Received: NaN against the pre-fix core.

Testing

  • pnpm -F @videojs/core test src/core/ui: 45 files, 585 tests passed
  • pnpm exec vp run @videojs/core#build
  • pnpm -F @videojs/html test src/ui/volume-slider: 9 passed
  • pnpm -F @videojs/react test src/ui/volume-slider: 13 passed
  • pnpm lint:fix:file on touched files: 0 errors
  • pnpm typecheck: clean
  • git diff --check: clean

🤖 Generated with Claude Code

`SliderCore.setProps` filled props against the static base-class
`defaultProps`, and `defaults()` only copies keys owned by its defaults
argument. `VolumeSliderCore` extends `defaultProps` with `wheelStep`, so
that key was dropped from `#props` even when the subclass pre-filled it,
and `getWheelStepPercent()` returned `NaN`. Both the HTML and React
volume sliders then called `setVolume(NaN)` on wheel input. The same
static lookup in the field initializer also left a no-arg
`new VolumeSliderCore()` with the base `step` instead of the volume step.

Resolve `defaultProps` through the instantiated class so subclass keys
survive both construction and `setProps`, and drop the now-redundant
re-defaulting in `VolumeSliderCore.setProps`.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@netlify

netlify Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit 8252f4d
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/6a98addb2cd43f00086c65f9
😎 Deploy Preview https://deploy-preview-2597--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@vercel

vercel Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v10-sandbox Ready Ready Preview Sep 2, 2026 11:15pm UTC

Request Review

@pkg-pr-new

pkg-pr-new Bot commented Sep 2, 2026

Copy link
Copy Markdown
@videojs/core

pnpm add https://pkg.pr.new/@videojs/core@2597

@videojs/element

pnpm add https://pkg.pr.new/@videojs/element@2597

@videojs/html

pnpm add https://pkg.pr.new/@videojs/html@2597

@videojs/media

pnpm add https://pkg.pr.new/@videojs/media@2597

@videojs/react

pnpm add https://pkg.pr.new/@videojs/react@2597

@videojs/spf

pnpm add https://pkg.pr.new/@videojs/spf@2597

@videojs/store

pnpm add https://pkg.pr.new/@videojs/store@2597

@videojs/utils

pnpm add https://pkg.pr.new/@videojs/utils@2597

commit: 8252f4d

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

🎨 @videojs/html — 17 small size changes
Path Base initial PR initial Initial diff Lazy diff
/video/minimal-skin 60.28 kB 60.29 kB +13 B (+0.0%) 0 B
/video/skin 60.54 kB 60.47 kB -63 B (-0.1%) 0 B
/audio/minimal-skin 46.43 kB 46.38 kB -53 B (-0.1%) 0 B
/audio/skin 50.32 kB 50.31 kB -8 B (-0.0%) 0 B
/live-video/minimal-skin 54.40 kB 54.42 kB +18 B (+0.0%) 0 B
/live-video/skin 56.99 kB 56.97 kB -17 B (-0.0%) 0 B
/live-audio/minimal-skin 39.72 kB 39.71 kB -2 B (-0.0%) 0 B
/live-audio/skin 43.33 kB 43.32 kB -16 B (-0.0%) 0 B
/ui/slider 12.12 kB 12.12 kB +2 B (+0.0%) 0 B
/ui/time-slider 15.04 kB 15.05 kB +5 B (+0.0%) 0 B
/ui/volume-slider 12.79 kB 12.76 kB -25 B (-0.2%) 0 B
/video (default) 62.05 kB 62.04 kB -12 B (-0.0%) 0 B
/video (default + hls) 200.93 kB 201.06 kB +127 B (+0.1%) 0 B
/video (minimal) 61.78 kB 61.75 kB -33 B (-0.1%) 0 B
/video (minimal + hls) 200.76 kB 200.80 kB +37 B (+0.0%) 0 B
/audio (default) 51.81 kB 51.75 kB -69 B (-0.1%) 0 B
/audio (minimal) 47.89 kB 47.89 kB +7 B (+0.0%) 0 B
Presets (7)
Entry Initial Lazy
/video (default) 62.04 kB 56.87 kB
/video (default + hls) 201.06 kB 56.87 kB
/video (minimal) 61.75 kB 56.87 kB
/video (minimal + hls) 200.80 kB 56.87 kB
/audio (default) 51.75 kB 56.87 kB
/audio (minimal) 47.89 kB 56.87 kB
/background 11.52 kB 56.87 kB
Media (18)
Entry Initial
/media/mux-video 142.40 kB
/media/mux-audio 142.23 kB
/media/background-video 1.16 kB
/media/cloudflare-video 6.28 kB
/media/dash-video 211.61 kB
/media/hls-audio 22.09 kB
/media/hls-background-video 16.80 kB
/media/hls-video 28.04 kB
/media/hlsjs-video 141.22 kB
/media/mux-background-video 16.83 kB
/media/native-hls-video 7.57 kB
/media/shaka-video 199.18 kB
/media/spotify-audio 6.27 kB
/media/tiktok-video 6.33 kB
/media/twitch-video 6.22 kB
/media/vimeo-video 13.05 kB
/media/wistia-video 60.23 kB
/media/youtube-video 6.81 kB
Extensions (2)
Entry Initial
/extensions/google-cast 6.52 kB
/extensions/mux-data 26.94 kB
Players (5)
Entry Initial Lazy
/video/player 9.70 kB 56.87 kB
/audio/player 6.14 kB 56.87 kB
/background/player 4.46 kB 56.87 kB
/live-video/player 9.06 kB 56.87 kB
/live-audio/player 6.15 kB 56.87 kB
Skins (29)
Entry Type Initial Lazy
/video/minimal-skin.css css 6.63 kB —
/video/skin.css css 6.45 kB —
/video/minimal-skin js 60.29 kB 56.87 kB
/video/minimal-skin2 js 7.19 kB —
/video/skin js 60.47 kB 56.87 kB
/video/skin2 js 7.04 kB —
/audio/minimal-skin.css css 4.95 kB —
/audio/skin.css css 4.88 kB —
/audio/minimal-skin js 46.38 kB 56.87 kB
/audio/minimal-skin2 js 5.36 kB —
/audio/skin js 50.31 kB 56.87 kB
/audio/skin2 js 5.32 kB —
/background/skin.css css 145 B —
/background/skin js 9.77 kB 56.87 kB
/background/skin2 js 190 B —
/live-video/minimal-skin.css css 6.63 kB —
/live-video/skin.css css 6.45 kB —
/live-video/minimal-skin js 54.42 kB 56.87 kB
/live-video/minimal-skin2 js 7.19 kB —
/live-video/skin js 56.97 kB 56.87 kB
/live-video/skin2 js 7.04 kB —
/live-audio/minimal-skin.css css 4.95 kB —
/live-audio/skin.css css 4.88 kB —
/live-audio/minimal-skin js 39.71 kB 56.87 kB
/live-audio/minimal-skin2 js 5.36 kB —
/live-audio/skin js 43.32 kB 56.87 kB
/live-audio/skin2 js 5.32 kB —
/global.css css 190 B —
/shared.css css 118 B —
UI Components (50)
Entry Initial Lazy
/ui/airplay-button 11.26 kB 56.87 kB
/ui/alert-dialog 9.44 kB 56.87 kB
/ui/audio-track-radio-group 11.34 kB 56.87 kB
/ui/buffering-indicator 8.61 kB 56.87 kB
/ui/captions-button 11.51 kB 56.87 kB
/ui/captions-radio-group 11.43 kB 56.87 kB
/ui/cast-button 11.25 kB 56.87 kB
/ui/container 9.47 kB 56.87 kB
/ui/controls 8.81 kB 56.87 kB
/ui/controls-backdrop 1.69 kB 56.87 kB
/ui/controls-content 1.67 kB 56.87 kB
/ui/dialog 9.35 kB 56.87 kB
/ui/dialog-backdrop 1.70 kB 56.87 kB
/ui/dialog-close 2.06 kB 56.87 kB
/ui/dialog-description 1.69 kB 56.87 kB
/ui/dialog-popup 1.90 kB 56.87 kB
/ui/dialog-title 1.70 kB 56.87 kB
/ui/error-dialog 13.01 kB 56.87 kB
/ui/fullscreen-button 11.27 kB 56.87 kB
/ui/gesture 9.56 kB 56.87 kB
/ui/hotkey 9.97 kB 56.87 kB
/ui/live-button 9.74 kB 56.87 kB
/ui/menu 20.06 kB 56.87 kB
/ui/mute-button 11.28 kB 56.87 kB
/ui/pip-button 11.22 kB 56.87 kB
/ui/play-button 11.23 kB 56.87 kB
/ui/playback-rate-button 11.32 kB 56.87 kB
/ui/playback-rate-radio-group 11.34 kB 56.87 kB
/ui/popover 8.56 kB 56.87 kB
/ui/poster 8.67 kB 56.87 kB
/ui/quality-radio-group 11.94 kB 56.87 kB
/ui/seek-button 11.27 kB 56.87 kB
/ui/seek-indicator 12.69 kB 56.87 kB
/ui/seek-indicator-value 1.10 kB —
/ui/slider 12.12 kB 56.87 kB
/ui/status-announcer 10.59 kB 56.87 kB
/ui/status-indicator 13.03 kB 56.87 kB
/ui/status-indicator-value 1.10 kB —
/ui/thumbnail 9.84 kB 56.87 kB
/ui/time 10.87 kB 56.87 kB
/ui/time-slider 15.05 kB 56.87 kB
/ui/time-slider-chapter-title 8.79 kB 56.87 kB
/ui/time-slider-chapters 9.76 kB 56.87 kB
/ui/title 8.17 kB 56.87 kB
/ui/tooltip 9.95 kB 56.87 kB
/ui/volume-indicator 13.03 kB 56.87 kB
/ui/volume-indicator-fill 1.11 kB —
/ui/volume-indicator-value 1.10 kB —
/ui/volume-popover 14.72 kB 56.87 kB
/ui/volume-slider 12.76 kB 56.87 kB
⚛️ @videojs/react — 25 small size changes
Path Base initial PR initial Initial diff Lazy diff
/video/minimal-skin 48.18 kB 48.26 kB +85 B (+0.2%) 0 B
/video/minimal-skin.tailwind 55.09 kB 55.14 kB +58 B (+0.1%) 0 B
/video/skin 48.16 kB 48.22 kB +65 B (+0.1%) 0 B
/video/skin.tailwind 54.92 kB 54.95 kB +37 B (+0.1%) 0 B
/audio/minimal-skin 37.54 kB 37.50 kB -40 B (-0.1%) 0 B
/audio/minimal-skin.tailwind 42.61 kB 42.65 kB +47 B (+0.1%) 0 B
/audio/skin 37.43 kB 37.50 kB +69 B (+0.2%) 0 B
/audio/skin.tailwind 42.56 kB 42.63 kB +70 B (+0.2%) 0 B
/live-video/minimal-skin 40.35 kB 40.36 kB +8 B (+0.0%) 0 B
/live-video/minimal-skin.tailwind 47.09 kB 47.08 kB -20 B (-0.0%) 0 B
/live-video/skin 40.39 kB 40.43 kB +34 B (+0.1%) 0 B
/live-video/skin.tailwind 47.03 kB 47.05 kB +22 B (+0.0%) 0 B
/live-audio/minimal-skin 29.29 kB 29.30 kB +10 B (+0.0%) 0 B
/live-audio/minimal-skin.tailwind 33.28 kB 33.26 kB -21 B (-0.1%) 0 B
/live-audio/skin 29.30 kB 29.34 kB +44 B (+0.1%) 0 B
/live-audio/skin.tailwind 33.37 kB 33.37 kB +3 B (+0.0%) 0 B
/ui/slider 12.73 kB 12.72 kB -11 B (-0.1%) 0 B
/ui/time-slider 14.15 kB 14.16 kB +12 B (+0.1%) 0 B
/ui/volume-slider 12.11 kB 12.12 kB +15 B (+0.1%) 0 B
/video (default) 48.32 kB 48.24 kB -82 B (-0.2%) 0 B
/video (default + hls) 186.33 kB 186.36 kB +29 B (+0.0%) 0 B
/video (minimal) 48.32 kB 48.34 kB +19 B (+0.0%) 0 B
/video (minimal + hls) 186.25 kB 186.21 kB -38 B (-0.0%) 0 B
/audio (default) 37.53 kB 37.58 kB +45 B (+0.1%) 0 B
/audio (minimal) 37.55 kB 37.58 kB +22 B (+0.1%) 0 B
Presets (7)
Entry Initial Lazy
/video (default) 48.24 kB 56.87 kB
/video (default + hls) 186.36 kB 56.87 kB
/video (minimal) 48.34 kB 56.87 kB
/video (minimal + hls) 186.21 kB 56.87 kB
/audio (default) 37.58 kB 56.87 kB
/audio (minimal) 37.58 kB 56.87 kB
/background 581 B 56.87 kB
Media (22)
Entry Initial
/media/mux-video/hls-js 140.61 kB
/media/mux-video/spf 27.39 kB
/media/mux-audio/hls-js 140.55 kB
/media/mux-audio/spf 21.32 kB
/media/background-video 402 B
/media/cloudflare-video 4.34 kB
/media/dash-video 210.29 kB
/media/hls-audio 20.33 kB
/media/hls-background-video 16.46 kB
/media/hls-video 26.34 kB
/media/hlsjs-video 139.44 kB
/media/mux-audio 140.56 kB
/media/mux-background-video 16.45 kB
/media/mux-video 140.54 kB
/media/native-hls-video 5.76 kB
/media/shaka-video 197.52 kB
/media/spotify-audio 4.22 kB
/media/tiktok-video 4.18 kB
/media/twitch-video 4.30 kB
/media/vimeo-video 11.19 kB
/media/wistia-video 60.05 kB
/media/youtube-video 4.86 kB
Extensions (2)
Entry Initial
/extensions/google-cast 5.34 kB
/extensions/mux-data 25.70 kB
Players (5)
Entry Initial Lazy
/video/player 7.56 kB 56.87 kB
/audio/player 4.00 kB 56.87 kB
/background/player 2.27 kB 56.87 kB
/live-video/player 6.96 kB 56.87 kB
/live-audio/player 3.99 kB 56.87 kB
Skins (26)
Entry Type Initial Lazy
/video/minimal-skin.css css 6.52 kB —
/video/skin.css css 6.35 kB —
/video/minimal-skin js 48.26 kB 56.87 kB
/video/minimal-skin.tailwind js 55.14 kB 56.87 kB
/video/skin js 48.22 kB 56.87 kB
/video/skin.tailwind js 54.95 kB 56.87 kB
/audio/minimal-skin.css css 4.81 kB —
/audio/skin.css css 4.74 kB —
/audio/minimal-skin js 37.50 kB 56.87 kB
/audio/minimal-skin.tailwind js 42.65 kB 56.87 kB
/audio/skin js 37.50 kB 56.87 kB
/audio/skin.tailwind js 42.63 kB 56.87 kB
/background/skin.css css 90 B —
/background/skin js 277 B —
/live-video/minimal-skin.css css 6.52 kB —
/live-video/skin.css css 6.35 kB —
/live-video/minimal-skin js 40.36 kB 56.87 kB
/live-video/minimal-skin.tailwind js 47.08 kB 56.87 kB
/live-video/skin js 40.43 kB 56.87 kB
/live-video/skin.tailwind js 47.05 kB 56.87 kB
/live-audio/minimal-skin.css css 4.81 kB —
/live-audio/skin.css css 4.74 kB —
/live-audio/minimal-skin js 29.30 kB 56.87 kB
/live-audio/minimal-skin.tailwind js 33.26 kB 56.87 kB
/live-audio/skin js 29.34 kB 56.87 kB
/live-audio/skin.tailwind js 33.37 kB 56.87 kB
UI Components (39)
Entry Initial Lazy
/ui/airplay-button 10.41 kB 56.87 kB
/ui/alert-dialog 4.71 kB 56.87 kB
/ui/audio-track 7.93 kB 56.87 kB
/ui/audio-track-radio-group 9.10 kB 56.87 kB
/ui/buffering-indicator 7.77 kB 56.87 kB
/ui/captions-button 10.39 kB 56.87 kB
/ui/captions-radio-group 9.21 kB 56.87 kB
/ui/cast-button 10.39 kB 56.87 kB
/ui/controls 7.55 kB 56.87 kB
/ui/dialog 4.73 kB 56.87 kB
/ui/error-dialog 11.77 kB 56.87 kB
/ui/fullscreen-button 10.36 kB 56.87 kB
/ui/gesture 7.99 kB 56.87 kB
/ui/hotkey 8.38 kB 56.87 kB
/ui/live-button 8.76 kB 56.87 kB
/ui/menu 18.90 kB 56.87 kB
/ui/mute-button 10.40 kB 56.87 kB
/ui/pip-button 10.35 kB 56.87 kB
/ui/play-button 10.35 kB 56.87 kB
/ui/playback-rate 7.99 kB 56.87 kB
/ui/playback-rate-button 10.34 kB 56.87 kB
/ui/playback-rate-radio-group 9.14 kB 56.87 kB
/ui/popover 8.13 kB 56.87 kB
/ui/poster 7.54 kB 56.87 kB
/ui/quality 8.42 kB 56.87 kB
/ui/quality-radio-group 9.59 kB 56.87 kB
/ui/seek-button 10.37 kB 56.87 kB
/ui/seek-indicator 11.95 kB 56.87 kB
/ui/slider 12.72 kB 56.87 kB
/ui/status-announcer 10.06 kB 56.87 kB
/ui/status-indicator 12.26 kB 56.87 kB
/ui/thumbnail 8.71 kB 56.87 kB
/ui/time 9.74 kB 56.87 kB
/ui/time-slider 14.16 kB 56.87 kB
/ui/title 7.24 kB 56.87 kB
/ui/tooltip 8.90 kB 56.87 kB
/ui/volume-indicator 12.32 kB 56.87 kB
/ui/volume-popover 14.17 kB 56.87 kB
/ui/volume-slider 12.12 kB 56.87 kB
🧩 @videojs/core — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
. 13.02 kB 13.08 kB +62 B (+0.5%) —
Entries (76)
Entry Initial Lazy
. 13.08 kB —
/dom 22.42 kB 56.87 kB
/vjsc 1.74 kB —
/i18n 3.23 kB 56.87 kB
/i18n/locales/all 34.97 kB —
/i18n/locales/ar 1.22 kB —
/i18n/locales/az 1.09 kB —
/i18n/locales/bg 1.29 kB —
/i18n/locales/bn 1.23 kB —
/i18n/locales/bs 1.00 kB —
/i18n/locales/ca 1.07 kB —
/i18n/locales/cs 1.07 kB —
/i18n/locales/cy 1.02 kB —
/i18n/locales/da 1006 B —
/i18n/locales/de 1.09 kB —
/i18n/locales/el 1.49 kB —
/i18n/locales/en 785 B —
/i18n/locales/es 1018 B —
/i18n/locales/et 1.05 kB —
/i18n/locales/eu 1.03 kB —
/i18n/locales/fa 1.22 kB —
/i18n/locales/fi 1.04 kB —
/i18n/locales/fr 1.07 kB —
/i18n/locales/gd 1.10 kB —
/i18n/locales/gl 1022 B —
/i18n/locales/he 1.14 kB —
/i18n/locales/hi 1.30 kB —
/i18n/locales/hr 1.02 kB —
/i18n/locales/hu 1.10 kB —
/i18n/locales/id 919 B —
/i18n/locales/it 1.01 kB —
/i18n/locales/ja 1.18 kB —
/i18n/locales/ko 1.14 kB —
/i18n/locales/lt 1.02 kB —
/i18n/locales/lv 1.09 kB —
/i18n/locales/mr 1.30 kB —
/i18n/locales/nb 987 B —
/i18n/locales/ne 1.29 kB —
/i18n/locales/nl 1.00 kB —
/i18n/locales/nn 987 B —
/i18n/locales/oc 1.08 kB —
/i18n/locales/pl 1.14 kB —
/i18n/locales/pt 1.03 kB —
/i18n/locales/pt-BR 1.03 kB —
/i18n/locales/pt-PT 1.01 kB —
/i18n/locales/ro 1.07 kB —
/i18n/locales/ru 1.40 kB —
/i18n/locales/sk 1.10 kB —
/i18n/locales/sl 1.04 kB —
/i18n/locales/sr 1.07 kB —
/i18n/locales/sv 1.01 kB —
/i18n/locales/te 1.32 kB —
/i18n/locales/th 1.29 kB —
/i18n/locales/tr 1.08 kB —
/i18n/locales/uk 1.41 kB —
/i18n/locales/vi 1.11 kB —
/i18n/locales/zh 1.02 kB —
/i18n/locales/zh-CN 1.02 kB —
/i18n/locales/zh-TW 1.02 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 280 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 1.05 kB
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.72 kB
/html 703 B
/react 365 B
🔧 @videojs/utils — no changes
Entries (13)
Entry Initial
/array 271 B
/dom 5.02 kB
/events 320 B
/function 386 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 976 B
/number 199 B

📦 @videojs/media

Path Base initial PR initial Initial diff Lazy diff
/dom/dash 209.83 kB 3.28 kB -206.54 kB (-98.4%) —
/dom/wistia 60.09 kB 1.89 kB -58.20 kB (-96.9%) —
Entries (23)
Entry Initial
. 1.07 kB
/dom 121 B
/dom/dash 3.28 kB
/dom/wistia 1.89 kB
/dom/audio-host 1.10 kB
/dom/cloudflare 3.69 kB
/dom/custom-media-element 2.13 kB
/dom/dash 209.83 kB
/dom/google-cast 4.06 kB
/dom/hls-js 139.16 kB
/dom/media-host 1.20 kB
/dom/media-played-ranges 576 B
/dom/mux 162.88 kB
/dom/native-hls 5.25 kB
/dom/shaka 197.02 kB
/dom/spotify 3.58 kB
/dom/tiktok 3.57 kB
/dom/twitch 3.62 kB
/dom/video-host 1.39 kB
/dom/vimeo 10.62 kB
/dom/wistia 60.09 kB
/dom/youtube 4.25 kB
/media-tracks 2.05 kB
📦 @videojs/spf — no changes
Entries (10)
Entry Initial
. 4.55 kB
/dom 6.60 kB
/hls 22.06 kB
/media-tracks 504 B
/hls-background-video 15.89 kB
/hls-audio 19.82 kB
/hls-video 25.85 kB
/mux-audio 20.76 kB
/mux-background-video 15.89 kB
/mux-video 26.67 kB

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

@luwes luwes closed this Oct 21, 2026

This branch was successfully deployed

1 active deployment
Preview — 8252f4d9 Deployed Sep 2, 2026 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants