This repository was archived by the owner on Oct 21, 2026. It is now read-only.
Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — 59 small size changes
Presets (7)
Media (18)
Extensions (2)
Players (5)
Skins (29)
UI Components (50)
⚛️ @videojs/react — no changesPresets (7)
Media (22)
Extensions (2)
Players (5)
Skins (26)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — 1 small size change
Entries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/media
Entries (23)
📦 @videojs/spf — no changesEntries (10)
ℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Selector-backed PlayerController instances kept the StoreController they registered on first connect and never removed it, so every reconnect stacked another controller and the orphaned SnapshotController resubscribed to the previous store. Provider replacement while connected was ignored because the controller only connected when its store was unset. Own one durable SnapshotController instead and retarget it from the subscribing context callback. SnapshotController.track() is now idempotent and connection-aware, and untrack() suspends a subscription when the provider clears its value. Refs #2360 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Popup, tooltip, menu, and dialog roots create DOM-bound imperative APIs per connection. The popover never destroyed the previous instance, so each reconnect leaked listeners; the tooltip, menu, and dialogs had no destroyCallback, so destroy() while connected left the API live; and no root re-applied its open (or current error) state after a reconnect because willUpdate only syncs on an `open` change and reconnecting schedules no update. Tear each connection down in one private dispose method that both disconnectedCallback and destroyCallback call, and replay the held open state into the recreated API through a shared RestoreGuard so the replay emits no duplicate open-change event. SnapshotController gains hostDestroyed(), which DestroyMixin invokes, so elements no longer need to release their snapshot controllers by hand. Refs #2366 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mihar-22
force-pushed
the
fix/html-popup-reconnect
branch
from
September 2, 2026 20:40
78b72ec to
8d0a3b9
Compare
Member
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs videojs/video.js#9462
Depends on #2318 (stacked on
fix/html-player-rebinding, which supplies the idempotentSnapshotController.track()this change builds on).Summary
Re-implementation of the original branch on top of the current
main(the previous version referenced menu internals and anAlertDialogElementimplementation that no longer exist). Popup, tooltip, menu, and dialog roots now own their imperative APIs strictly per DOM connection: each connection creates the API, bothdisconnectedCallbackanddestroyCallbacktear it down through the same private dispose method, and a reconnect silently replays the open (or current error) state without emitting a duplicateopen-change.Bugs fixed, all confirmed on
main:PopoverElementrecreatedcreatePopover()on every connect but only destroyed it indestroyCallback, so every reconnect leaked a live API and its listeners.TooltipElement,MenuElement,DialogElementBase(DialogElement,AlertDialogElement), andErrorDialogElementdestroyed per connection but had nodestroyCallback, sodestroy()while connected left the API and its trigger/document listeners live.open(or the current error) after a reconnect:willUpdateonly syncs whenchanged.has('open'), and reconnecting schedules no update.Changes
packages/store:SnapshotController.hostDestroyed()releases the subscription permanently and ignores laterhostConnected()/track()calls.DestroyMixin.destroyCallback()already invokeshostDestroyed()on tracked controllers, so elements no longer release snapshot controllers by hand.packages/html/src/ui/restore-guard.ts: small sharedRestoreGuardthat suppresses change notifications while an element replays state it already holds into a recreated API. Popover, tooltip, and dialog roots checkactiveinsideonOpenChangeand wrap the replay inrun(). The menu commits throughMenuApi.syncOpen(), which already bypasses the cancelable open-change request, and the error dialog reopens fromwillUpdate, so neither needs the guard.#disposeConnection()(trigger cleanup, lock release, abort controllers, API destroy) called fromdisconnectedCallbackanddestroyCallback; the dispose is idempotent because a destroyed element may still be removed from the DOM afterwards.connectedCallbackreplays the held open state afterhasUpdatedand callsrequestUpdate()so attributes, the Popover API show/hide, trigger ARIA, and positioning are refreshed for the new connection.Testing
pnpm exec vp run @videojs/store#buildandpnpm exec vp run @videojs/html#build, thenpnpm typecheckfrom a cleantsgo --build: pass (0 errors)pnpm -F @videojs/store test: 134 passedpnpm -F @videojs/html test: 462 passed;create-i18n.test.ts > updates media-text when html lang changesfails intermittently (2 of 3 isolated runs) in a file this branch does not touch and whose code uses neitherSnapshotControllernortrack(), so it is unrelatedopen-changeforPopoverElement,TooltipElement,MenuElement,DialogElement, andErrorDialogElement;hostDestroyed()forSnapshotController. Swapping the element sources back to the base branch makes 8 of the 10 new element tests fail (the error-dialog restore already passes on base when a player provider is present because its context consumer requests an update on reconnect).pnpm lint:fix:fileon touched files: no errors; remaining anti-slop notes are pre-existing casts in the test files and one justifiedas unknown asin the new error-dialog test provider