Repository navigation
fix: update node, regenerate the lockfile and run the audit pass - #197
Merged
Merged
Conversation
npm 6 ignores the `overrides` field. npm 11 kept the resolved versions. It also installs `@babel/cli` automatically, because `@videojs/babel-config` declares it as a peer dependency. The `engines` value is the same as in video.js.
npm 7 and later do not add CHANGELOG.md to the package automatically. The releases made with npm 6 included it.
GitHub stops all jobs that use `actions/cache@v2`, so CI fails before the tests start. `actions/setup-node` now does the npm cache. GitHub deprecated the old action runtimes. Headless browsers do not need xvfb.
All versions stay inside the declared ranges. The lockfile now resolves fixed runtime versions of `@babel/runtime` and `min-document`.
Karma 5 depends on vulnerable `socket.io`, `engine.io` and `ua-parser-js` versions. With karma 5, some local runs reported fewer than 171 tests and did not fail. `videojs-generate-karma-config` 8.1 is the release of the shared config for karma 6.
`rollup` 2.79.2 and earlier have a DOM clobbering vulnerability. `rollup-plugin-terser` requires `serialize-javascript` 4.x, which has a known vulnerability. The override forces a fixed version.
Version 2 brings `doctoc` 1, which depends on vulnerable `underscore` and `trim` versions. Husky 7 ignores the hooks in `package.json`. Without `.husky/pre-commit` and the `prepare` script, the pre-commit hook stops silently. Version 3 removes `conventional-changelog-cli` and `not-prerelease`, so the changelog scripts use `vjs-update-changelog`. The changelog output does not change. `vjsverify` 3 cannot parse the `npm pack --json` output when `prepare` writes to stdout. Without `videojs-generator-verify` 4, `prepublishOnly` fails.
`conventional-changelog-cli` 2 uses `tempfile` 3, which depends on a vulnerable `uuid` version. `tempfile` only calls `uuid.v4()`, and `uuid` 11 keeps that function.
`videojs-standard` 8 uses eslint 5, which depends on vulnerable `flatted`, `tmp` and `trim` versions. video.js and mpd-parser already use version 9. The lint result does not change.
CI jobs hang on BrowserStack until GitHub cancels them. Without the BrowserStack env, karma detects the local browsers of the runner. Chromium cannot start on ubuntu-latest and Safari is not headless, so the config removes them.
spuppo-mux
approved these changes
Oct 28, 2026
Essk
approved these changes
Oct 29, 2026
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
m3u8-parser still uses Node 10 and a v1 lockfile, so a new release needs a toolchain update first. The steps are the same as in videojs/video.js#9231 and videojs/video.js#9232:
CI on
maindoes not run at the moment. GitHub stops all jobs that useactions/cache@v2in "Set up job", so all recent PRs show a failed check. After that fix, thecijob waits for BrowserStack sessions that do not start, until GitHub cancels the job after 6 hours.Before, using
v10.24.16.14.12npm auditshowed:npm 11 counts vulnerabilities per package, not per path. With npm 11, the same lockfile shows
83 vulnerabilities (9 low, 15 moderate, 47 high, 12 critical).Now, using
v24.21.011.19.0npm auditshows19 vulnerabilities (7 moderate, 12 high). Two advisories cause all of them, and neither advisory has a patched release. Both affect only dev dependencies.The runtime dependency ranges do not change. The runtime advisories in
@babel/runtimeandmin-documenthave fixes inside the current ranges.Replaces #196 with the same rollup update. This PR also repairs CI.
Specific Changes proposed
Each commit passes lint, the build, karma, the node tests and
prepublishOnlyby itself..nvmrc, CI andengines. Theenginesvalue is the same as in video.js.overridesfield.CHANGELOG.mdtofilesinpackage.json. npm 7 and later do not add it to the package automatically, but the releases made with npm 6 included it.actions/cache@v2.actions/cache@v2.actions/setup-nodenow does the npm cache.npm audit fix. Result:40 vulnerabilities (6 low, 10 moderate, 21 high, 3 critical)karmato 6 andvideojs-generate-karma-configto 8.1. Karma 5 depends on vulnerablesocket.io,engine.ioandua-parser-jsversions.rollupto^2.80.0and added an override forserialize-javascript.rollup-plugin-terserrequiresserialize-javascript4.x, which has a known vulnerability. The override forces a fixed version.@videojs/generator-helpersto 3.2. Version 2 bringsdoctoc1, which depends on vulnerableunderscoreandtrimversions.package.json. The pre-commit hook moved to.husky/pre-commit, and thepreparescript installs it.conventional-changelog-cliandnot-prerelease. Theversionandupdate-changelogscripts now usevjs-update-changelog.vjsverify3 cannot parse thenpm pack --jsonoutput whenpreparewrites to stdout.videojs-generator-verify4 keepsprepublishOnlyworking.uuid.conventional-changelog-cli2 usestempfile3, which depends on a vulnerableuuidversion.tempfileonly callsuuid.v4(), anduuid11 keeps that function.videojs-standardto 9.1. Version 8 uses eslint 5, which depends on vulnerableflatted,tmpandtrimversions.BROWSER_STACK_*env from thecijob, so karma runs the local headless browsers of the runner. The change is the same as chore(ci): run karma on local headless browsers instead of BrowserStack http-streaming#1612 and chore(ci): run karma on local headless browsers instead of BrowserStack mux.js#453.scripts/karma.conf.jsremoves Chromium and Safari from the detected browsers. Chromium cannot start onubuntu-latest, and Safari is not headless.Built files:
mainis byte identical to the published m3u8-parser 7.2.0 package.dist/m3u8-parser.cjs.jsanddist/m3u8-parser.es.jshave only format differences from a newer Babel. Their ASTs are identical.dist/m3u8-parser.jsanddist/m3u8-parser.min.jsinclude theextendshelper from@babel/runtime. That helper is now the 7.29 version. The parser code does not change.npm pack --dry-rungives the same file list as the published m3u8-parser 7.2.0 package.Follow-up items:
karma,lint-staged,@babel/cliandes-check.videojs-standard.videojs-standardrelease with a newer eslint.ubuntu-latest, try the AppArmor step from chore(package): bump rollup to ^2.80.0 to fix DOM clobbering vulnerability #196.Requirements Checklist