Repository navigation
fix: update node, regenerate the lockfile and run the audit pass - #91
Merged
Merged
Conversation
npm 11 kept the resolved versions. It also installs `@babel/cli` automatically, because `@videojs/babel-config` declares it as a peer dependency. The `engines` value is the same as in video.js.
npm 7 and later do not add CHANGELOG.md to the package automatically. The releases made with npm 6 included it.
The old actions use the node12 runtime, which GitHub no longer supports. GitHub stops each job that uses `actions/cache@v2`, so `setup-node` now caches the npm files. Chrome headless cannot start on ubuntu-24.04 while AppArmor restricts unprivileged user namespaces. Headless browsers do not need xvfb.
All versions stay inside the declared ranges. The lockfile now resolves fixed runtime versions of `@babel/runtime` and `min-document`.
Karma 5 depends on vulnerable `socket.io`, `engine.io` and `ua-parser-js` versions. `videojs-generate-karma-config` 8.1 also updates `karma-coverage` to 2.
`rollup` 2.79.2 and earlier have a DOM clobbering vulnerability. `rollup-plugin-terser` requires `serialize-javascript` 4.x, which has a known vulnerability. The override forces a fixed version.
Version 8 uses eslint 5 and `eslint-plugin-markdown` 1, which depend on vulnerable `flatted` and `inquirer` versions. Version 9 uses eslint 7, the same as in video.js. The lint result does not change.
Version 2 brings `doctoc` 1, which depends on vulnerable `underscore` and `trim` versions. Husky 7 ignores the hooks in `package.json`. Without `.husky/pre-commit` and the `prepare` script, the pre-commit hook stops silently. Version 3 removes `conventional-changelog-cli` and `not-prerelease`, so the changelog scripts use `vjs-update-changelog`. The changelog output does not change. `vjsverify` 3 cannot parse the `npm pack --json` output when `prepare` writes to stdout. Without `videojs-generator-verify` 4, `prepublishOnly` fails.
`conventional-changelog-cli` 2 uses `tempfile` 3, which depends on a vulnerable `uuid` version. `tempfile` only calls `uuid.v4()`, and `uuid` 11 keeps that function.
The CI job stops in "run npm test" because the BrowserStack sessions do not start. Without the BrowserStack env vars, karma uses the local browsers of the runner. Local Safari and Chromium launchers are removed from the detected list. The BrowserStack launchers do not change.
spuppo-mux
reviewed
Oct 28, 2026
| - name: checkout code | ||
| uses: actions/checkout@v2 | ||
| - name: Disable apparmor, which breaks chromium headless | ||
| run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0 |
There was a problem hiding this comment.
note(non-blocking): this may no longer be needed
spuppo-mux
approved these changes
Oct 28, 2026
Essk
approved these changes
Oct 29, 2026
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
aes-decrypter still uses Node 10 and a v1 lockfile, so a new release needs a toolchain update first. The steps are the same as in videojs/video.js#9231 and videojs/video.js#9232:
Before, using
v10.24.16.14.12npm auditshowed:npm 11 counts vulnerabilities per package, not per path. With npm 11, the same lockfile shows
82 vulnerabilities (9 low, 16 moderate, 46 high, 11 critical).Now, using
v24.21.011.19.0npm auditshows19 vulnerabilities (7 moderate, 12 high). Two advisories cause all of them, and neither advisory has a patched release. Both affect only dev dependencies.The runtime dependency ranges do not change. The runtime advisories in
@babel/runtimeandmin-documenthave fixes inside the current ranges.npm audit --omit=devshows 0 vulnerabilities.CI cannot run on main now. GitHub stops each job that uses
actions/cache@v2at job setup.Replaces #90 with the same rollup update and the same AppArmor step in CI.
Specific Changes proposed
Each commit passes lint, the build, karma and
prepublishOnlyby itself..nvmrcandengines. Theenginesvalue is the same as in video.js.CHANGELOG.mdtofilesinpackage.json. npm 7 and later do not add it to the package automatically, but the releases made with npm 6 included it.actions/cache@v2step.setup-nodenow caches the npm files.npm audit fix. Result:40 vulnerabilities (6 low, 10 moderate, 21 high, 3 critical)karmato 6. Karma 5 depends on vulnerablesocket.io,engine.ioandua-parser-jsversions.videojs-generate-karma-config8.1 also updateskarma-coverageto 2.rollupto^2.80.0and added an override forserialize-javascript.rollup-plugin-terserrequiresserialize-javascript4.x, which has a known vulnerability. The override forces a fixed version.videojs-standardto 9. Version 8 uses eslint 5 andeslint-plugin-markdown1, which depend on vulnerableflattedandinquirerversions.@videojs/generator-helpersto 3.2. Version 2 bringsdoctoc1, which depends on vulnerableunderscoreandtrimversions.package.json. The pre-commit hook moved to.husky/pre-commit, and thepreparescript installs it.conventional-changelog-cliandnot-prerelease. Theversionandupdate-changelogscripts now usevjs-update-changelog.vjsverify3 cannot parse thenpm pack --jsonoutput whenpreparewrites to stdout.videojs-generator-verify4 keepsprepublishOnlyworking.uuid.conventional-changelog-cli2 usestempfile3, which depends on a vulnerableuuidversion.tempfileonly callsuuid.v4(), anduuid11 keeps that function.run npm testuntil GitHub cancels it after 6 hours.BROWSER_STACK_*env vars from the ci job. Thenvideojs-generate-karma-configuses the local Chrome and Firefox of the runner.scripts/karma.conf.jsremoves the local Safari and Chromium launchers from the detected list. Local Safari needs AppleScript permission, and Chromium only repeats the Chrome tests.Built files:
dist/aes-decrypter.min.jsis byte identical to the build from main.@videojs/vhs-utilsandpkcs7are still external in each bundle.npm pack --dry-rungives the same file list as the published aes-decrypter 4.0.2 package.Follow-up items:
karma,lint-staged,@babel/cliandes-check.videojs-standard.videojs-standardrelease with a newer eslint.globaldependency. It is a runtime change, so it is not in this PR.Requirements Checklist