Repository navigation
fix: report symlinks skipped by build and scan walks - #400
Merged
Merged
Conversation
Directory and file symlinks are not followed, so a link that points at its parent cannot hang vg build or vg scan. Print one stderr notice when a walk skips any, without changing output files or the exit code. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Crowers <crowers@users.noreply.github.com>
Co-authored-by: Crowers <crowers@users.noreply.github.com> Signed-off-by: Cursor Agent <cursoragent@cursor.com>
Walks still do not follow symlinks. When any are skipped, one stderr notice lists the count and the first few root-relative paths. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Crowers <crowers@users.noreply.github.com>
vibgrate-team
marked this pull request as ready for review
October 8, 2026 21:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vgnever follows symlinks while walking a tree. This makes that behaviour explicit and visible: discovery and the scan indexing walk skip symlinks, and a single stderr line names what was skipped:Exit codes and scan results are unchanged.
DOCS.mdandCHANGELOG.mddescribe the behaviour, andtest/symlink-walk.test.tslocks in no-follow (including cycles) and the notice text.Related issues
Closes #271
Checklist
How to verify