Repository navigation
fix(scan): stable SARIF partialFingerprints for drift findings - #398
Merged
Merged
Conversation
Drift results from vg scan --format sarif omitted partialFingerprints unless a baseline suppression was attached, so code scanning could not match unchanged alerts across runs. Every result now sets vg/finding-id/v1 from finding content. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Crowers <crowers@users.noreply.github.com>
Co-authored-by: Crowers <crowers@users.noreply.github.com>
Drift fingerprints reuse the baseline-suppression content id when a finding is identified by its rule and location. Vulnerability results add ecosystem, package, advisory id, and a package URL when the finding has one. Major-lag results use the package or framework name, so a newer count does not change the id. Message text is unchanged. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Crowers <crowers@users.noreply.github.com>
Signed-off-by: Cursor Agent <cursoragent@cursor.com> # Conflicts: # CHANGELOG.md Co-authored-by: Crowers <crowers@users.noreply.github.com>
vibgrate-team
marked this pull request as ready for review
October 8, 2026 21:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SARIF results now carry a stable
partialFingerprints["vg/finding-id/v1"]so code-scanning tools can track the same finding across runs:DOCS.md,README.md, andCHANGELOG.mddescribe the fingerprint contract.Related issues
Closes #275
Checklist
How to verify