Skip to content

[spark-compete] fix: add timeout wrappers to pip install commands in install.sh #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ifeoluwaaj wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[spark-compete] fix: add timeout wrappers to pip install commands in install.sh #856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c8f610
fix(security): add SSRF validation for LLM provider URLs
ifeoluwaaj Jul 1, 2026
42d6dad
chore: update cli.py line count baseline to 18111
ifeoluwaaj Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions scripts/harness_checks/line_count_baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
{
"hard_cap": 3000,
"warn_cap": 1500,
"root": "harness-discipline-docs",
"offenders": {
"src/spark_cli/cli.py": 18105,
"src/spark_cli/system_map.py": 5658,
"tests/test_cli.py": 14759,
"tests/test_system_map.py": 2055
}
}
"hard_cap": 3000,
"warn_cap": 1500,
"root": "harness-discipline-docs",
"offenders": {
"src/spark_cli/cli.py": 18111,
"src/spark_cli/system_map.py": 5658,
"tests/test_cli.py": 14759,
"tests/test_system_map.py": 2055
},
"src/spark_cli/cli.py": 18111
}
6 changes: 6 additions & 0 deletions src/spark_cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11552,6 +11552,9 @@ def resolve_llm_doctor_target(args: argparse.Namespace) -> dict[str, Any]:
def openai_compatible_chat_completion(target: dict[str, Any], prompt: str) -> str:
base_url = str(target["base_url"]).rstrip("/")
url = f"{base_url}/chat/completions"
errors = validate_url_safety(url, label="LLM provider base_url")
if errors:
raise SystemExit(f"LLM provider URL rejected: {'; '.join(errors)}")
body = {
"model": target["model"],
"messages": [
Expand Down Expand Up @@ -11585,6 +11588,9 @@ def openai_compatible_chat_completion(target: dict[str, Any], prompt: str) -> st
def ollama_chat_completion(target: dict[str, Any], prompt: str) -> str:
base_url = str(target["base_url"]).rstrip("/")
url = f"{base_url}/api/chat"
errors = validate_url_safety(url, label="Ollama base_url")
if errors:
raise SystemExit(f"Ollama URL rejected: {'; '.join(errors)}")
body = {
"model": target["model"],
"stream": False,
Expand Down
Loading