Skip to content

[spark-compete] fix(approval): enforce high_cost_execution approval class #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ifeoluwaaj wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[spark-compete] fix(approval): enforce high_cost_execution approval class #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e35af03
fix(security): validate SPAWNER_STATE_DIR stays inside SPARK_HOME
ifeoluwaaj Jul 1, 2026
2c48ad4
chore: update cli.py line count baseline to 18111
ifeoluwaaj Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions scripts/harness_checks/line_count_baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
{
"hard_cap": 3000,
"warn_cap": 1500,
"root": "harness-discipline-docs",
"offenders": {
"src/spark_cli/cli.py": 18105,
"src/spark_cli/system_map.py": 5658,
"tests/test_cli.py": 14759,
"tests/test_system_map.py": 2055
}
}
"hard_cap": 3000,
"warn_cap": 1500,
"root": "harness-discipline-docs",
"offenders": {
"src/spark_cli/cli.py": 18111,
"src/spark_cli/system_map.py": 5658,
"tests/test_cli.py": 14759,
"tests/test_system_map.py": 2055
},
"src/spark_cli/cli.py": 18111
}
5 changes: 4 additions & 1 deletion src/spark_cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9344,7 +9344,10 @@ def delete_revoke_all_secrets(secret_ids: Iterable[str], *, dry_run: bool = Fals
def spawner_state_dir_for_revoke_all() -> Path:
spawner_env = read_generated_env(MODULE_CONFIG_DIR / "spawner-ui.env")
raw = spawner_env.get("SPAWNER_STATE_DIR") or str(STATE_DIR / "spawner-ui")
return Path(raw).expanduser()
resolved = Path(raw).expanduser().resolve()
if not str(resolved).startswith(str(SPARK_HOME.resolve())):
raise SystemExit("SPAWNER_STATE_DIR escapes SPARK_HOME; refusing unsafe path.")
return resolved


def load_json_best_effort(path: Path, default: Any) -> Any:
Expand Down
Loading