Skip to content

RSDK-11731 — Remove GetImage, Format, and RenderFrame from camera.proto#758

Merged
hexbabe merged 2 commits intoviamrobotics:mainfrom
hexbabe:RSDK-11731
Mar 23, 2026
Merged

RSDK-11731 — Remove GetImage, Format, and RenderFrame from camera.proto#758
hexbabe merged 2 commits intoviamrobotics:mainfrom
hexbabe:RSDK-11731

Conversation

@hexbabe
Copy link
Copy Markdown
Contributor

@hexbabe hexbabe commented Oct 1, 2025 •
edited
Loading

https://viam.atlassian.net/browse/RSDK-11731

Hit merge only as the LAST step of removing GetImage. Make sure literally everything else is updated.

@github-actions github-actions Bot added the safe to test committer is a member of this org label Oct 1, 2025
@hexbabe hexbabe added the allow breaking Allow breaking changes by bypassing the buf-breaking check label Oct 1, 2025
seanavery
seanavery approved these changes Nov 3, 2025
View reviewed changes
Comment thread proto/viam/component/camera/v1/camera.proto

import "common/v1/common.proto";
import "google/api/annotations.proto";
import "google/api/httpbody.proto";
Copy link
Copy Markdown
Member

@seanavery seanavery Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have http hooks right? Is this being pulled in from common?

Copy link
Copy Markdown
Contributor Author

@hexbabe hexbabe Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think this is just an unused import since we no longer use HttpBody

@hexbabe hexbabe added safe to test committer is a member of this org ready-for-protos add this when you want protos to compile on every commit allow breaking Allow breaking changes by bypassing the buf-breaking check and removed safe to test committer is a member of this org allow breaking Allow breaking changes by bypassing the buf-breaking check labels Dec 12, 2025
@hexbabe hexbabe removed the ready-for-protos add this when you want protos to compile on every commit label Dec 12, 2025
@hexbabe hexbabe added the ready-for-protos add this when you want protos to compile on every commit label Mar 17, 2026
@hexbabe hexbabe removed the ready-for-protos add this when you want protos to compile on every commit label Mar 17, 2026
hexbabe added a commit to viamrobotics/viam-python-sdk that referenced this pull request Mar 17, 2026
@hexbabe @claude
RSDK-13626: Remove GetImage, RenderFrame, and Format from camera prot…
4bbd257 
…o exports

Pre-emptive removal ahead of viamrobotics/api#758 which deletes these RPCs
and the Format enum from camera.proto. Removes deleted symbols from
__init__.py re-exports and dead GetImage/RenderFrame stubs from service.py.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hexbabe added a commit to viamrobotics/viam-cpp-sdk that referenced this pull request Mar 17, 2026
@hexbabe @claude
RSDK-13626: Remove GetImage and RenderFrame from camera server
91f2ce2 
Pre-emptive removal ahead of viamrobotics/api#758 which deletes these RPCs
from camera.proto. Both were already returning UNIMPLEMENTED.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hexbabe added a commit to viamrobotics/viam-flutter-sdk that referenced this pull request Mar 17, 2026
@hexbabe @claude
RSDK-13626: Remove getImage and renderFrame from camera service
2376ac5 
Pre-emptive removal ahead of viamrobotics/api#758 which deletes these RPCs
from camera.proto. Both were already throwing UnimplementedError.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hexbabe added a commit to viamrobotics/viam-java-sdk that referenced this pull request Mar 17, 2026
@hexbabe @claude
RSDK-13626: Remove getImage, Format helpers, and format field usage
2a22c0b 
Pre-emptive removal ahead of viamrobotics/api#758 which deletes GetImage,
RenderFrame, and the Format enum from camera.proto. Removes:
- getImage abstract method and mimeToFormat/formatToMime from Camera.java
- getImage implementation from CameraRPCClient.java
- getImage handler and deleted type imports from CameraRPCService.java
- Format import from Media.kt; switches Image.dimensions to use mimeType

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 17, 2026
Closed
Merged
Merged
Merged
hexbabe added a commit to viamrobotics/viam-cpp-sdk that referenced this pull request Mar 18, 2026
@hexbabe @claude
RSDK-13626: Remove GetImage and RenderFrame from camera server
9ab7051 
Pre-emptive removal ahead of viamrobotics/api#758 which deletes these RPCs
from camera.proto. Both were already returning UNIMPLEMENTED.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hexbabe added a commit to viamrobotics/viam-java-sdk that referenced this pull request Mar 19, 2026
@hexbabe @claude
RSDK-13626: Remove getImage, Format helpers, and format field usage
994e80a 
Pre-emptive removal ahead of viamrobotics/api#758 which deletes GetImage,
RenderFrame, and the Format enum from camera.proto. Removes:
- getImage abstract method and mimeToFormat/formatToMime from Camera.java
- getImage implementation from CameraRPCClient.java
- getImage handler and deleted type imports from CameraRPCService.java
- Format import from Media.kt; switches Image.dimensions to use mimeType

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@hexbabe hexbabe added the ready-for-protos add this when you want protos to compile on every commit label Mar 23, 2026
@hexbabe hexbabe added ready-for-protos add this when you want protos to compile on every commit protos-compiled and removed ready-for-protos add this when you want protos to compile on every commit labels Mar 23, 2026
@hexbabe hexbabe merged commit fa67b36 into viamrobotics:main Mar 23, 2026
13 of 19 checks passed
@hexbabe hexbabe deleted the RSDK-11731 branch March 23, 2026 18:53
hexbabe added a commit to viamrobotics/viam-flutter-sdk that referenced this pull request Mar 23, 2026
@hexbabe @claude
RSDK-13626: Remove getImage and renderFrame from camera service
bec4269 
Pre-emptive removal ahead of viamrobotics/api#758 which deletes these RPCs
from camera.proto. Both were already throwing UnimplementedError.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hexbabe added a commit to viamrobotics/docs that referenced this pull request Mar 25, 2026
@hexbabe @claude
Remove GetImage, RenderFrame, and related references from docs
c66abe3 
The GetImage and RenderFrame RPCs have been removed from the camera
proto (viamrobotics/api#758). This removes all documentation references:

- Remove GetImage API section from camera docs
- Remove GetImage/RenderFrame from SDK protos map CSV
- Update example code method_name strings from "GetImage" to "GetImages"
- Update vision service TS examples to use getImages() instead of getImage()
- Clean up changelog entries to reflect removal instead of deprecation
- Remove ReadImage deprecated mention from capture-supported table
- Empty out GetImage override files

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@hexbabe hexbabe mentioned this pull request Mar 25, 2026
Merged
4 tasks
njooma pushed a commit to viamrobotics/viam-flutter-sdk that referenced this pull request Mar 30, 2026
@hexbabe @viambot @claude
RSDK-13626: Remove getImage and renderFrame from camera service (#513)
70717c6 
* [WORKFLOW] Updating protos from viamrobotics/api, commit: fa67b36870468c0ee50c12f640dfce1991e5e4b3

* RSDK-13626: Remove getImage and renderFrame from camera service

Pre-emptive removal ahead of viamrobotics/api#758 which deletes these RPCs
from camera.proto. Both were already throwing UnimplementedError.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: viambot <viambot@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanavery seanavery seanavery approved these changes

@oliviamiller oliviamiller oliviamiller approved these changes

+1 more reviewer

@SebastianMunozP SebastianMunozP SebastianMunozP approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

allow breaking Allow breaking changes by bypassing the buf-breaking check safe to test committer is a member of this org

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hexbabe @seanavery @oliviamiller @SebastianMunozP