Conversation
|
|
||
| find_package(Eigen3 CONFIG REQUIRED) | ||
| find_package(viam-cpp-sdk 0.23 CONFIG REQUIRED viamsdk) | ||
| find_package(viam-cpp-sdk 0.25 CONFIG REQUIRED viamsdk) |
There was a problem hiding this comment.
This line doesn't actually select the version of the C++ SDK we use. It just sets the minimum we will accept. We are actually already using 0.25, per:
- https://github.com/viam-modules/universal-robots/blob/main/conanfile.py#L37 (this is also a minimum), and more importantly
- https://github.com/viam-modules/universal-robots/blob/main/bin/setup.sh#L24
However, since we do actually rely on that functionality, it is probably a good idea to advance this version as well.
There was a problem hiding this comment.
Per your question on bumping higher, the latest C++ SDK release is 0.27.0, but I haven't been carefully tracking the changes. @lia-viam is there anything important for us to pick up in 0.26.0 or 0.27.0?
There was a problem hiding this comment.
I think no! Other than proto api updates it's changes that don't touch components you're working on in this repo, or don't affect your target platforms.
|
@npmenard - Are you still interested in this change? If so, looks like C++ SDK has released 0.28. |
0.28 contains the fix you submitted for the missing |
3 participants
For supporting [RSDK-12829 Provide a utility to expose client metadata within resource servers (](viamrobotics/viam-cpp-sdk@d7781f3ae234f88be39a0c6e2aaca546ddc42065)https://github.com/viamrobotics/viam-cpp-sdk/pull/515[)](https://github.com/viamrobotics/viam-cpp-sdk/commit/d7781f3ae234f88be39a0c6e2aaca546ddc42065)