Skip to content

improve path decode #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nicole00 wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

improve path decode #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6355b0d
improve path parser
Nicole00 Jan 30, 2026
599eae6
fix path decode cache
Nicole00 Feb 2, 2026
66d002f
fix fmt
Nicole00 Feb 2, 2026
58b03ab
improve int & string decode
Nicole00 Feb 6, 2026
49d0572
remove decimal test for now
Nicole00 Feb 6, 2026
cf52c64
remove decimal test for now
Nicole00 Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions client/src/main/java/com/vesoft/nebula/driver/graph/data/ValueWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import static com.vesoft.nebula.driver.graph.decode.ColumnType.COLUMN_TYPE_ZONEDTIME;

import com.vesoft.nebula.driver.graph.decode.ColumnType;
import com.vesoft.nebula.driver.graph.decode.DateFormatterConst;
import com.vesoft.nebula.driver.graph.exception.InvalidValueException;
import java.math.BigDecimal;
import java.time.LocalDate;
Expand All @@ -54,13 +55,6 @@ public class ValueWrapper {
private final Object value;
private final ColumnType type;

DateTimeFormatter zonedDateTimeFormatter =
DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSSSSSXXXXX");
DateTimeFormatter localDateTimeFormatter =
DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSSSSS");
DateTimeFormatter zonedTimeFormatter = DateTimeFormatter.ofPattern("HH:mm:ss.SSSSSSXXXXX");
DateTimeFormatter localTimeFormatter = DateTimeFormatter.ofPattern("HH:mm:ss.SSSSSS");

public ValueWrapper(Object value, ColumnType type) {
this.value = value;
this.type = type;
Expand Down Expand Up @@ -727,13 +721,13 @@ public String toString() {
} else if (isEdge()) {
return asEdge().toString();
} else if (isLocalTime()) {
return asLocalTime().format(localTimeFormatter);
return asLocalTime().format(DateFormatterConst.localTimeFormatter);
} else if (isZonedTime()) {
return asZonedTime().format(zonedTimeFormatter);
return asZonedTime().format(DateFormatterConst.zonedTimeFormatter);
} else if (isLocalDateTime()) {
return asLocalDateTime().format(localDateTimeFormatter);
return asLocalDateTime().format(DateFormatterConst.localDateTimeFormatter);
} else if (isZonedDateTime()) {
return asZonedDateTime().format(zonedDateTimeFormatter);
return asZonedDateTime().format(DateFormatterConst.zonedDateTimeFormatter);
} else if (isDate()) {
return asDate().toString();
} else if (isDuration()) {
Expand Down
20 changes: 20 additions & 0 deletions client/src/main/java/com/vesoft/nebula/driver/graph/decode/DateFormatterConst.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
/* Copyright (c) 2025 vesoft inc. All rights reserved.
*
* This source code is licensed under Apache 2.0 License.
*/

package com.vesoft.nebula.driver.graph.decode;

import java.time.format.DateTimeFormatter;

public class DateFormatterConst {
public static DateTimeFormatter zonedDateTimeFormatter =
DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSSSSSXXXXX");
public static DateTimeFormatter localDateTimeFormatter =
DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSSSSS");
public static DateTimeFormatter zonedTimeFormatter =
DateTimeFormatter.ofPattern("HH:mm:ss.SSSSSSXXXXX");
public static DateTimeFormatter localTimeFormatter =
DateTimeFormatter.ofPattern("HH:mm:ss.SSSSSS");

}
239 changes: 229 additions & 10 deletions client/src/main/java/com/vesoft/nebula/driver/graph/decode/DecodeUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@

package com.vesoft.nebula.driver.graph.decode;

import static com.vesoft.nebula.driver.graph.decode.struct.SizeConstant.CHUNK_INDEX_START_POSITION_IN_STRING_HEADER;
import static com.vesoft.nebula.driver.graph.decode.struct.SizeConstant.CHUNK_OFFSET_START_POSITION_IN_STRING_HEADER;
import static com.vesoft.nebula.driver.graph.decode.struct.SizeConstant.ELEMENT_NUMBER_SIZE_FOR_ANY_VALUE;
import static com.vesoft.nebula.driver.graph.decode.struct.SizeConstant.STRING_MAX_VALUE_LENGTH_IN_HEADER;
import static com.vesoft.nebula.driver.graph.decode.struct.SizeConstant.STRING_SIZE;
import static com.vesoft.nebula.driver.graph.decode.struct.SizeConstant.STRING_VALUE_LENGTH_SIZE;

import com.google.protobuf.ByteString;
import com.vesoft.nebula.driver.graph.decode.datatype.VectorType;
Expand All @@ -18,6 +23,58 @@
public class DecodeUtils {
public static final Charset charset = Charsets.UTF_8;

/**
* decode binary to int directly from ByteString without creating sub-byteString
*
* @param data binary data
* @param offset offset in the data
* @param order byte order
* @return int value
*/
public static int bytesToInt32AtOffset(ByteString data, int offset, ByteOrder order) {
if (order == ByteOrder.LITTLE_ENDIAN) {
return (data.byteAt(offset) & 0xFF)
| ((data.byteAt(offset + 1) & 0xFF) << 8)
| ((data.byteAt(offset + 2) & 0xFF) << 16)
| ((data.byteAt(offset + 3) & 0xFF) << 24);
} else {
return (data.byteAt(offset) << 24)
| ((data.byteAt(offset + 1) & 0xFF) << 16)
| ((data.byteAt(offset + 2) & 0xFF) << 8)
| (data.byteAt(offset + 3) & 0xFF);
}
}

/**
* decode binary to long directly from ByteString without creating sub-byteString
*
* @param data binary data
* @param offset offset in the data
* @param order byte order
* @return long value
*/
public static long bytesToInt64AtOffset(ByteString data, int offset, ByteOrder order) {
if (order == ByteOrder.LITTLE_ENDIAN) {
return (long) (data.byteAt(offset) & 0xFF)
| ((long) (data.byteAt(offset + 1) & 0xFF) << 8)
| ((long) (data.byteAt(offset + 2) & 0xFF) << 16)
| ((long) (data.byteAt(offset + 3) & 0xFF) << 24)
| ((long) (data.byteAt(offset + 4) & 0xFF) << 32)
| ((long) (data.byteAt(offset + 5) & 0xFF) << 40)
| ((long) (data.byteAt(offset + 6) & 0xFF) << 48)
| ((long) (data.byteAt(offset + 7) & 0xFF) << 56);
} else {
return ((long) data.byteAt(offset) << 56)
| ((long) (data.byteAt(offset + 1) & 0xFF) << 48)
| ((long) (data.byteAt(offset + 2) & 0xFF) << 40)
| ((long) (data.byteAt(offset + 3) & 0xFF) << 32)
| ((long) (data.byteAt(offset + 4) & 0xFF) << 24)
| ((long) (data.byteAt(offset + 5) & 0xFF) << 16)
| ((long) (data.byteAt(offset + 6) & 0xFF) << 8)
| (data.byteAt(offset + 7) & 0xFF);
}
}

/**
* decode binary to byte
*
Expand All @@ -38,15 +95,43 @@ public static int bytesToUInt8(ByteString data) {
return data.byteAt(0) & 0xFF;
}

/**
* decode binary to byte at offset
*
* @param data binary data
* @param offset offset in the data
* @return int value
*/
public static int bytesToInt8AtOffset(ByteString data, int offset) {
return data.byteAt(offset);
}

/**
* decode binary to unsigned byte at offset
*
* @param data binary data
* @param offset offset in the data
* @return uint value
*/
public static int bytesToUInt8AtOffset(ByteString data, int offset) {
return data.byteAt(offset) & 0xFF;
}

/**
* decode binary to short
*
* @param data binary data
* @return short value
*/
public static Short bytesToInt16(ByteString data, ByteOrder order) {
ByteBuffer buffer = ByteBuffer.wrap(data.toByteArray());
return buffer.order(order).getShort();
if (data.size() < 2) {
throw new java.nio.BufferUnderflowException();
}
if (order == ByteOrder.LITTLE_ENDIAN) {
return (short) ((data.byteAt(0) & 0xFF) | ((data.byteAt(1) & 0xFF) << 8));
} else {
return (short) ((data.byteAt(0) << 8) | (data.byteAt(1) & 0xFF));
}
}

/**
Expand All @@ -59,15 +144,55 @@ public static int bytesToUInt16(ByteString data, ByteOrder order) {
return bytesToInt16(data, order) & 0xFFFF;
}

/**
* decode binary to unsigned short at offset
*
* @param data binary data
* @param offset offset in the data
* @param order byte order
* @return short value
*/
public static int bytesToUInt16AtOffset(ByteString data, int offset, ByteOrder order) {
return bytesToInt16AtOffset(data, offset, order) & 0xFFFF;
}

/**
* decode binary to short at offset
*
* @param data binary data
* @param offset offset in the data
* @param order byte order
* @return short value
*/
public static short bytesToInt16AtOffset(ByteString data, int offset, ByteOrder order) {
if (order == ByteOrder.LITTLE_ENDIAN) {
return (short) ((data.byteAt(offset) & 0xFF) | ((data.byteAt(offset + 1) & 0xFF) << 8));
} else {
return (short) ((data.byteAt(offset) << 8) | (data.byteAt(offset + 1) & 0xFF));
}
}

/**
* decode binary to int
*
* @param data binary data
* @return int value
*/
public static int bytesToInt32(ByteString data, ByteOrder order) {
ByteBuffer buffer = ByteBuffer.wrap(data.toByteArray());
return buffer.order(order).getInt();
if (data.size() < 4) {
throw new java.nio.BufferUnderflowException();
}
if (order == ByteOrder.LITTLE_ENDIAN) {
return (data.byteAt(0) & 0xFF)
| ((data.byteAt(1) & 0xFF) << 8)
| ((data.byteAt(2) & 0xFF) << 16)
| ((data.byteAt(3) & 0xFF) << 24);
} else {
return (data.byteAt(0) << 24)
| ((data.byteAt(1) & 0xFF) << 16)
| ((data.byteAt(2) & 0xFF) << 8)
| (data.byteAt(3) & 0xFF);
}
}


Expand All @@ -81,15 +206,109 @@ public static long bytesToUInt32(ByteString data, ByteOrder order) {
return Integer.toUnsignedLong(bytesToInt32(data, order));
}

/**
* decode binary to float at offset
*
* @param data binary data
* @param offset offset in the data
* @param order byte order
* @return float value
*/
public static float bytesToFloatAtOffset(ByteString data, int offset, ByteOrder order) {
int bits = bytesToInt32AtOffset(data, offset, order);
return Float.intBitsToFloat(bits);
}

/**
* decode binary to double at offset
*
* @param data binary data
* @param offset offset in the data
* @param order byte order
* @return double value
*/
public static double bytesToDoubleAtOffset(ByteString data, int offset, ByteOrder order) {
long bits = bytesToInt64AtOffset(data, offset, order);
return Double.longBitsToDouble(bits);
}

/**
* decode binary to bool at offset
*
* @param data binary data
* @param offset offset in the data
* @return Boolean value
*/
public static boolean bytesToBoolAtOffset(ByteString data, int offset) {
return data.byteAt(offset) == 0x01;
}

/**
* decode flat string directly from vector data at specified row
*
* @param vectorData vector data
* @param rowIndex row index
* @param order byte order
* @return String value
*/
public static String decodeFlatString(ByteString vectorData, int rowIndex, ByteOrder order) {
int offset = rowIndex * STRING_SIZE;

// Read string length
int stringValueLength = bytesToInt32AtOffset(vectorData, offset, order);

if (stringValueLength <= STRING_MAX_VALUE_LENGTH_IN_HEADER) {
// Short string: data is in the header
int dataOffset = offset + STRING_VALUE_LENGTH_SIZE;
return vectorData.substring(dataOffset, dataOffset + stringValueLength)
.toString(charset);
}

// Long string: read chunk index and offset
int chunkIndex = bytesToInt32AtOffset(
vectorData,
offset + CHUNK_INDEX_START_POSITION_IN_STRING_HEADER,
order);
int chunkOffset = bytesToInt32AtOffset(
vectorData,
offset + CHUNK_OFFSET_START_POSITION_IN_STRING_HEADER,
order);

// Note: For flat string, we can't access nested vectors without passing them
// This method is optimized for the common case where the string is short
// For long strings, fallback to the original bytesToString method
return null;
}

/**
* decode binary to long
*
* @param data binary data
* @return long value
*/
public static long bytesToInt64(ByteString data, ByteOrder order) {
ByteBuffer buffer = ByteBuffer.wrap(data.toByteArray());
return buffer.order(order).getLong();
if (data.size() < 8) {
throw new java.nio.BufferUnderflowException();
}
if (order == ByteOrder.LITTLE_ENDIAN) {
return (long) (data.byteAt(0) & 0xFF)
| ((long) (data.byteAt(1) & 0xFF) << 8)
| ((long) (data.byteAt(2) & 0xFF) << 16)
| ((long) (data.byteAt(3) & 0xFF) << 24)
| ((long) (data.byteAt(4) & 0xFF) << 32)
| ((long) (data.byteAt(5) & 0xFF) << 40)
| ((long) (data.byteAt(6) & 0xFF) << 48)
| ((long) (data.byteAt(7) & 0xFF) << 56);
} else {
return ((long) data.byteAt(0) << 56)
| ((long) (data.byteAt(1) & 0xFF) << 48)
| ((long) (data.byteAt(2) & 0xFF) << 40)
| ((long) (data.byteAt(3) & 0xFF) << 32)
| ((long) (data.byteAt(4) & 0xFF) << 24)
| ((long) (data.byteAt(5) & 0xFF) << 16)
| ((long) (data.byteAt(6) & 0xFF) << 8)
| (data.byteAt(7) & 0xFF);
}
}


Expand All @@ -100,8 +319,8 @@ public static long bytesToInt64(ByteString data, ByteOrder order) {
* @return float value
*/
public static float bytesToFloat(ByteString data, ByteOrder order) {
ByteBuffer buffer = ByteBuffer.wrap(data.toByteArray());
return buffer.order(order).getFloat();
int bits = bytesToInt32(data, order);
return Float.intBitsToFloat(bits);
}

/**
Expand All @@ -111,8 +330,8 @@ public static float bytesToFloat(ByteString data, ByteOrder order) {
* @return double value
*/
public static double bytesToDouble(ByteString data, ByteOrder order) {
ByteBuffer buffer = ByteBuffer.wrap(data.toByteArray());
return buffer.order(order).getDouble();
long bits = bytesToInt64(data, order);
return Double.longBitsToDouble(bits);
}

/**
Expand Down
Loading
Loading