[run] fix: limit lockfile conflict checks to Node.js ecosystem#21
Conversation
Previously, `run` would throw a `LockfileConflict` error if multiple tools from the same ecosystem were detected and installed. This behavior was intended for Node.js (where `package-lock.json`, `yarn.lock`, etc., indicate competing tools), but it errantly applied to other ecosystems. For example, in Ruby, a project may have both a `Gemfile.lock` and a `Rakefile` representing `bundler` and `rake`, which gracefully coexist. This commit limits the lockfile conflict logic strictly to the Node.js ecosystem, allowing other ecosystems to correctly rely on priority resolution. Co-authored-by: insign <1113045+insign@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Previously,
runwould throw aLockfileConflicterror if multiple tools from the same ecosystem were detected and installed. This behavior was originally intended to catch conflicting lockfiles in the Node.js ecosystem (e.g.package-lock.jsonandyarn.lock), where using multiple package managers is an anti-pattern. However, it erroneously applied to all ecosystems. For example, in Ruby, a project commonly features both aGemfile.lockand aRakefile, representingbundlerandrake, which naturally and gracefully coexist.This commit restricts the strict lockfile conflict check to
Ecosystem::NodeJs. In other ecosystems, tools likebundlerandrakecan now correctly be resolved via their defined priorities, resulting in a significantly more reliable task runner experience across various common project configurations.PR created automatically by Jules for task 12423709527055992849 started by @insign