Repository navigation
fix: normalize decidable instances before unfolding head conditionals - #193
Merged
Merged
Conversation
dranov
marked this pull request as ready for review
November 17, 2026 13:48
zqy1018
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actions beginning with a quantified
iffail to generatewp_local_eq, and invariant checking subsequently errors withcannot translate Type. The equality helper callswhnfbefore normalizingDecidableinstances, unfolding the leading conditional before the concrete and abstract-state expressions can be aligned.Remove the two preliminary reductions so instance normalization runs first; the subsequent definitional equality check still performs needed reductions. Add regressions for universal quantifiers with and without a type annotation, existential quantifiers, and witness-binding conditionals. Each case checks that both the local WP equality and abstract transition theorem are generated, then verifies its invariant.
Fixes #185.
Validation:
git diff --checkpassed.