Repository navigation
Conversation
dranov
marked this pull request as ready for review
November 21, 2026 04:12
dranov
marked this pull request as draft
November 21, 2026 04:38
dranov
force-pushed
the
codex/binding-shadowing-tests
branch
from
November 21, 2026 05:23
82c1504 to
76eed06
Compare
Contributor
|
Is this (together with the PRs on top of it) ready for review? |
Collaborator
Author
|
@zqy1018 Not yet, I'll ping you when it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #180.
Core problem
A ghost definition could resolve an explicit parameter to a same-named theory or state field. The definition still elaborated, so invariant checking and symbolic traces could use a different predicate from the one the author wrote.
Wider problem
User names and generated names shared the same lookup scope. A local could hide a field needed to reconstruct the state for a ghost call, and a generated binder such as
st0could hide a field in a symbolic query.This PR fixes the two remaining cases reported in #156. A theory field named
stcould break invariant elaboration, and a state field namedst'could break transition elaboration. The originalhas,hinv, andcorefixes are already onmainthrough #157 and #160.How the fix works
Simplifications
sat traceand IC3.Validation
List.foldl, and contextual typing.has,hinv, andcorecases on the PR head. Thestandst'cases fail on the pre-PR control and pass on this branch, including#check_invariants.lake --no-cache build VeilTest Examplespassed all 1,620 jobs. CI passed on Linux and macOS.