INT-4410: fix sound device never closing due to async bridge count - #18
Draft
darshan-verkada wants to merge 1 commit into
Draft
Conversation
pjsua_check_snd_dev_idle() checked pjmedia_conf_get_connect_count() when scheduling the idle timer, but bridge disconnect is async: connect_cnt is only decremented later by the conference clock thread, so the count was always stale at the scheduling site and the timer never got armed, leaving the sound device (and its realtime ALSA threads) open forever. Move the connect-count check into the timer callback, where it fires after the op queue has drained, and re-arm the timer instead of dropping it if the count is still non-zero — otherwise a declined close has no guaranteed later event to retry it. Keep the existing call_cnt <= 1 relaxation that lets the device close during an active call whose audio was handed off to LiveKit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AEfmqRvAxKXxFzPoe2pmu3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pjsua_check_snd_dev_idle() checked pjmedia_conf_get_connect_count() when scheduling the idle timer, but bridge disconnect is async: connect_cnt is only decremented later by the conference clock thread, so the count was always stale at the scheduling site and the timer never got armed, leaving the sound device (and its realtime ALSA threads) open forever.
Move the connect-count check into the timer callback, where it fires after the op queue has drained, and re-arm the timer instead of dropping it if the count is still non-zero — otherwise a declined close has no guaranteed later event to retry it. Keep the existing call_cnt <= 1 relaxation that lets the device close during an active call whose audio was handed off to LiveKit.
Claude-Session: https://claude.ai/code/session_01AEfmqRvAxKXxFzPoe2pmu3