Skip to content

fix: allow $schema key in serve.json - #865

Closed
charan-rathore wants to merge 1 commit into
vercel:mainfrom
charan-rathore:fix-schema-key
Closed

charan-rathore wants to merge 1 commit into
vercel:mainfrom
charan-rathore:fix-schema-key

Conversation

@charan-rathore

@charan-rathore charan-rathore commented Oct 1, 2026 •

Copy link
Copy Markdown

Related Issues

Description

Changed

  • Strip the top-level $schema key from serve.json before validation, so editor-added schema references no longer fail with "must NOT have additional properties". It is editor metadata, not a serve option.
  • Added tests/config-schema-key.test.ts (a config with $schema plus real options still loads the options; a $schema-only config is accepted) and a patch changeset.

Caveats/Problems/Issues

New tests fail 2 of 3 on the unpatched base and pass 3 of 3 with the change. With a serve.json containing $schema and cleanUrls: false, the compiled CLI serves HTTP 200; the unpatched build exits with the AJV error.

Checklist

  • The issues that this PR fixes/closes have been mentioned above.
  • What this PR adds/changes/removes has been explained.
  • All tests (pnpm test) pass.
  • The linter (pnpm lint) does not throw an errors.
  • All added/modified code has been commented, and
    methods/classes/constants/types have been annotated with TSDoc comments.

@vercel

vercel Bot commented Oct 1, 2026

Copy link
Copy Markdown

@charan-rathore is attempting to deploy a commit to the Internal Playground Team on Vercel.

A member of the Team first needs to authorize it.

@charan-rathore

Copy link
Copy Markdown
Author

Closing this since there has been no movement on it. Happy to reopen and pick it back up if there is interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow JSON schema property in serve.json

1 participant