Repository navigation
fix: allow $schema key in serve.json - #865
Closed
charan-rathore wants to merge 1 commit into
Closed
charan-rathore wants to merge 1 commit into
charan-rathore wants to merge 1 commit into
Conversation
|
@charan-rathore is attempting to deploy a commit to the Internal Playground Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Closing this since there has been no movement on it. Happy to reopen and pick it back up if there is interest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
serve.json#862Description
Changed
$schemakey fromserve.jsonbefore validation, so editor-added schema references no longer fail with "must NOT have additional properties". It is editor metadata, not a serve option.tests/config-schema-key.test.ts(a config with$schemaplus real options still loads the options; a$schema-only config is accepted) and a patch changeset.Caveats/Problems/Issues
New tests fail 2 of 3 on the unpatched base and pass 3 of 3 with the change. With a
serve.jsoncontaining$schemaandcleanUrls: false, the compiled CLI serves HTTP 200; the unpatched build exits with the AJV error.Checklist
pnpm test) pass.pnpm lint) does not throw an errors.methods/classes/constants/types have been annotated with TSDoc comments.