Repository navigation
Skip now.json without legacy static configuration - #864
Closed
charan-rathore wants to merge 1 commit into
Closed
charan-rathore wants to merge 1 commit into
charan-rathore wants to merge 1 commit into
Conversation
|
@charan-rathore is attempting to deploy a commit to the Internal Playground Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Closing for now since nothing has moved here. Happy to pick it back up if a maintainer wants it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
No issue filed. Found while checking the configuration loader's automatic fallback behavior.
Description
Added
Three regressions covering a deployment-style
now.jsoncontaining{"version":2}, a legacynow.staticsection, and falling through topackage.jsonstatic settings. Added README documentation and a patch changeset.Changed
The loader automatically probes
now.jsonwhen noserve.jsonexists. A valid deployment file withoutnow.staticcurrently throwsCannot read properties of undefined (reading 'static'), stopping local serving before the server starts.Make
nowoptional and skip that file if it has no static section, matching the existing package.json behavior. Existing legacy static configuration remains honored. This does not validate deployment configuration or add new deployment support.Removed
Nothing.
Caveats/Problems/Issues
Node 22.23.3, pnpm 10.33.0, repository Vitest 2.1.3:
pnpm test: TypeScript and all 31 tests pass with coverage.pnpm lintandpnpm compile: pass.Only the absent legacy section is addressed; JSON-shape validation beyond this scenario is unchanged.
Checklist
pnpm test) pass.pnpm lintpasses.