Skip to content

Skip now.json without legacy static configuration - #864

Closed
charan-rathore wants to merge 1 commit into
vercel:mainfrom
charan-rathore:fix-skip-modern-now-json
Closed

charan-rathore wants to merge 1 commit into
vercel:mainfrom
charan-rathore:fix-skip-modern-now-json

Conversation

@charan-rathore

Copy link
Copy Markdown

Related Issues

No issue filed. Found while checking the configuration loader's automatic fallback behavior.

Description

Added

Three regressions covering a deployment-style now.json containing {"version":2}, a legacy now.static section, and falling through to package.json static settings. Added README documentation and a patch changeset.

Changed

The loader automatically probes now.json when no serve.json exists. A valid deployment file without now.static currently throws Cannot read properties of undefined (reading 'static'), stopping local serving before the server starts.

Make now optional and skip that file if it has no static section, matching the existing package.json behavior. Existing legacy static configuration remains honored. This does not validate deployment configuration or add new deployment support.

Removed

Nothing.

Caveats/Problems/Issues

Node 22.23.3, pnpm 10.33.0, repository Vitest 2.1.3:

  • New tests on unchanged loader: 1 pass, 2 fail.
  • Full pnpm test: TypeScript and all 31 tests pass with coverage.
  • Full pnpm lint and pnpm compile: pass.
  • Compiled CLI started beside now.json version 2, served a fixture over HTTP with status 200 and exact content.
  • Standalone run_tests.sh passed in a second fresh clone/install, including baseline failure, full tests/lint/compile and compiled CLI proof.

Only the absent legacy section is addressed; JSON-shape validation beyond this scenario is unchanged.

Checklist

  • Related issue status stated above (none filed).
  • Added/changed/removed behavior explained.
  • All tests (pnpm test) pass.
  • pnpm lint passes.
  • Existing loader TSDoc and section-selection comment retained; optional interface type reflects supported absence.

@vercel

vercel Bot commented Oct 1, 2026

Copy link
Copy Markdown

@charan-rathore is attempting to deploy a commit to the Internal Playground Team on Vercel.

A member of the Team first needs to authorize it.

@charan-rathore

Copy link
Copy Markdown
Author

Closing for now since nothing has moved here. Happy to pick it back up if a maintainer wants it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant