Repository navigation
fix: omit network URLs for specific listeners - #859
Open
ryanchou1994 wants to merge 1 commit into
Open
ryanchou1994 wants to merge 1 commit into
ryanchou1994 wants to merge 1 commit into
Conversation
Only advertise another interface when the server binds a wildcard address. Keep loopback and specific-interface URLs accurate in the startup banner.
|
@ryanchou1994 is attempting to deploy a commit to the Internal Playground Team on Vercel. A member of the Team first needs to authorize it. |
5 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #667.
Description
Changed
A server started with
--listen tcp://localhost:3000currently advertises a LAN URL even though it only listens on loopback. Generate the extra network URL only for wildcard bindings (::or0.0.0.0). Specific bindings keep their existing local URL. Listener behavior is unchanged.Added
Regression coverage for real localhost, IPv4 and IPv6 loopback listeners, plus address fixtures for wildcard and specific interfaces. The README now documents the localhost command and banner behavior.
Caveats/Problems/Issues
Tests ran in an isolated environment with a synthetic npm update-check response and NIC metadata. HTTP/TLS traffic used local fixtures; physical LAN routing was not tested.
Checklist
pnpm testpasses on macOS and Linux: 37 tests, including TypeScript checks.pnpm lintandpnpm compilepass.startServerTSDoc is preserved.