chore(eve): keep unsigned JWT fixture out of package builds - #1739
Draft
vercel-gh-bot-5[bot] wants to merge 1 commit into
Draft
chore(eve): keep unsigned JWT fixture out of package builds#1739vercel-gh-bot-5[bot] wants to merge 1 commit into
vercel-gh-bot-5[bot] wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
main,pnpm --filter eve run clean && pnpm --filter eve run build:typesemitsdist/src/public/models/openai/chatgpt/unsigned-jwt.d.tsat 228 bytes. Repository search showscreateUnsignedJwthas three consumers, all in tests.The hypothesis is that moving this fixture to the existing
src/internal/testingboundary will preserve test behavior and exclude test-only code through the existingtsconfig.build.jsonrule.A clean full package build now emits no file matching
*unsigned-jwt*.Validation:
pnpm --filter eve exec vitest run --config vitest.unit.config.ts --maxWorkers=4(6,024 passed, 1 skipped)pnpm --filter eve typecheckpnpm --filter eve run buildpnpm guard:invariantspnpm exec oxlint <changed files> --report-unused-disable-directivespnpm exec oxfmt --check <changed files>