fix(eve): move SvelteKit example config into Vite - #1736
Open
vercel-gh-bot-2[bot] wants to merge 1 commit into
Open
fix(eve): move SvelteKit example config into Vite#1736vercel-gh-bot-2[bot] wants to merge 1 commit into
vercel-gh-bot-2[bot] wants to merge 1 commit into
Conversation
Slack username: colton.padden
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
cmpadden
approved these changes
Aug 6, 2026
cmpadden
marked this pull request as ready for review
August 6, 2026 19:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SvelteKit framework example keeps its Vercel adapter in a separate
svelte.config.js, even though SvelteKit can now read this configuration from the Vite plugin. This leaves two configuration entry points for a small example.Hypothesis
Because SvelteKit 2.63 reads inline configuration during both Vite builds and
svelte-kit sync, passing the adapter directly tosveltekit()should preserve the Vercel build while removing the extra file.This change:
adapter-verceltosveltekit()invite.config.tssvelte.config.js2.63.0; version 2.62 added inline configuration, but itssynccommand still skipped projects withoutsvelte.config.jsVerification
pnpm install --frozen-lockfilepnpm --filter framework-sveltekit typecheckafter deleting.svelte-kitpnpm --filter framework-sveltekit buildpnpm exec oxlint apps/frameworks/sveltekit/vite.config.ts --deny-warningspnpm exec oxfmt --check apps/frameworks/sveltekit/package.json apps/frameworks/sveltekit/vite.config.ts pnpm-lock.yamlpnpm check:depspnpm guard:invariantsgit diff --checkFixes #374
Requested by: colton.padden