feat(client): clarify connection authorization blocker (AX-4457) - #1734
Open
madisonho wants to merge 2 commits into
Open
feat(client): clarify connection authorization blocker (AX-4457)#1734madisonho wants to merge 2 commits into
madisonho wants to merge 2 commits into
Conversation
Signed-off-by: madisonho <madison.ho@vercel.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: madisonho <madison.ho@vercel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Connection authorization prompts now explicitly say the agent session cannot continue without the connection. Generic browser cards use “Authorize [connection] to continue this agent session,” while Slack’s public, link-free status uses “Connect with [connection] to continue this agent session”; provider-specific instructions and private Slack authorization delivery remain unchanged.
Linear: AX-4457
Validation
pnpm --filter eve exec vitest run --config vitest.unit.config.ts src/client/message-reducer.test.ts src/public/channels/slack/connections.test.ts src/public/channels/slack/defaults.test.ts(37 tests passed)pnpm fmtpnpm lintpnpm typecheckpnpm guard:invariantsChecklist
CONTRIBUTING.mdevepackagegit commit --signoff)