feat(eve): forwarding delegated subagent stream events to the parent session stream (#666) - #1725
Open
iroiro147 wants to merge 1 commit into
Open
Conversation
…session stream (vercel#666) Autosaves child turn stream events into the parent stream as durable subagent.event entries, ordering them by the child step index. Preserves the delegated subagent result unchanged for the parent's final result mapping. Signed-off-by: iroiro147 <sarthak.singh@mastersunion.org>
Contributor
|
@iroiro147 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| await input.writer.write(encodeMessageStreamEvent(stampedEvent)); | ||
|
|
||
| if (input.forwardedSubagentStream !== undefined) { | ||
| const forwardedWriter = input.forwardedSubagentStream.parentWritable.getWriter(); |
Contributor
There was a problem hiding this comment.
A failed write when forwarding a child subagent's event to the parent session's durable stream propagates out and crashes the child's turn, even though the child's own stream write already succeeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #667 (rebased onto latest main at
19862ccf; the v1 branch drifted after upstreamsession-delivery-hook→session-command-inbox+Runtime.run→createSessionrenames).subagent.evententries, ordered by child step index.stampMessageStreamEvent,UnstampedMessageStreamEvent,createSession,session.continuation.rekey).Validation
vitest run --config vitest.unit.config.ts src/execution/— 594/594 pass (62 files).tsc --noEmitclean.Closes #666.