fix(eve): show vercel login device URL in dev TUI /login prompt#153
Open
wjx wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jesse <hello.wjx@gmail.com>
|
@wjx is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the dev TUI,
/loginrunsvercel login, which prints a device-authorization URL on stderr. When running locally this isn't noticed because a browser opens automatically, but on a remote server no browser opens — and the URL was being suppressed by the open choice panel (which waits on "Complete the login in your browser"). With no visible URL, there was no way to finish login by hand.This change keeps the streaming
vercel loginsubprocess output (including the device URL) visible alongside the parked prompt's actions, instead of dropping it the way a single status line is. Apreviewfield carries the recent output buffer onto the question panel, capped to the last few lines.How did you test your changes?
packages/eve/src/cli/dev/tui/terminal-renderer.test.ts("shows subprocess output (e.g. a login URL) while a choice panel is open") asserting the device URL survives in the panel even after a later output line.pnpm typecheck— passedpnpm lint— passedpnpm fmt— cleanpnpm test(unit + integration) — passed (323 integration tests; new unit test passes)PR Checklist
CONTRIBUTING.mdevepackagegit commit --signoff)