fix(eve): finish cancellation through delegated agents#135
Open
remiconnesson wants to merge 1 commit into
Open
fix(eve): finish cancellation through delegated agents#135remiconnesson wants to merge 1 commit into
remiconnesson wants to merge 1 commit into
Conversation
Signed-off-by: Rémi Connesson <remiconnesson2@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #128 (with #127 and #118 beneath it).
Cancellation already reached delegated children, but after those children settled the parked parent turn resumed the model with cancellation errors. That could append an unexpected assistant message and complete the turn normally.
This PR preserves the cancelled outcome across the runtime-action callback. The resumed parent consumes the child results, starts with a live distributed signal, and is immediately cancelled instead of invoking the model again.
It also adds deterministic real-dev-server coverage for:
eveserverBoth scenarios assert the full failure cascade, absence of
subagent.completedandmessage.appended, and successful continuation on the original root session.Before / after evidence
Before #128, the tests showed that local children did not receive an
AbortSignaland remoteresponse.cancel()returnedfalse.On #128 before this fix, delegated children stopped, but their parents resumed and emitted an assistant response describing the cancellation.
With this change, local nested and remote delegated work stop, every active logical parent turn finishes as
TURN_CANCELLED, the root session returns tosession.waiting, and the next message continues that same session.Review guide
dev-server.scenario.test.ts; they are the executable end-to-end proof.cancelledmarker fromruntime-action-cancellation.tsthroughworkflow-entry.ts.turn-workflow.tsconsumes that marker by starting the resumed step with a live signal and immediately aborting it.