fix(teams): authenticate protected inline attachments - #749
Open
onmax wants to merge 2 commits into
Open
Conversation
Signed-off-by: onmax <maximogarciamtnez@gmail.com>
Contributor
|
@onmax is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: onmax <maximogarciamtnez@gmail.com>
onmax
marked this pull request as ready for review
July 28, 2026 06:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authenticates connector-hosted Teams inline attachments through the configured Bot Framework client, so
message.attachments[].fetchData()can retrieve protected content. Teams file download cards use their directcontent.downloadUrlanonymously, and serialized attachments reconstruct the same routing during rehydration.Bot credentials are limited to non-redirecting HTTPS requests whose origin exactly matches the Activity connector origin. Cross-origin URLs, HTTP URLs, and file-card download URLs never enter the authenticated client path.
File-card MIME inference covers common image and text formats plus PDF, XLS, and XLSX attachments.
The implementation follows Microsoft's inline-image access-token sample and Teams file-card contract.
Test plan
pnpm validatepnpm --filter @chat-adapter/teams test— 20 files and 257 tests passedpnpm --filter @chat-adapter/teams typecheckpnpm --filter @chat-adapter/teams... buildPossible follow-up
Evaluate
image-metafor consolidating image type and dimension detection from downloaded bytes across adapters. It does not replace this adapter's pre-fetch authentication routing or its PDF/Excel file-card MIME inference, so this PR deliberately adds no dependency or lockfile change.Checklist
git commit -s)pnpm validatepasses