fix(teams): classify group chats by conversation type - #746
Merged
Conversation
Contributor
|
@onmax is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: onmax <maximogarciamtnez@gmail.com>
onmax
force-pushed
the
fix/teams-group-chat-routing
branch
from
July 27, 2026 08:52
5ef60d3 to
516cb75
Compare
Signed-off-by: onmax <maximogarciamtnez@gmail.com>
bensabic
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
a:-prefixed Teams group chats being treated as DMs, so they use non-DM routing and buffered responses.Microsoft defines conversation IDs as opaque strings and
conversationTypeas the channel-provided conversation discriminator. The adapter therefore stores a classification override only whenconversationTypedisagrees with the legacy ID-prefix heuristic. Existing subscription and history keys remain stable when the heuristic was already correct. Explicit group chats also bypass stale DM Graph context, and Graph-listed child threads retain the override.Test plan
a:-prefixedgroupChat; all 12 Teams integration tests pass.pnpm validatewas not run locally because the workspace pnpm signature guard could not verify the package-manager registry signatures.Checklist
git commit -s)pnpm validatepasses