Skip to content

fix(teams): classify group chats by conversation type - #746

Merged
bensabic merged 2 commits into
vercel:mainfrom
onmax:fix/teams-group-chat-routing
Jul 27, 2026
Merged

fix(teams): classify group chats by conversation type#746
bensabic merged 2 commits into
vercel:mainfrom
onmax:fix/teams-group-chat-routing

Conversation

@onmax

@onmax onmax commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes a:-prefixed Teams group chats being treated as DMs, so they use non-DM routing and buffered responses.

Microsoft defines conversation IDs as opaque strings and conversationType as the channel-provided conversation discriminator. The adapter therefore stores a classification override only when conversationType disagrees with the legacy ID-prefix heuristic. Existing subscription and history keys remain stable when the heuristic was already correct. Explicit group chats also bypass stale DM Graph context, and Graph-listed child threads retain the override.

Test plan

  • The Teams webhook integration scenario exercises an a:-prefixed groupChat; all 12 Teams integration tests pass.
  • All 94 Teams adapter and Graph tests pass, including legacy-ID stability and stale DM-context coverage.
  • TypeScript and Biome checks pass for the affected packages and files.
  • GitHub changeset, lint, consistency, typecheck, AI SDK compatibility, and Node 22/24 build-and-test jobs pass.
  • pnpm validate was not run locally because the workspace pnpm signature guard could not verify the package-manager registry signatures.
  • Vercel previews were not created because fork deployments require authorization; these statuses did not run a build.

Checklist

  • All commits are signed and verified
  • All commits are signed off for the DCO (git commit -s)
  • pnpm validate passes
  • Changeset added (or N/A — see CONTRIBUTING.md)
  • Documentation updated (or N/A)

@onmax
onmax requested a review from a team as a code owner July 27, 2026 08:45
@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@onmax is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Signed-off-by: onmax <maximogarciamtnez@gmail.com>
@onmax
onmax force-pushed the fix/teams-group-chat-routing branch from 5ef60d3 to 516cb75 Compare July 27, 2026 08:52
Signed-off-by: onmax <maximogarciamtnez@gmail.com>
@bensabic
bensabic merged commit 257a32d into vercel:main Jul 27, 2026
12 of 14 checks passed
@onmax
onmax deleted the fix/teams-group-chat-routing branch July 27, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants