Repository navigation
refactor(backend-vercel): read a workflow's principal by identity alone, as Vercel's API sends it - #781
Merged
Conversation
…ne, as Vercel's API sends it
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vercel's API now sends a workflow's principal by who it is alone: a GitHub Actions run as its repository (
repositoryId,repository), another issuer's caller as itsissuerandsub. A token's other claims (a run's ref, workflow, and event, or an issuer's claims, which can name whoever started the job) stay with the request that carried them, for grant matching, and are no longer stored with what a workflow writes.ApiPrincipaldropsworkflowRef,ref, andeventfromgithubandclaimsfromoidc. Nothing read them: a workflow shows by its repository or itssub, as before.oidcactor's principal is its issuer andsubtoo, and its grants match thesubit carries.Validation
pnpm check: build, typecheck, and every test pass against the updated fake.