Conversation
Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
Fix #36 Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
|
/cc @tarunbang |
| @@ -0,0 +1,31 @@ | |||
| // Copyright 2020 Contributors to the Veraison project. | |||
There was a problem hiding this comment.
Could this file go under extensions/ folder ?
There was a problem hiding this comment.
why do we need to create another package?
There was a problem hiding this comment.
All extensions (for future) can reside there. Is it not much neater rather than residing in the base package ?
There was a problem hiding this comment.
The separation is not that clear cut: one still needs to put the extension structures inside the base package structures, so it's not like you have two independent packages that you can decide whether to compose (or not), you always have to have both.
|
|
||
| type AnyURI string | ||
|
|
||
| type TcgRimReferenceMeasurementEntry struct { |
There was a problem hiding this comment.
Could you please refer to the spec where this extension CDDL is defined ?
Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
| FirmwareManufacturerID *uint64 `cbor:"68,keyasint,omitempty" json:"firmware-manufacturer-id,omitempty"` | ||
| FirmwareManufacturerName *string `cbor:"69,keyasint,omitempty" json:"firmware-manufacturer-name,omitempty"` | ||
| FirmwareModelName *string `cbor:"70,keyasint,omitempty" json:"firmware-model-name,omitempty"` | ||
| FirmwareVersion *uint64 `cbor:"71,keyasint,omitempty" json:"firmware-version,omitempty"` |
There was a problem hiding this comment.
Any reason why ? boot-events => [ * boot-event-entry ],
is skipped?
There was a problem hiding this comment.
May be I am referring to this: https://datatracker.ietf.org/doc/html/draft-birkholz-rats-coswid-rim-02
This is out of sync to the reference you mentioned above...
There was a problem hiding this comment.
this is definitely a question for @henkbirkholz
2 participants
Fix #36