Skip to content

Print sizes of the QML and Lisp payloads when building packages #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vedderb merged 1 commit into from
May 11, 2026
Merged

Print sizes of the QML and Lisp payloads when building packages #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions codeloader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1258,6 +1258,22 @@ bool CodeLoader::createPackageFromDescription(QString path, VescPackage *pkgRes,
file.write(packVescPackage(pkg));
file.close();
qDebug() << "Package saved as" << pkgOutput;

const int flashBlockSize = 128 * 1024;

if (!pkg.qmlFile.isEmpty()) {
int compressedQmlSize = qmlCompress(pkg.qmlFile).size();
qDebug().noquote() << QString("Compressed QML size : %1 / %2 bytes (%3%)")
.arg(compressedQmlSize).arg(flashBlockSize)
.arg(100.0 * compressedQmlSize / flashBlockSize, 0, 'f', 1);
}

if (!pkg.lispData.isEmpty()) {
int lispSize = pkg.lispData.size();
qDebug().noquote() << QString("Lisp data size : %1 / %2 bytes (%3%)")
.arg(lispSize).arg(flashBlockSize)
.arg(100.0 * lispSize / flashBlockSize, 0, 'f', 1);
}
} else {
qWarning() << QString("Could not open %1 for writing.").arg(pkgOutput);
result = false;
Expand Down
16 changes: 16 additions & 0 deletions main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,6 +994,22 @@ int main(int argc, char *argv[])
file.write(loader.packVescPackage(pkg));
file.close();

const int flashBlockSize = 128 * 1024;

if (!pkg.qmlFile.isEmpty()) {
int compressedQmlSize = loader.qmlCompress(pkg.qmlFile).size();
qDebug().noquote() << QString("Compressed QML size : %1 / %2 bytes (%3%)")
.arg(compressedQmlSize).arg(flashBlockSize)
.arg(100.0 * compressedQmlSize / flashBlockSize, 0, 'f', 1);
}

if (!pkg.lispData.isEmpty()) {
int lispSize = pkg.lispData.size();
qDebug().noquote() << QString("Lisp data size : %1 / %2 bytes (%3%)")
.arg(lispSize).arg(flashBlockSize)
.arg(100.0 * lispSize / flashBlockSize, 0, 'f', 1);
}

qDebug() << "Package Saved!";
return 0;
}
Expand Down
1 change: 1 addition & 0 deletions mobile/ConfigPageCustom.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ Item {
}
MenuItem {
text: "Save XML"
// HERE save
onTriggered: {
if (Utility.requestFilePermission()) {
fileDialogSave.close()
Expand Down
1 change: 1 addition & 0 deletions mobile/Packages.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ Item {
}
}

// HERE install
function openPkgDialog(pkg) {
var line1 = pkg.description.slice(0, pkg.description.indexOf("\n"))
if (line1.toUpperCase().includes("<!DOCTYPE HTML PUBLIC")) {
Expand Down
1 change: 1 addition & 0 deletions mobile/StartPage.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,7 @@ Item {
}

Dialog {
// HERE Backup
id: backupConfigDialog
standardButtons: Dialog.Ok | Dialog.Cancel
modal: true
Expand Down
Loading