Encoder: Add mechanical slip detection - #453
Closed
fbg-jpg wants to merge 1 commit into
Closed
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
fbg-jpg
force-pushed
the
feature/add-loose-magnet-fault
branch
from
March 11, 2026 13:48
476e651 to
4757554
Compare
fbg-jpg
force-pushed
the
feature/add-loose-magnet-fault
branch
from
April 28, 2026 08:46
4757554 to
e34ac98
Compare
fbg-jpg
changed the title
Owner
|
I combined this setting with some other faults and updated the implementation in bldc accordingly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is connected to changes from the BLDC repo. These things are needed in order for the loose magnet fault to be displayed in the vesc tool. Also I noticed that the "mc_fault_code" enum from "datatypes.h" is missing a fault that is present in BLDC, so I added that as well so the enums will match. As requested I also made this change to be configurable from FOC-> Advanced tab
vedderb/bldc#892