Blacktip DPV: Fix Stuck Display Conditions. - #103
Open
mikeller wants to merge 2 commits into
Open
Conversation
Fix some conditions that can lead to a stuck display in 'off' state.
Bump to 1.4.1 bugfix release.
There was a problem hiding this comment.
Pull request overview
This PR addresses a reliability issue in the Blacktip DPV display shutdown path by adding a defensive I2C sequence to ensure the panel cannot remain lit due to a transient dropped display-off transaction, and adds a regression test + release note for the behavior.
Changes:
- Clear the Blacktip display framebuffer before issuing display-off, and retry the display-off command.
- Adjust battery display loop state reset condition when the timer is cancelled.
- Add a Python test that mirrors/verifies the new Blacktip display-timeout I2C command sequence, and document the change in the README (version bump + changelog entry).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| blacktip_dpv/blacktip_dpv.lisp | Adds defensive Blacktip display shutdown sequence (blank + double off) and tweaks battery-display state reset logic. |
| blacktip_dpv/tests/run_tests.py | Adds simulation + test coverage for the defensive display-timeout I2C sequence and wires it into the test runner. |
| blacktip_dpv/README.md | Bumps version to 1.4.1 and documents the stuck-display bugfix in the changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| Bugfix release: | ||
|
|
||
| - **Fix: Stuck display in 'off' state** — After the scooter shuts off the display, a transient I2C fault could silently drop the display-off command, leaving the last frame latched on the panel. Fixed by clearing the framebuffer first (so even a partially-delivered write leaves the panel blank) and by retrying the display-off command so that a single dropped transaction cannot keep the display lit indefinitely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some conditions that can lead to a stuck display in 'off' state.