vbms32_micro.lisp charge-ok fix - #100
Open
Seminko wants to merge 2 commits into
Open
Conversation
Since vc_charge_start can be set higher than vc_charge_end in VESC tool, we need to always check for that, regardless of charging state
Charging should only start if the voltage is lower than vc_charge_start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since vc_charge_start can be set higher than vc_charge_end in VESC tool (created an ISSUE for that), we need to always check for that scenario regardless of charging status + charging should only start if c-max is lower than vc_charge_start.
EDIT: I have some more fixes that might be useful for others but I wouldn't put them inside this official script. Would you accept it if I created a new package, eg "vbms32_micro_mortificator_custom"? Or if you have a different naming convention in mind, let me know.