Enable 700 kHz I2C on more Onewheel-relevant controllers - #923
Merged
Conversation
According to the datasheet BMI160 can go up to 1 MHz. According to manufacturer, the pullups are 3.9 kOhm.
These controllers have 10 kOhm pullups (which could be too slow for this bus speed) but in practice the faster speed has worked without any issues on multiple units of both controllers.
The pullups are 1.2 kOhm, safe to enable.
Contributor
Author
|
After the confirmation of ADV500 pullups, adding the enablement for that too (plus a small cleanup). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable 700 kHz I2C on most Onewheel-relevant controllers left out of the original PR. The pullups on all of them were verified with the manufacturers.
Thor300 / JF F6 are potentially problematic with 10k pullups, never manifested an issue in practice though. The I2C BB lib also enables the internal 40k pullups, which bring the overall resistivity down a bit more.
I also inquired about the ADV500 (I think it's pretty safe to assume the pullups are the same as on ADV200 which is a copy of Little FOCer v3 but wanted to confirm) but still waiting for a reply so posting these now and I'll post ADV500 once I get a response.
Please don't squash commits.
I don't see a 7.01 branch yet so assuming it'll be branched off master later and these will get in.