Add option for 16Mhz XTAL as well as 8Mhz - #797
Open
etharooni wants to merge 1 commit into
Open
Conversation
|
I think give a default(in here 8M) and can be overwrite in hw_xxx.h is better. The overwrite function can be generated by cubemx and a small script. |
|
I think that's a good change to be implemented. The changed code seems to implement the default behavior for 8mhz crystal and keep the compatibility with existing hwconf files, while providing an option to use other HSE values for hardware developers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom VESC hardware uses 16Mhz crystal. I needed support from this in its specific hwconf file.